Displaying 5 results from an estimated 5 matches for "guestfs_compare_xattr_list".
2015 Jan 05
2
Re: [PATCH] virt-diff: add additional ignore options
Hi,
In data venerdì 2 gennaio 2015 23:57:43, Gabriele Cerami ha scritto:
> added:
> --no-compare-xattrs
> --no-compare-extra-stats
> --no-compare-perms
> --no-compare-uids
> --no-compare-times
>
> to ignore specified files informations when comparing.
>
> The current strategy to disable comparison on file informations is to
> flatten data structure so they
2015 Jan 06
0
[PATCH] virt-diff: add additional ignore options
...].stat = stat;
t->files[i].xattrs = xattrs;
t->files[i].csum = csum;
+ t->files[i].stat_orig = stat_copy;
+ t->files[i].xattrs_orig = xattrs_copy;
return 0;
@@ -631,10 +684,11 @@ compare_stats (struct file *file1, struct file *file2)
if (r != 0)
return r;
- r = guestfs_compare_xattr_list (file1->xattrs, file2->xattrs);
- if (r != 0)
- return r;
-
+ if (compare_xattrs) {
+ r = guestfs_compare_xattr_list (file1->xattrs, file2->xattrs);
+ if (r != 0)
+ return r;
+ }
return 0;
}
@@ -778,29 +832,29 @@ output_file (guestfs_h *g, struct file *file)...
2015 Jan 06
0
Re: [PATCH] virt-diff: add additional ignore options
...is feasible but
not similar to the strategies for others "ignore flags" (that is flatten)
and for example cannot be done with extra-stats. I can do it, but I did
not considered it because it moves the logic for "ignoring" away from
the other checks.
Regarding the third proposal guestfs_compare_xattr_list and
guestfs_compare_xattr expect the struct not to be NULL, so if I call
those functions, I cannot pass a NULL pointer and setting len to 0 was
the only way to make the function return the value I wanted (0 - not
diff)
Thanks for the suggestion, I'll submit the corrections as soon as I can.
2015 May 26
6
[PATCH 0/6] Update the way that API versions are generated for the man page.
The existing mechanism was clunky, slow and used ~ 10 MB of
local disk.
Rich.
2014 Sep 22
2
[PATCH] New APIs: Implement stat calls that return nanosecond timestamps (RHBZ#1144891).
...ARE_STAT (st_uid);
+ COMPARE_STAT (st_gid);
+ COMPARE_STAT (st_rdev);
+ COMPARE_STAT (st_size);
+ COMPARE_STAT (st_blksize);
+ COMPARE_STAT (st_blocks);
+ COMPARE_STAT (st_atime_sec);
+ COMPARE_STAT (st_mtime_sec);
+ COMPARE_STAT (st_ctime_sec);
#undef COMPARE_STAT
if (guestfs_compare_xattr_list (file1->xattrs, file2->xattrs))
output_string ("xattrs");
@@ -701,8 +702,8 @@ diff (struct file *file1, guestfs_h *g1, struct file *file2, guestfs_h *g2)
CLEANUP_FREE char *tmpd, *tmpda = NULL, *tmpdb = NULL, *cmd = NULL;
int r;
- assert (is_reg (file1->stat->m...