search for: guestfs_case_sensitive_path

...- a/generator/actions.ml +++ b/generator/actions.ml @@ -7150,13 +7150,32 @@ a problem. Bug or feature? You decide: L<http://www.tuxera.com/community/ntfs-3g-faq/#posixfilenames1> -This function resolves the true case of each element in the -path and returns the case-sensitive path. +C<guestfs_case_sensitive_path> attempts to resolve the true case of +each element in the path. It will return a resolved path if either the +full path or its parent directory exists. If the parent directory +exists but the full path does not, the case of the parent directory +will be correctly resolved, and the remainder app...

...e changed, 3 insertions(+) diff --git a/generator/actions.ml b/generator/actions.ml index c73a319..32758b1 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -7161,6 +7161,9 @@ created under Windows). I<Note>: This function does not handle drive names, backslashes etc. +C<guestfs_case_sensitive_path> will return an error if given a path +which does not exist. + See also C<guestfs_realpath>." }; { defaults with -- 1.8.3.1

Proposed patches to fix https://bugzilla.redhat.com/show_bug.cgi?id=858126

From: "Richard W.M. Jones" <rjones at redhat.com> Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was changed so that if th...

The current location doesn't exist unless you've installed GNOME, which is not so common on Ubuntu. Unfortunately I couldn't find any other location containing a clean, high quality logo. This adds another low quality icon source, and also prevents any icon being returned if the highquality flag was set (note this prevents virt-manager from displaying an icon, but there's nothing

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

...i; - char *systemroot; - fs->type = OS_TYPE_WINDOWS; fs->distro = OS_DISTRO_WINDOWS; - i = guestfs___has_windows_systemroot (g); - if (i == -1) { - error (g, "check_windows_root: has_windows_systemroot unexpectedly returned -1"); - return -1; - } - - systemroot = guestfs_case_sensitive_path (g, systemroots[i]); - if (!systemroot) - return -1; - - debug (g, "windows %%SYSTEMROOT%% = %s", systemroot); - /* Freed by guestfs___free_inspect_info. */ fs->windows_systemroot = systemroot; @@ -179,7 +177,7 @@ check_windows_arch (guestfs_h *g, struct inspect_fs *fs)...

.../WINDOWS/SYSTEM32 depending entirely on the inconsequential details of how it was originally created. Windows doesn't care about case sensitivity, but NTFS 3g does. Since resolve_windows_path is a very useful function, the first patch moves it into the daemon. The new API is called "guestfs_case_sensitive_path". The second patch adds some useful functionality to guestfish, so you can use Windows-style paths, like this: touch win:C:\windows\foo (Note that all ordinary paths must begin with a '/' char, so this can't conflict with any existing, working scripts). The third patch deprec...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Hi, this series does a couple of code reorganizations/refactoring in code used by tools: the windows path handling code, and the two types of file editing (using editor, and using perl expression). There's still a code duplication between the two variants of file editing, but it is just within a single source, and can be easily solved now (planning as next step). Pino Toscano (13): edit:

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

Various changes/fixes to use smaller stack frames. Rich.

...sprintf (g, "%s/system32/config/software", fs->windows_systemroot); CLEANUP_FREE char *software_path; struct guestfs_application2_list *ret = NULL; - snprintf (software, len, "%s/system32/config/software", - fs->windows_systemroot); - software_path = guestfs_case_sensitive_path (g, software); if (!software_path) return NULL; diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index c209fc3..4120d31 100644 --- a/src/inspect-fs-unix.c +++ b/src/inspect-fs-unix.c @@ -231,8 +231,8 @@ parse_os_release (guestfs_h *g, struct inspect_fs *fs, const char *filename)...

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

Hi, the libguestfs library uses a number of external tools; for some of them, we search for them at build time, enabling some feature only if found, and later on assuming at runtime they are installed. However, the situation is more complex than that: - hardcoding the full path means that there is an incoherency in the way some of the tools are used, as some other tools (e.g. qemu-img) are

...quot;; added = (1, 0, 66); @@ -4623,7 +4623,7 @@ they were created. In Windows itself this would not be a problem. Bug or feature? You decide: -L<http://www.tuxera.com/community/ntfs-3g-faq/#posixfilenames1> +L<https://www.tuxera.com/community/ntfs-3g-faq/#posixfilenames1> C<guestfs_case_sensitive_path> attempts to resolve the true case of each element in the path. It will return a resolved path if either the @@ -4744,10 +4744,10 @@ file of zeroes, use C<guestfs_fallocate64> instead." }; This command sets the timestamps of a file with nanosecond precision. -C<atsecs, atnsecs...

The first three patches were posted previously: https://www.redhat.com/archives/libguestfs/2010-July/msg00082.html The last two patches in this series change guestfish -i to use this new code. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to

These three patches (two were previously posted) can do simple operating system inspection in C. Example of use: ><fs> add-ro rhel55.img ><fs> run ><fs> inspect-os /dev/VolGroup00/LogVol00 ><fs> inspect-get-type /dev/VolGroup00/LogVol00 linux ><fs> inspect-get-distro /dev/VolGroup00/LogVol00 rhel ><fs> inspect-get-arch

Previously discussed here: https://www.redhat.com/archives/libguestfs/2010-August/msg00002.html -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I