search for: guestfs_application2_list

...guest images. --- src/inspect-apps.c | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 125 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index b62b432..b7a3b0e 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guest...

...Alpine Linux). --- src/inspect-apps.c | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 121 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index b54cf07..78c32bf 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -49,6 +49,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, st #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list...

...gmail.com> --- src/inspect-apps.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 137 insertions(+) diff --git a/src/inspect-apps.c b/src/inspect-apps.c index 6fb9665..8e645b7 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -60,6 +60,7 @@ static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); #endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guest...

...125 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 125 insertions(+) > > diff --git a/src/inspect-apps.c b/src/inspect-apps.c > index b62b432..b7a3b0e 100644 > --- a/src/inspect-apps.c > +++ b/src/inspect-apps.c > @@ -60,6 +60,7 @@ > static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); > #endif > static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); > +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); >...

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

...++++++++++++++++++++++++++ >> 1 file changed, 125 insertions(+) >> >> diff --git a/src/inspect-apps.c b/src/inspect-apps.c >> index b62b432..b7a3b0e 100644 >> --- a/src/inspect-apps.c >> +++ b/src/inspect-apps.c >> @@ -60,6 +60,7 @@ >> static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, struct inspect_fs *fs); >> #endif >> static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, struct inspect_fs *fs); >> +static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs...

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

...for any package read from the guest. --- lib/inspect-apps.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index 1216c52..eabe565 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -51,7 +51,7 @@ static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, st static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_apk (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_ap...

...for any package read from the guest. --- lib/inspect-apps.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index 1216c52..eabe565 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -51,7 +51,7 @@ static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, st static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_applications_apk (guestfs_h *g, struct inspect_fs *fs); static struct guestfs_application2_list *list_ap...

...* defined(DB_DUMP) */ diff --git a/lib/inspect-apps.c b/lib/inspect-apps.c index f0cf16b38..57428a3ba 100644 --- a/lib/inspect-apps.c +++ b/lib/inspect-apps.c @@ -45,9 +45,7 @@ #include "guestfs-internal-actions.h" #include "structs-cleanups.h" -#ifdef DB_DUMP static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, const char *root); -#endif static struct guestfs_application2_list *list_applications_deb (guestfs_h *g, const char *root); static struct guestfs_application2_list *list_applications_pacman (guestfs_h *g, const char *root); static struct guestfs_application2...

We went around the houses a few times last year in order to try to fix this old Debian bug: https://bugzilla.redhat.com/show_bug.cgi?id=1409024 My last attempt was: https://www.redhat.com/archives/libguestfs/2017-October/msg00058.html which I believe was neither reviewed nor rejected, so I'm reposting the same patch again, simply rebased against current git. Rich.

Previously posted: https://www.redhat.com/archives/libguestfs/2017-October/msg00032.html This takes a completely different approach. It turns out that POSIX / the shell already defines a special exit code 127 for ‘command not found’. We can make a small adjustment to lib/command.c to return this exit code in that case. Then we just have to modify the db_dump code to test for this exit code. I

I got a recent report of virt-v2v (via virt-p2v) failing to migrate a Fedora guest. The issue was that its /var/lib/rpm/Packages was bigger than our current limit (~410M vs 300M), hence the inspection failed. I took the liberty to refactor the limits of the these files, bumping the problematic one, and reducing the ones of the others (as they are supposed to be way smaller than the limit). Pino

...virt-v2v: error: no installed kernel packages were found. This is because no kernel packages are found in the guest, and indeed I can see in the log: libguestfs: trace: v2v: inspect_list_applications2 "/dev/vg0/lv-root" libguestfs: trace: v2v: inspect_list_applications2 = <struct guestfs_application2_list(0)> Since it's a own build, most probably libdb-utils was not installed when configure was run, and thus libguestfs did not download and inspect the content of the RPM DB in the guest. See also http://libguestfs.org/guestfs-building.1.html for the list of mandatory, and optional build &amp...

...300 * 1000 * 1000) +#define MAX_DPKG_STATUS_SIZE (50 * 1000 * 1000) /* Maximum APK 'installed' file we will download to /tmp. */ -#define MAX_APK_INSTALLED_SIZE (300 * 1000 * 1000) +#define MAX_APK_INSTALLED_SIZE (50 * 1000 * 1000) #ifdef DB_DUMP static struct guestfs_application2_list *list_applications_rpm (guestfs_h *g, const char *root); -- 2.17.2

On Tue, Jul 11, 2017 at 10:31:28PM +0100, Richard W.M. Jones wrote: > On Tue, Jul 11, 2017 at 07:40:01PM +0000, Zach Seils (seils) wrote: > > While trying to convert an OVA exported from VMware vSphere to libvirt using virt-v2v, I get the following error: > > > > virt-v2v: error: no installed kernel packages were found. > > > > Environment info: > > >

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

This needs Richard's patch: https://www.redhat.com/archives/libguestfs/2018-February/msg00099.html Diff to v1: * factorized the UTF-8 conversion functions * small style fixes Cédric Bosdonnat (2): common: extract UTF-8 conversion function inspector: rpm summary and description may not be utf-8 common/utils/guestfs-utils.h | 1 + common/utils/libxml2-utils.c

...* http://www.rpm.org/max-rpm/s1-rpm-file-format-rpm-file-format.html#S2-RPM-FILE-FORMAT-HEADER + * http://rpm.org/devel_doc/file_format.html#24-header-format */ /* The minimum header size that makes sense here is 24 bytes. Four @@ -301,6 +303,20 @@ struct read_package_data { struct guestfs_application2_list *apps; }; +static char * +to_utf8 (guestfs_h *g, char *input) +{ + char *out = NULL; + + out = guestfs_int_string_to_utf8 (input, "UTF-8"); + if (!out) { + out = guestfs_int_string_to_utf8 (input, "ISO-8859-1"); + perrorf (g, "Not an UTF-8 or latin-1 string: ...

...* http://www.rpm.org/max-rpm/s1-rpm-file-format-rpm-file-format.html#S2-RPM-FILE-FORMAT-HEADER + * http://rpm.org/devel_doc/file_format.html#24-header-format */ /* The minimum header size that makes sense here is 24 bytes. Four @@ -301,6 +303,20 @@ struct read_package_data { struct guestfs_application2_list *apps; }; +static char * +to_utf8 (guestfs_h *g, char *input) +{ + char *out = NULL; + + out = guestfs_int_string_to_utf8 (input, "UTF-8"); + if (!out) { + out = guestfs_int_string_to_utf8 (input, "ISO-8859-1"); + perrorf (g, "Not an UTF-8 or latin-1 string: ...