search for: guestfs_appli

All SUSE distros have a ID_LIKE=suse, including the fake one used for building that has a ID=Dummy value. Without reading ID_LIKE on SUSE distros, the generated appliance packagelist is not correct. This fix reads ID_LIKE as a fallback if ID contains nothing. --- m4/guestfs_appliance.m4 | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index fbba3373f..788afbd36 100644 --- a/m4/guestfs_appliance.m4 +++ b/m4/guestfs_appliance.m4 @@ -99,8 +99,16 @@ if test -f /etc/os-release; then DISTRO="...

...rovide ID=.., or the ID is not recognized yet). In the case when --with-distro is not set, keep doing the autodetection, but using os-release only, i.e. dropping the checks for all the other -release files -- since there is --with-distro, older distros with no os-release can still be used. --- m4/guestfs_appliance.m4 | 44 +++++++++++++++++++------------------------- 1 file changed, 19 insertions(+), 25 deletions(-) diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index fbba3373f..4993f57a1 100644 --- a/m4/guestfs_appliance.m4 +++ b/m4/guestfs_appliance.m4 @@ -94,31 +94,25 @@ dnl names var...

Use /etc/os-release as first option, translating the distro name to the current identifier used. The other options (the release files) are left as following checks, avoiding them if any matches. --- m4/guestfs_appliance.m4 | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index 8cff51e..b48da74 100644 --- a/m4/guestfs_appliance.m4 +++ b/m4/guestfs_appliance.m4 @@ -94,24 +94,29 @@ dnl names vary slightly across distr...

...KE=suse, including the fake one used > > for building that has a ID=Dummy value. Without reading ID_LIKE > > on SUSE distros, the generated appliance packagelist is not correct. > > > > This fix reads ID_LIKE as a fallback if ID contains nothing. > > --- > >  m4/guestfs_appliance.m4 | 10 +++++++++- > >  1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > > index fbba3373f..788afbd36 100644 > > --- a/m4/guestfs_appliance.m4 > > +++ b/m4/guestfs_appliance.m4 > >...

...> is super minimal and only had ID_LIKE=suse. The code setting the > > DISTRO variable only searches for ID variable so far, resulting in > > invalid packagelist on openSUSE. > > > > This fix reads ID_LIKE as a fallback if ID contains nothing. > > --- > >  m4/guestfs_appliance.m4 | 8 +++++++- > >  1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > > index fbba3373f..ce45256bc 100644 > > --- a/m4/guestfs_appliance.m4 > > +++ b/m4/guestfs_appliance.m4 > > @@...

On Thu, May 04, 2017 at 02:20:29PM +0300, Pavel Butsykin wrote: > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/Makefile.am | 1 - > m4/guestfs_appliance.m4 | 11 +++++++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/lib/Makefile.am b/lib/Makefile.am > index 063706f8f..18b6dd678 100644 > --- a/lib/Makefile.am > +++ b/lib/Makefile.am > @@ -130,7 +130,6 @@ libguestfs_la_SOURCES = \ > libguestfs....

On Fri, Jun 23, 2017 at 04:12:36PM +0300, Pavel Butsykin wrote: > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > m4/guestfs_appliance.m4 | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index 81c43879f..7e8d28271 100644 > --- a/m4/guestfs_appliance.m4 > +++ b/m4/guestfs_appliance.m4 > @@ -139,3 +139,14 @@ AC_SUBST([GUESTFS_DEFAULT_P...

...ages for openSUSE, os-release > is super minimal and only had ID_LIKE=suse. The code setting the > DISTRO variable only searches for ID variable so far, resulting in > invalid packagelist on openSUSE. > > This fix reads ID_LIKE as a fallback if ID contains nothing. > --- > m4/guestfs_appliance.m4 | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index fbba3373f..ce45256bc 100644 > --- a/m4/guestfs_appliance.m4 > +++ b/m4/guestfs_appliance.m4 > @@ -97,9 +97,15 @@ AC_MSG_CHECKING([wh...

...All SUSE distros have a ID_LIKE=suse, including the fake one used > for building that has a ID=Dummy value. Without reading ID_LIKE > on SUSE distros, the generated appliance packagelist is not correct. > > This fix reads ID_LIKE as a fallback if ID contains nothing. > --- > m4/guestfs_appliance.m4 | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index fbba3373f..788afbd36 100644 > --- a/m4/guestfs_appliance.m4 > +++ b/m4/guestfs_appliance.m4 > @@ -99,8 +99,16 @@ if test -f /etc/...

...can think of something else (if you still need the feature) because it will simply break with libvirt >= 6.0. Rich. > Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com> > --- > lib/launch-direct.c | 2 ++ > lib/launch-libvirt.c | 19 ++++++++++++------- > m4/guestfs_appliance.m4 | 11 +++++++++++ > 3 files changed, 25 insertions(+), 7 deletions(-) > > diff --git a/lib/launch-direct.c b/lib/launch-direct.c > index 0be662e25..b9b54857a 100644 > --- a/lib/launch-direct.c > +++ b/lib/launch-direct.c > @@ -592,7 +592,9 @@ launch_direct (guestfs_h *g...

By passing root=UUID=... to supermin, we make the appliance boot process less sensitive to the non-deterministic process of scanning SCSI disks (of which much more to come). This patch should be tested alongside the supermin patch posted here: https://www.redhat.com/archives/libguestfs/2017-April/msg00174.html which in turn requires this supermin patch series:

...he appliance used to build the packages for openSUSE, os-release is super minimal and only had ID_LIKE=suse. The code setting the DISTRO variable only searches for ID variable so far, resulting in invalid packagelist on openSUSE. This fix reads ID_LIKE as a fallback if ID contains nothing. --- m4/guestfs_appliance.m4 | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 index fbba3373f..ce45256bc 100644 --- a/m4/guestfs_appliance.m4 +++ b/m4/guestfs_appliance.m4 @@ -97,9 +97,15 @@ AC_MSG_CHECKING([which Linux distro for package names]...

...s_fuse.m4]) dnl The daemon and any dependencies. +AS_ECHO +AS_ECHO(["Checking the daemon and its dependencies:"]) m4_include([m4/guestfs_daemon.m4]) dnl The appliance and any dependencies. +AS_ECHO +AS_ECHO(["Checking the appliance and its dependencies:"]) m4_include([m4/guestfs_appliance.m4]) dnl Check for QEMU. +AS_ECHO +AS_ECHO(["Checking for QEMU:"]) m4_include([m4/guestfs_qemu.m4]) dnl Miscellaneous libraries used by other programs. +AS_ECHO +AS_ECHO(["Checking for other libraries:"]) m4_include([m4/guestfs_misc_libraries.m4]) dnl Check for la...

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

...ndencies:"]) +HEADING([Checking the daemon and its dependencies]) m4_include([m4/guestfs_daemon.m4]) dnl The appliance and any dependencies. -AS_ECHO -AS_ECHO(["Checking the appliance and its dependencies:"]) +HEADING([Checking the appliance and its dependencies]) m4_include([m4/guestfs_appliance.m4]) dnl Check for QEMU. -AS_ECHO -AS_ECHO(["Checking for QEMU:"]) +HEADING([Checking for QEMU]) m4_include([m4/guestfs_qemu.m4]) dnl Miscellaneous libraries used by other programs. -AS_ECHO -AS_ECHO(["Checking for other libraries:"]) +HEADING([Checking for other libr...

If the connection is not local, paths of disks will refer to the remote host, which were mistakenly handled as local paths (in the best case failing to open a non-existing disk, and in the worst case opening a different disk!). In case the disks are remote resources like ssh or ceph, nothing guarantees that the hostname can be reached from the local machine, or even that it is actually the same on

Hopefully this time ...