search for: guestfs_add_domain_argv

...guest = optarg; + ddrv->next = NULL; + break; + + case HELP_OPTION: + diff_usage (EXIT_SUCCESS); + + default: + diff_usage (EXIT_FAILURE); + } + } + + if (sdrv == NULL) + diff_usage (EXIT_FAILURE); + if (ddrv == NULL) + diff_usage (EXIT_FAILURE); + + struct guestfs_add_domain_argv optargs = { + .bitmask = 0, + .libvirturi = libvirt_uri, + .readonly = 1, + .allowuuid = 1, + .readonlydisk = "read", + }; + nr = guestfs_add_domain_argv (sg, sdrv->d.guest, &optargs); + if (nr == -1) + exit (EXIT_FAILURE); + sdrv->nr_drives = nr; + nr = g...

Hello, The API/ABI interface of the libguestfs library is now checked for backward compatibility in the Upstream Tracker project: https://abi-laboratory.pro/tracker/timeline/libguestfs/ Hope the report will be helpful for users and maintainers of the library. Thank you.

...domain_optargs.readonly = readonly; domain_optargs.allowuuid = 1; - if (connect) { + if (libvirt_uri) { domain_optargs.bitmask |= GUESTFS_ADD_DOMAIN_LIBVIRTURI_BITMASK; - domain_optargs.libvirturi = connect; + domain_optargs.libvirturi = libvirt_uri; } if (guestfs_add_domain_argv (g, drives->value, &domain_optargs) == -1) { GERROR (g, "domain %s", drives->value); diff --git a/plugins/libvirt/libvirt-plugin.c b/plugins/libvirt/libvirt-plugin.c index 71cac42..5fdaef3 100644 --- a/plugins/libvirt/libvirt-plugin.c +++ b/plugins/libvirt/libvirt-plugin....

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...fffca7fb790) at ../../../lib/actions-4.c:174 #21 0x00007ffff4812cf6 in guestfs_impl_add_domain (g=g@entry=0x7fffbc008d60, domain_name=domain_name@entry=0x7fffbc0338e0 "tve50:00000013", optargs=optargs@entry=0x7fffca7fb8c0) at ../../../lib/libvirt-domain.c:163 #22 0x00007ffff4760368 in guestfs_add_domain_argv (g=0x7fffbc008d60, dom=0x7fffbc0338e0 "tve50:00000013", optargs=optargs@entry=0x7fffca7fb8c0) at ../../../lib/actions-0.c:139 #23 0x00007ffff47dfc38 in guestfs_add_domain_va (g=<optimized out>, dom=<optimized out>, args=args@entry=0x7fffca7fb920) at ../../../lib/actions-varian...

...free ((char **) optargs_s.%s);\n" n > maint.mk: don't cast free argument > make: *** [sc_cast_of_argument_to_free] Error 1 It seems to me this is another shortcoming of 'const' in C. We currently define the optargs structs as having const char * string fields, eg: struct guestfs_add_domain_argv { //... const char *libvirturi; //... } I tried to change this so that the fields are plain 'char *' but the structs are const, but that doesn't work. ie. The following code would not work: some_func (const char *uri) { const struct guestfs_add_domain_argv optargs = { libvirt...

...estfs.so.0 #17 0x00007ffff4813cd6 in ?? () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #18 0x00007ffff47ab2c3 in guestfs_add_libvirt_dom_argv () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #19 0x00007ffff4812cf6 in ?? () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #20 0x00007ffff4760368 in guestfs_add_domain_argv () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #21 0x00007ffff47dfc38 in guestfs_add_domain_va () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #22 0x00007ffff47dfee4 in guestfs_add_domain () from /usr/lib/x86_64-linux-gnu/libguestfs.so.0 #23 0x00007ffff4a78bec in refresh_lists (inst=inst@entry...

.../libvirt-domain.c b/src/libvirt-domain.c index 79e7ba6..124eef0 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -52,7 +52,7 @@ ignore_errors (void *ignore, virErrorPtr ignore2) int guestfs_impl_add_domain (guestfs_h *g, const char *domain_name, - const struct guestfs_add_domain_argv *optargs) + const struct guestfs_add_domain_argv *optargs) { virErrorPtr err; virConnectPtr conn = NULL; @@ -70,23 +70,23 @@ guestfs_impl_add_domain (guestfs_h *g, const char *domain_name, struct guestfs_add_libvirt_dom_argv optargs2 = { .bitmask = 0 }; libvirturi = optargs->bi...

...65 1.36.x build failure: gtkdocize fails using newer autotools due to missing GTK_DOC_CHECK in configure.ac https://bugzilla.redhat.com/1460338 guestfs_shutdown hangs if main process sets signal handlers https://bugzilla.redhat.com/1459979 guestfs_add_domain_argv fails with readonly option when vdi/vhd disk is attached to libvirt domain https://bugzilla.redhat.com/1451665 RFE: Virt-v2v can't convert the guest which has encrypted partition https://bugzilla.redhat.com/1450325 document URI format for -a para...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

This series is based on my blog posting here: https://rwmj.wordpress.com/2019/09/13/nbdkit-supports-exportnames/ It depends on the fix for realloc: https://www.redhat.com/archives/libguestfs/2019-September/thread.html#00103 This series adds a fun plugin, and also an semi-related feature I've long thought to be desirable. You can consider patches 1 & 4, and patches 2 & 3 as forming

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.