search for: guestfs___print_timestamped_messag

...rc/launch.c b/src/launch.c index 9deb0cf..07a89ec 100644 --- a/src/launch.c +++ b/src/launch.c @@ -927,7 +927,7 @@ build_supermin_appliance (guestfs_h *g, const char *path, int r, len; if (g->verbose) - print_timestamped_message (g, "begin building supermin appliance"); + guestfs___print_timestamped_message (g, "begin building supermin appliance"); len = strlen (g->tmpdir); *kernel = safe_malloc (g, len + 8); @@ -950,7 +950,7 @@ build_supermin_appliance (guestfs_h *g, const char *path, path, *kernel, *initrd); if (g->verbose) - print_timestamped...

https://bugzilla.redhat.com/show_bug.cgi?id=769680

...const char *supermin_path, const char *checksum, char **kernel, char **initrd, char **appliance); +static pid_t fork_helper(guestfs_h *g); /* Locate or build the appliance. * @@ -170,19 +172,59 @@ calculate_supermin_checksum (guestfs_h *g, const char *supermin_path) if (g->verbose) guestfs___print_timestamped_message (g, "%s", cmd); - /* Errors here are non-fatal, so we don't need to call error(). */ - FILE *pp = popen (cmd, "r"); - if (pp == NULL) + int fds[2]; + if (pipe(fds) == -1) { + error (g, _("pipe failed: %m")); return NULL; + } + + int pid = fork_he...

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

This function generalises the existing print_cmdline used to output the qemu command line to output any given command line, and exports it to other modules. It also adds a timestamp to the old print_cmdline output for consistency with guestfs___print_timestamped_message. --- src/guestfs-internal.h | 1 + src/launch.c | 48 ++++++++++++++++++++++++------------------------ 2 files changed, 25 insertions(+), 24 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-New-internal-function-guestfs___print_...

This function generalises the existing print_cmdline used to output the qemu command line to output any given command line, and exports it to other modules. It also adds a timestamp to the old print_cmdline output for consistency with guestfs___print_timestamped_message. --- src/guestfs-internal.h | 1 + src/launch.c | 48 ++++++++++++++++++++++++------------------------ 2 files changed, 25 insertions(+), 24 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-New-internal-function-guestfs___print_...

...ing (see L</HOTPLUGGING>) and sVirt. diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c index 36e3df0..984c5aa 100644 --- a/src/launch-libvirt.c +++ b/src/launch-libvirt.c @@ -216,6 +216,16 @@ launch_libvirt (guestfs_h *g, void *datav, const char *libvirt_uri) if (g->verbose) guestfs___print_timestamped_message (g, "connect to libvirt"); + /* Decode the URI string. */ + if (!libvirt_uri) { /* "libvirt" */ + if (!params.current_proc_is_root) + libvirt_uri = "qemu:///session"; + else + libvirt_uri = "qemu:///system"; + } else if (STREQ...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

As the start of work to add remote support, I'm taking a close look at the protocol layer in the library. These are some small cleanups. Rich.

...find group 'qemu'"); } + /* Store any secrets in libvirtd, keeping a mapping from the secret + * to its UUID. + */ + ITER_DRIVES (g, i, drv) { + if (add_secret (g, data, drv) == -1) + goto cleanup; + } + /* Construct the libvirt XML. */ if (g->verbose) guestfs___print_timestamped_message (g, "create libvirt XML"); @@ -1272,6 +1306,8 @@ construct_libvirt_xml_disk (guestfs_h *g, CLEANUP_FREE char *path = NULL; int is_host_device; CLEANUP_FREE char *format = NULL; + const char *type, *uuid; + int r; /* XXX We probably could support this if we thought about i...

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

Since v1: - Base64 decode the Ceph secret before passing it to libvirt. - Don't call virSecretFree (NULL) [libvirt bug?] - Small cleanups.

Hi, this is a prototype of something I've around for some time. Basically it is about adding new appliances in addition to the main one currently used and kept up-to-date automatically: this way it is possible to create new appliances with extra packages, to be used in specific contexts (like virt-rescue, with more network/recovery tools) without filling the main appliance. It's still

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

This is the libguestfs companion patch to: https://www.redhat.com/archives/libguestfs/2013-September/msg00045.html Rich.

...TRANSFERS Some operations can be cancelled by the caller while they are in diff --git a/src/launch-libvirt.c b/src/launch-libvirt.c index 4f015e3..b7a75d3 100644 --- a/src/launch-libvirt.c +++ b/src/launch-libvirt.c @@ -157,8 +157,7 @@ launch_libvirt (guestfs_h *g, const char *libvirt_uri) guestfs___print_timestamped_message (g, "connect to libvirt"); /* Connect to libvirt, get capabilities. */ - /* XXX Support libvirt authentication in the future. */ - conn = virConnectOpen (libvirt_uri); + conn = guestfs___open_libvirt_connection (g, libvirt_uri, 0); if (!conn) { libvirt_error (g, _("c...

v1 was here: https://www.redhat.com/archives/libguestfs/2013-August/msg00005.html This now works, to some extent. The main problem now is that devices are named /dev/ubd[a-] which of course confuses everything. I'm thinking it may be easier to add a udev rule to rename them. Rich.

This is a User-Mode Linux backend for libguestfs. You can select it by doing: export LIBGUESTFS_BACKEND=uml export LIBGUESTFS_QEMU=/path/to/vmlinux Note we're reusing the 'qemu' variable in the handle for convenience. QEmu is not involved when using the UML backend. This almost works. UML itself crashes when the daemon tries to connect to the serial port. I suspect it's

This rounds off hotplugging support by allowing you to add and remove drives at any stage (before and after launch). Rich.

This is, I guess, version 3 of this patch series which adds disk labels and hotplugging (only hot-add implemented so far). The good news is .. it works! Rich.