search for: guestfs___open_libvirt_connect

...o libguestfs (the C library) call guestfs_add_domain() with a domain name parameter as a literal string, either one fetched from (1) or one you passed on the command line. Libguestfs then looks that up with libvirt to check it exists and to get the list of disks. That happens in src/libvirt-auth.c:guestfs___open_libvirt_connection: https://github.com/libguestfs/libguestfs/blob/master/src/libvirt-auth.c#L192 (3) Finally if you are using the libvirt backend (which you are not on Ubuntu) then there would be a third connection to run the appliance, although it uses the same code as (2). I believe the problem here is that...

...re * the user changes attach-method while reusing the handle to launch @@ -567,4 +577,9 @@ extern int guestfs___read_db_dump (guestfs_h *g, const char *dumpfile, void *opa extern void guestfs___free_fuse (guestfs_h *g); #endif +/* libvirt-auth.c */ +#ifdef HAVE_LIBVIRT +extern virConnectPtr guestfs___open_libvirt_connection (guestfs_h *g, const char *uri, unsigned int flags); +#endif + #endif /* GUESTFS_INTERNAL_H_ */ diff --git a/src/guestfs.pod b/src/guestfs.pod index 151c7ad..7002f46 100644 --- a/src/guestfs.pod +++ b/src/guestfs.pod @@ -2232,6 +2232,16 @@ do not generate this event. If no callback is regist...

Hello, I'm running into an issue using the 'virt-df' command when SASL is enabled in libvirt. I'm running version 1.26.5 of libguestfs on an Ubuntu 14.04 OS. I'm running 'virt-df' for all guests at one time, not specifying a domain or image to use. I was expecting a SASL authentication prompt but to no avail. Below is a sample run: root@all-in-one:~# virt-df -P 15

...d_libvirt_uri : "NULL"); + g->wrapper_warning_done = true; + } + + return virConnectAuthPtrDefault->cb (cred, ncred, + virConnectAuthPtrDefault->cbdata); +} + static int exists_libvirt_auth_event (guestfs_h *g) { @@ -165,31 +194,37 @@ guestfs___open_libvirt_connection (guestfs_h *g, const char *uri, unsigned int flags) { virConnectAuth authdata; - virConnectAuthPtr authdataptr; virConnectPtr conn; + const char *authtype; + + g->saved_libvirt_uri = uri; + g->wrapper_warning_done = false; /* Did the call...

...is_root) + libvirt_uri = "qemu:///session"; + else + libvirt_uri = "qemu:///system"; + } else if (STREQ (libvirt_uri, "null")) { /* libvirt:null */ + libvirt_uri = NULL; + } /* else nothing */ + /* Connect to libvirt, get capabilities. */ conn = guestfs___open_libvirt_connection (g, libvirt_uri, 0); if (!conn) { -- 1.8.3.1

...o libguestfs (the C library) call guestfs_add_domain() with a domain name parameter as a literal string, either one fetched from (1) or one you passed on the command line. Libguestfs then looks that up with libvirt to check it exists and to get the list of disks. That happens in src/libvirt-auth.c:guestfs___open_libvirt_connection: https://github.com/libguestfs/libguestfs/blob/master/src/libvirt-auth.c#L192 (3) Finally if you are using the libvirt backend (which you are not on Ubuntu) then there would be a third connection to run the appliance, although it uses the same code as (2). I believe the problem here is that...

...he C library) call > guestfs_add_domain() with a domain name parameter as a literal string, either one fetched from (1) or one you passed on the command line. > Libguestfs then looks that up with libvirt to check it exists and to get the list of disks. That happens in > src/libvirt-auth.c:guestfs___open_libvirt_connection: > > https://github.com/libguestfs/libguestfs/blob/master/src/libvirt-auth.c#L192 > > (3) Finally if you are using the libvirt backend (which you are not on > Ubuntu) then there would be a third connection to run the appliance, although it uses the same code as (2). > >...

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.