search for: guestfs___free_string_list

...--- a/src/inspect.c +++ b/src/inspect.c @@ -64,7 +64,7 @@ guestfs__inspect_os (guestfs_h *g) size_t i; for (i = 0; devices[i] != NULL; ++i) { - if (guestfs___check_for_filesystem_on (g, devices[i], 1, 0) == -1) { + if (guestfs___check_for_filesystem_on (g, devices[i]) == -1) { guestfs___free_string_list (devices); guestfs___free_inspect_info (g); return NULL; @@ -83,7 +83,7 @@ guestfs__inspect_os (guestfs_h *g) if (parent_device_already_probed (g, partitions[i])) continue; - if (guestfs___check_for_filesystem_on (g, partitions[i], 0, i+1) == -1) { + if (guestfs___...

...aug_get (g, augpath); + if (mp == NULL) { free (spec); - free (mp); - - if (r == -1) goto error; + goto error; } + + int r = add_fstab_entry (g, fs, spec, mp, md_map); + free (spec); + free (mp); + + if (r == -1) goto error; } hash_free (md_map); - guestfs___free_string_list (lines); + guestfs___free_string_list (entries); return 0; error: hash_free (md_map); - if (lines) guestfs___free_string_list (lines); + if (entries) guestfs___free_string_list (entries); + free(augpath); return -1; } -- 1.7.7.3

This adds the mdadm-create API for creating RAID devices, and includes various fixes for the other two patches. Rich.

Only change from previous post is explicitly checking md_map for NULL before hash_free and lookup.

These patches are rebased on top of current master. In addition, I've made the following changes: * Fixed whitespace error. * Functions return -1 on error. * Added a debug message when guest contains md devices, but nothing was parsed from mdadm.conf.

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

This series fixes inspection in the case that fstab contains references to md devices. I've made a few changes since the previous posting, which I've summarised below. [PATCH 1/8] build: Create an MD variant of the dummy Fedora image I've double checked that no timestamp is required in the Makefile. The script will not run a second time to build fedora-md2.img. [PATCH 2/8] build:

--- extratests/suppressions | 20 ++++++++++++++++---- 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/extratests/suppressions b/extratests/suppressions index 97d4b78..78ca4ab 100644 --- a/extratests/suppressions +++ b/extratests/suppressions @@ -3,19 +3,19 @@ Memcheck:Cond fun:* fun:numa_node_size64 - fun:numa_init + obj:/usr/lib64/libnuma.so.1 } {

...bitmask |= GUESTFS_ADD_DRIVE_OPTS_SECRET_BITMASK; + ad_optargs.secret = drv->uri.password; + } r = guestfs_add_drive_opts_argv (g, drv->uri.path, &ad_optargs); if (r == -1) @@ -290,6 +295,7 @@ free_drives (struct drv *drv) free (drv->uri.protocol); guestfs___free_string_list (drv->uri.server); free (drv->uri.username); + free (drv->uri.password); break; case drv_d: /* d.filename is optarg, don't free it */ diff --git a/fish/options.h b/fish/options.h index dbf9163..639b1fe 100644 --- a/fish/options.h +++ b/fish/options.h @@ -68,6 +68,7...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

...ery) { + ad_optargs.bitmask |= GUESTFS_ADD_DRIVE_OPTS_QUERYSTRING_BITMASK; + ad_optargs.querystring = drv->uri.query; + } r = guestfs_add_drive_opts_argv (g, drv->uri.path, &ad_optargs); if (r == -1) @@ -307,6 +312,7 @@ free_drives (struct drv *drv) guestfs___free_string_list (drv->uri.server); free (drv->uri.username); free (drv->uri.password); + free (drv->uri.query); break; case drv_d: /* d.filename is optarg, don't free it */ diff --git a/fish/options.h b/fish/options.h index cf68122..d4b0fa5 100644 --- a/fish/options.h +++...

This patch fixes inspection when fstab contains devices md devices specified as /dev/mdN. The appliance creates these devices without reference to the guest's mdadm.conf so, for e.g. /dev/md0 in the guest will often be created as /dev/md127 in the appliance. With this patch, we match the uuids of detected md devices against uuids specified in mdadm.conf, and map them appropriately when we

Miscellaneous fixes to: - Handling of Ceph drives now works end-to-end (RHBZ#1026688). - In particular, you can now use rbd:/// URIs in guestfish (and they work). - Parse Ceph & NBD network drives from libvirt XML correctly, so that existing domains with Ceph/NBD drives can be added (eg. using guestfish -d option). - Add more testing of the above.

...i, entry->uuid)) { /* Invalid UUID is weird, but not fatal. */ - debug(g, "inspect-os: guestfs_mdadm_detail returned invalid " + debug(g, "inspect-os: guestfs_md_detail returned invalid " "uuid for %s: %s", *md, *i); guestfs___free_string_list(detail); md_uuid_free(entry); -- 1.7.7.3

Tested with 'make check-release'. tests/parallel (in check-slow) failed, although it does regularly and that seems to be because of libvirt. Rich.

...fs->major_version = guestfs___parse_unsigned_int (g, major); + fs->minor_version = guestfs___parse_unsigned_int (g, minor); + free (major); + free (minor); + if (fs->major_version == -1 || fs->minor_version == -1) + goto out; + } + } + + r = 0; + +out: + guestfs___free_string_list (lines); + + return r; +} + /* The currently mounted device is known to be a Linux root. Try to * determine from this the distro, version, etc. Also parse * /etc/fstab to determine the arrangement of mountpoints and @@ -464,13 +558,11 @@ guestfs___check_linux_root (guestfs_h *g, struct insp...

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

Hi everyone, lately I've been getting familiar with library and working on slight re-layering of the library. It's about having locking layer in public API and tracing one layer below that (let's call it __t_ layer. I'm not very good at making up names, so this is temporary:) ). Then making sure that all generated public stuff call __t_ layer and all other internal stuff

Hi, this patch serie adds a new GUID type in the generator, which would do the same as String, but also validating (just in the C output) the passed GUID string. This allows to reject invalid GUIDs before passing them to low-level tools. Pino Toscano (4): utils: add a function to validate a GUID string generator: add a GUID parameter type generator: generate code for parameter validation

..._data; - guestfs_progress_cb progress_cb; - void * progress_cb_data; + + /* Events. */ + struct event *events; + size_t nr_events; int msg_next_serial; @@ -289,6 +295,9 @@ extern int guestfs___feature_available (guestfs_h *g, const char *feature); extern void guestfs___free_string_list (char **); extern int guestfs___checkpoint_cmdline (guestfs_h *g); extern void guestfs___rollback_cmdline (guestfs_h *g, int pos); +extern void guestfs___call_callbacks_void (guestfs_h *g, uint64_t event); +extern void guestfs___call_callbacks_message (guestfs_h *g, uint64_t event, const char *bu...