search for: guestfs___download_to_tmp

...or 2 make libguestfs-1.13.21 leads to: .... CCLD create_disk ../src/.libs/libguestfs.so: undefined reference to `guestfs___case_sensitive_path_silently' ../src/.libs/libguestfs.so: undefined reference to `guestfs___search_for_root' ../src/.libs/libguestfs.so: undefined reference to `guestfs___download_to_tmp' collect2: ld returned 1 exit status make[2]: *** [create_disk] Error 1 make[2]: Leaving directory `/home/koder/tmp/libguestfs-1.13.21/examples' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/koder/tmp/libguestfs-1.13.21' make: *** [all] Error 2 System info: ko...

...(curr->name, ".") || STREQ (curr->name, "..")) + continue; + + free (fname); + fname = safe_malloc (g, strlen (curr->name) + path_len + 1); + sprintf (fname, "/var/lib/pacman/local/%s/desc", curr->name); + free (desc_file); + desc_file = guestfs___download_to_tmp (g, fs, fname, curr->name, 8192); + + /* The desc files are small (4K). If the desc file does not exist, or is + * larger than the 8K limit we've used, the database is probably corrupted, + * but we'll continue with the next package anyway. + */ + if (desc_file == NULL)...

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

...(curr->name, ".") || STREQ (curr->name, "..")) + continue; + + free (fname); + fname = safe_malloc (g, strlen (curr->name) + path_len + 1); + sprintf (fname, "/var/lib/pacman/local/%s/desc", curr->name); + free (desc_file); + desc_file = guestfs___download_to_tmp (g, fs, fname, curr->name, 8192); + + /* The desc files are small (4K). If the desc file does not exist or is + * larger than the 8K limit we've used, the database is probably corrupted, + * but we'll continue with the next package anyway. + */ + if (desc_file == NULL)...

...TREQ (curr->name, "..")) > + continue; > + > + free (fname); > + fname = safe_malloc (g, strlen (curr->name) + path_len + 1); > + sprintf (fname, "/var/lib/pacman/local/%s/desc", curr->name); > + free (desc_file); > + desc_file = guestfs___download_to_tmp (g, fs, fname, curr->name, 8192); > + > + /* The desc files are small (4K). If the desc file does not exist, or is > + * larger than the 8K limit we've used, the database is probably corrupted, > + * but we'll continue with the next package anyway. > + */ &g...

...t a/src/guestfs-internal.h b/src/guestfs-internal.h index 0a4a6f2..0b25407 100644 --- a/src/guestfs-internal.h +++ b/src/guestfs-internal.h @@ -766,6 +766,7 @@ extern int guestfs___set_backend (guestfs_h *g, const char *method); extern void guestfs___free_inspect_info (guestfs_h *g); extern char *guestfs___download_to_tmp (guestfs_h *g, struct inspect_fs *fs, const char *filename, const char *basename, uint64_t max_size); extern struct inspect_fs *guestfs___search_for_root (guestfs_h *g, const char *root); +extern int guestfs___is_partition (guestfs_h *g, const char *partition); /* inspect-fs.c */ extern int gu...

This adds most of the hivex APIs directly to the libguestfs API, so that you can read and write Windows Registry hive files from libguestfs without needing to download and upload hive files from the guest. This is analogous to how Augeas APIs are exposed already (guestfs_aug_*) Also, inspection is now done using the new APIs, which fixes the following bug:

....")) >> + continue; >> + >> + free (fname); >> + fname = safe_malloc (g, strlen (curr->name) + path_len + 1); >> + sprintf (fname, "/var/lib/pacman/local/%s/desc", curr->name); >> + free (desc_file); >> + desc_file = guestfs___download_to_tmp (g, fs, fname, curr->name, 8192); >> + >> + /* The desc files are small (4K). If the desc file does not exist, or is >> + * larger than the 8K limit we've used, the database is probably corrupted, >> + * but we'll continue with the next package anyway....

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.