search for: guestfs___case_sensitive_path_sil

...dex e9f020a..f65c70a 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -418,12 +418,9 @@ list_applications_windows (guestfs_h *g, struct inspect_fs *fs) snprintf (software, len, "%s/system32/config/software", fs->windows_systemroot); - char *software_path = guestfs___case_sensitive_path_silently (g, software); - if (!software_path) { - /* Missing software hive is a problem. */ - error (g, "no HKLM\\SOFTWARE hive found in the guest"); + char *software_path = guestfs_case_sensitive_path (g, software); + if (!software_path) return NULL; - } struct guestfs_ap...

Proposed patches to fix https://bugzilla.redhat.com/show_bug.cgi?id=858126

This change refactors guestfs___has_windows_systemroot to guestfs___get_windows_systemroot. The new function returns a dynamically allocated char * which must be freed. The new function is no less efficient than before, as it returns the result of guestfs___case_sensitive_path_silently, which is required anyway. The new code is slightly more efficient than before, as it re-uses the result of this testing in guestfs___check_windows_root rather than running it again. --- src/guestfs-internal.h | 4 +-- src/inspect-fs-windows.c | 72 +++++++++++++++++++++++------------------...

From: "Richard W.M. Jones" <rjones@redhat.com> Use the macro like this to create temporary variables which are automatically cleaned up when the scope is exited: { CLEANUP_FREE (char *, foo, strdup (bar)); /* char *foo = strdup (bar) */ ... // no need to call free (foo)! } On GCC and LLVM, this is implemented using __attribute__((cleanup(...))). On other

...diff --git a/src/inspect-fs-windows.c b/src/inspect-fs-windows.c index 4eea6a3..c67f164 100644 --- a/src/inspect-fs-windows.c +++ b/src/inspect-fs-windows.c @@ -154,7 +154,7 @@ guestfs___get_windows_systemroot (guestfs_h *g) * systemroot locations */ CLEANUP_FREE char *boot_ini_path = guestfs___case_sensitive_path_silently (g, "/boot.ini"); - if (boot_ini_path) { + if (boot_ini_path && guestfs_is_file (g, boot_ini_path)) { CLEANUP_FREE_STRING_LIST char **boot_ini = guestfs_read_lines (g, boot_ini_path); if (!boot_ini) { -- 1.8.2.1

...ni_os); } static int check_windows_arch (guestfs_h *g, struct inspect_fs *fs); @@ -143,6 +149,86 @@ guestfs___get_windows_systemroot (guestfs_h *g) } } + /* If the fs contains boot.ini, check it for non-standard + * systemroot locations */ + CLEANUP_FREE char *boot_ini_path = + guestfs___case_sensitive_path_silently (g, "/boot.ini"); + if (boot_ini_path) { + CLEANUP_FREE_STRING_LIST char **boot_ini = + guestfs_read_lines (g, boot_ini_path); + if (!boot_ini) { + debug (g, "error reading %s", boot_ini_path); + return NULL; + } + + int found_os = 0; + for (c...

...g directory `/home/koder/tmp/libguestfs-1.12.7/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/koder/tmp/libguestfs-1.12.7' make: *** [all] Error 2 make libguestfs-1.13.21 leads to: .... CCLD create_disk ../src/.libs/libguestfs.so: undefined reference to `guestfs___case_sensitive_path_silently' ../src/.libs/libguestfs.so: undefined reference to `guestfs___search_for_root' ../src/.libs/libguestfs.so: undefined reference to `guestfs___download_to_tmp' collect2: ld returned 1 exit status make[2]: *** [create_disk] Error 1 make[2]: Leaving directory `/home/koder/tmp/libguest...

This patch series changes a small part of the library to use __attribute__((cleanup(...))) to automatically free memory when pointers go out of the current scope. In general terms this seems to be a small win although you do have to use it carefully. For functions where you can completely get rid of the "exit code paths", it can simplify things. For a good example, see the

...ruct inspect_fs *fs); extern int guestfs___check_netbsd_root (guestfs_h *g, struct inspect_fs *fs); extern int guestfs___check_hurd_root (guestfs_h *g, struct inspect_fs *fs); +extern int guestfs___check_minix_root (guestfs_h *g, struct inspect_fs *fs); /* inspect-fs-windows.c */ extern char *guestfs___case_sensitive_path_silently (guestfs_h *g, const char *); diff --git a/src/inspect-apps.c b/src/inspect-apps.c index c199238..a77e9ce 100644 --- a/src/inspect-apps.c +++ b/src/inspect-apps.c @@ -157,6 +157,7 @@ guestfs__inspect_list_applications2 (guestfs_h *g, const char *root) break; case OS_TYPE_FREEBSD:...

Hi everyone, lately I've been getting familiar with library and working on slight re-layering of the library. It's about having locking layer in public API and tracing one layer below that (let's call it __t_ layer. I'm not very good at making up names, so this is temporary:) ). Then making sure that all generated public stuff call __t_ layer and all other internal stuff

This adds most of the hivex APIs directly to the libguestfs API, so that you can read and write Windows Registry hive files from libguestfs without needing to download and upload hive files from the guest. This is analogous to how Augeas APIs are exposed already (guestfs_aug_*) Also, inspection is now done using the new APIs, which fixes the following bug:

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

This preliminary patch series adds a libvirt backend to libguestfs. It's for review only because although it launches the guest OK, there are some missing features that need to be implemented. The meat of the patch is in part 4/4. To save you the trouble of interpreting libxml2 fragments, an example of the generated XML and the corresponding qemu command line are attached below. Note the