search for: guestfs___call_callbacks_message

From: "Richard W.M. Jones" <rjones at redhat.com> --- src/events.c | 25 +++++++++++++++++-------- 1 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/events.c b/src/events.c index f707e0b..9a1ca76 100644 --- a/src/events.c +++ b/src/events.c @@ -120,8 +120,7 @@ guestfs___call_callbacks_message (guestfs_h *g, uint64_t event, event == GUESTFS_EVENT_TRACE) && (g->verbose || event == GUESTFS_EVENT_TRACE)) { int from_appliance = event == GUESTFS_EVENT_APPLIANCE; - size_t i; - char c; + size_t i, i0; /* APPLIANCE => <buf> * LIBRARY...

I've just tried to build the latest from git, and it failed like this: events.c: In function 'guestfs___call_callbacks_message': events.c:128:7: error: implicit declaration of function 'strlen' [-Werror=implicit-function-declaration] events.c:128:39: error: incompatible implicit declaration of built-in function 'strlen' [-Werror] events.c:131:38: error: incompatible implicit declaration of b...

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

These three patches (for discussion only, NOT to be applied) implement a mutex system that lets the user limit the number of libguestfs instances that can be launched per host. There are two uses that I have identified for this: firstly so we can enable parallel-tests (the default in automake >= 1.13) without blowing up the host. Secondly oVirt has raised concerns about how to limit the

...for (i = 0; i < g->nr_events; ++i) + if ((g->events[i].event_bitmask & event) != 0) + g->events[i].cb (g, g->events[i].opaque, event, i, 0, NULL, 0, NULL, 0); + + /* All events with payload type void are discarded if no callback + * was registered. + */ +} + +void +guestfs___call_callbacks_message (guestfs_h *g, uint64_t event, + const char *buf, size_t buf_len) +{ + size_t i, count = 0; + + for (i = 0; i < g->nr_events; ++i) + if ((g->events[i].event_bitmask & event) != 0) { + g->events[i].cb (g, g->events[i].opaque, event, i, 0,...

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

..._h *g = gv; + size_t i; + + if (cred == NULL || ncred == 0) + return 0; + + /* libvirt probably does this already, but no harm in checking. */ + for (i = 0; i < ncred; ++i) + cred[i].result = NULL; + + g->requested_credentials = cred; + g->nr_requested_credentials = ncred; + + guestfs___call_callbacks_message (g, GUESTFS_EVENT_LIBVIRT_AUTH, + g->saved_libvirt_uri, + strlen (g->saved_libvirt_uri)); + + /* libvirt documentation says: "Returns: 0 if all interactions were + * filled, or -1 upon error" However it also sa...

Inspired by libvirt's virCommand* internal mini-library, this adds some internal APIs for running commands. The first patch contains the new APIs. The subsequent patches change various parts of the library over to use it. Rich.

This is, I guess, version 3 of this patch series which adds disk labels and hotplugging (only hot-add implemented so far). The good news is .. it works! Rich.

This rounds off hotplugging support by allowing you to add and remove drives at any stage (before and after launch). Rich.

This version doesn't crash or cause hung processes or stuck mountpoints, so that's an improvement. Rich.

This patch is just for review. It enables FUSE support in the API via two new calls, 'guestfs_mount_local' and 'guestfs_umount_local'. FUSE turns out to be very easy to deadlock (necessitating that the machine be rebooted). Running the test from the third patch is usually an effective way to demonstrate this. However I have not yet managed to produce a simple reproducer that