search for: guestcaps_machin

...;on_reboot>restart</on_reboot> diff --git a/v2v/types.ml b/v2v/types.ml index da1192ec3..a569759c7 100644 --- a/v2v/types.ml +++ b/v2v/types.ml @@ -398,6 +398,7 @@ type guestcaps = { gcaps_virtio_rng : bool; gcaps_virtio_balloon : bool; gcaps_isa_pvpanic : bool; + gcaps_machine : guestcaps_machine; gcaps_arch : string; gcaps_acpi : bool; } @@ -409,6 +410,7 @@ and requested_guestcaps = { and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE and guestcaps_net_type = Virtio_net | E1000 | RTL8139 and guestcaps_video_type = QXL | Cirrus +and guestcaps_machine = I440FX | Q35 | Virt...

...ib/types.ml +++ b/lib/types.ml @@ -400,12 +400,13 @@ type guestcaps = { gcaps_arch_min_version : int; gcaps_virtio_1_0 : bool; } -and guestcaps_block_type = Virtio_blk | IDE +and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE and guestcaps_net_type = Virtio_net | E1000 | RTL8139 and guestcaps_machine = I440FX | Q35 | Virt let string_of_block_type = function | Virtio_blk -> "virtio-blk" + | Virtio_SCSI -> "virtio-scsi" | IDE -> "ide" let string_of_net_type = function | Virtio_net -> "virtio-net" diff --git a/lib/types.mli b/lib/t...

...ib/types.ml +++ b/lib/types.ml @@ -400,12 +400,13 @@ type guestcaps = { gcaps_arch_min_version : int; gcaps_virtio_1_0 : bool; } -and guestcaps_block_type = Virtio_blk | IDE +and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE and guestcaps_net_type = Virtio_net | E1000 | RTL8139 and guestcaps_machine = I440FX | Q35 | Virt let string_of_block_type = function | Virtio_blk -> "virtio-blk" + | Virtio_SCSI -> "virtio-scsi" | IDE -> "ide" let string_of_net_type = function | Virtio_net -> "virtio-net" diff --git a/lib/types.mli b/lib/t...

...400,12 +400,13 @@ type guestcaps = { > gcaps_arch_min_version : int; > gcaps_virtio_1_0 : bool; > } > -and guestcaps_block_type = Virtio_blk | IDE > +and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE > and guestcaps_net_type = Virtio_net | E1000 | RTL8139 > and guestcaps_machine = I440FX | Q35 | Virt > > let string_of_block_type = function > | Virtio_blk -> "virtio-blk" > + | Virtio_SCSI -> "virtio-scsi" > | IDE -> "ide" > let string_of_net_type = function > | Virtio_net -> "virtio-net"...

...;on_reboot>restart</on_reboot> diff --git a/v2v/types.ml b/v2v/types.ml index 3e3f0fc26..900275834 100644 --- a/v2v/types.ml +++ b/v2v/types.ml @@ -411,6 +411,7 @@ type guestcaps = { gcaps_virtio_rng : bool; gcaps_virtio_balloon : bool; gcaps_isa_pvpanic : bool; + gcaps_machine : guestcaps_machine; gcaps_arch : string; gcaps_acpi : bool; } @@ -422,6 +423,7 @@ and requested_guestcaps = { and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE and guestcaps_net_type = Virtio_net | E1000 | RTL8139 and guestcaps_video_type = QXL | Cirrus +and guestcaps_machine = I440FX | Q35 | Virt...

...caps = { >> gcaps_arch_min_version : int; >> gcaps_virtio_1_0 : bool; >> } >> -and guestcaps_block_type = Virtio_blk | IDE >> +and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE >> and guestcaps_net_type = Virtio_net | E1000 | RTL8139 >> and guestcaps_machine = I440FX | Q35 | Virt >> >> let string_of_block_type = function >> | Virtio_blk -> "virtio-blk" >> + | Virtio_SCSI -> "virtio-scsi" >> | IDE -> "ide" >> let string_of_net_type = function >> | Virtio_net...

...diff --git a/v2v/types.ml b/v2v/types.ml > index da1192ec3..a569759c7 100644 > --- a/v2v/types.ml > +++ b/v2v/types.ml > @@ -398,6 +398,7 @@ type guestcaps = { > gcaps_virtio_rng : bool; > gcaps_virtio_balloon : bool; > gcaps_isa_pvpanic : bool; > + gcaps_machine : guestcaps_machine; > gcaps_arch : string; > gcaps_acpi : bool; > } > @@ -409,6 +410,7 @@ and requested_guestcaps = { > and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE > and guestcaps_net_type = Virtio_net | E1000 | RTL8139 > and guestcaps_video_type = QXL | Cirrus > +and...

...ps_arch_min_version : int; >>> gcaps_virtio_1_0 : bool; >>> } >>> -and guestcaps_block_type = Virtio_blk | IDE >>> +and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE >>> and guestcaps_net_type = Virtio_net | E1000 | RTL8139 >>> and guestcaps_machine = I440FX | Q35 | Virt >>> >>> let string_of_block_type = function >>> | Virtio_blk -> "virtio-blk" >>> + | Virtio_SCSI -> "virtio-scsi" >>> | IDE -> "ide" >>> let string_of_net_type = function &...

...ib/types.ml +++ b/lib/types.ml @@ -400,12 +400,13 @@ type guestcaps = { gcaps_arch_min_version : int; gcaps_virtio_1_0 : bool; } -and guestcaps_block_type = Virtio_blk | IDE +and guestcaps_block_type = Virtio_blk | Virtio_SCSI | IDE and guestcaps_net_type = Virtio_net | E1000 | RTL8139 and guestcaps_machine = I440FX | Q35 | Virt let string_of_block_type = function | Virtio_blk -> "virtio-blk" + | Virtio_SCSI -> "virtio-scsi" | IDE -> "ide" let string_of_net_type = function | Virtio_net -> "virtio-net" diff --git a/lib/types.mli b/lib/t...

Version 1 was here: https://listman.redhat.com/archives/libguestfs/2023-February/thread.html#30694 I made a few changes in v2 but overall decided to keep the now unused gcaps_arch_min_version capability. This doesn't preclude removing it in future if we think it's never going to be useful. I changed patch 1 so that to remove the long comment about how the field is used, anticipating the

Since commits b28cd1dc ("Remove requested_guestcaps / rcaps"), f0afc439 ("Remove guestcaps_block_type Virtio_SCSI") support for installing virtio-scsi driver is missing in virt-v2v. AFAIU plans and demands for bringing this feature back have been out there for a while. E.g. I've found a corresponding issue which is still open [1]. The code in b28cd1dc, f0afc439 was

Discussion on v1: https://listman.redhat.com/archives/libguestfs/2023-February/030849.html https://listman.redhat.com/archives/libguestfs/2023-March/030917.html v1 -> v2: * Adapt the patch suggested by Richard, splitting it up into 3: https://listman.redhat.com/archives/libguestfs/2023-March/030975.html Now we have "--block-driver" command line option which regulates the

Discussion on v2: https://listman.redhat.com/archives/libguestfs/2023-March/030987.html v2 -> v3: * Patch 2/6 ("convert_windows: add Inject_virtio_win.Virtio_SCSI as a possible block type"): omit "Inject_virtio_win." prefix in favor of type inference. Add a short commit message body; * Add tests/test-v2v-block-driver.sh testing the new "--block-driver"