search for: guest_idle_poll_func

...in. also I tried to add it into existed pvops, >> but it >> doesn't match. > You are aware that pvops is x86 only? yes, I'm aware.. > I really don't see the big difference in maintainability compared to the > static key / function pointer variant: > > void (*guest_idle_poll_func)(void); > struct static_key guest_idle_poll_key __read_mostly; > > static inline void guest_idle_poll(void) > { > if (static_key_false(&guest_idle_poll_key)) > guest_idle_poll_func(); > } thank you for your sample code :) I agree there is no big difference.. I think w...

...in. also I tried to add it into existed pvops, >> but it >> doesn't match. > You are aware that pvops is x86 only? yes, I'm aware.. > I really don't see the big difference in maintainability compared to the > static key / function pointer variant: > > void (*guest_idle_poll_func)(void); > struct static_key guest_idle_poll_key __read_mostly; > > static inline void guest_idle_poll(void) > { > if (static_key_false(&guest_idle_poll_key)) > guest_idle_poll_func(); > } thank you for your sample code :) I agree there is no big difference.. I think w...

...w pvops makes > code > clean and easy to maintain. also I tried to add it into existed pvops, > but it > doesn't match. You are aware that pvops is x86 only? I really don't see the big difference in maintainability compared to the static key / function pointer variant: void (*guest_idle_poll_func)(void); struct static_key guest_idle_poll_key __read_mostly; static inline void guest_idle_poll(void) { if (static_key_false(&guest_idle_poll_key)) guest_idle_poll_func(); } And KVM would just need to set guest_idle_poll_func and enable the static key. Works on non-x86 architectures, too....

...gt;>>> doesn't match. >>> You are aware that pvops is x86 only? >> yes, I'm aware.. >> >>> I really don't see the big difference in maintainability compared to the >>> static key / function pointer variant: >>> >>> void (*guest_idle_poll_func)(void); >>> struct static_key guest_idle_poll_key __read_mostly; >>> >>> static inline void guest_idle_poll(void) >>> { >>> ????if (static_key_false(&guest_idle_poll_key)) >>> ??????? guest_idle_poll_func(); >>> } >> >&gt...

...gt;>>> doesn't match. >>> You are aware that pvops is x86 only? >> yes, I'm aware.. >> >>> I really don't see the big difference in maintainability compared to the >>> static key / function pointer variant: >>> >>> void (*guest_idle_poll_func)(void); >>> struct static_key guest_idle_poll_key __read_mostly; >>> >>> static inline void guest_idle_poll(void) >>> { >>> ????if (static_key_false(&guest_idle_poll_key)) >>> ??????? guest_idle_poll_func(); >>> } >> >&gt...

...ps, >>> but it >>> doesn't match. >> You are aware that pvops is x86 only? > > yes, I'm aware.. > >> I really don't see the big difference in maintainability compared to the >> static key / function pointer variant: >> >> void (*guest_idle_poll_func)(void); >> struct static_key guest_idle_poll_key __read_mostly; >> >> static inline void guest_idle_poll(void) >> { >> ????if (static_key_false(&guest_idle_poll_key)) >> ??????? guest_idle_poll_func(); >> } > > > > thank you for your samp...

On 2017/11/13 18:53, Juergen Gross wrote: > On 13/11/17 11:06, Quan Xu wrote: >> From: Quan Xu <quan.xu0 at gmail.com> >> >> So far, pv_idle_ops.poll is the only ops for pv_idle. .poll is called >> in idle path which will poll for a while before we enter the real idle >> state. >> >> In virtualization, idle path includes several heavy operations

On 2017/11/13 18:53, Juergen Gross wrote: > On 13/11/17 11:06, Quan Xu wrote: >> From: Quan Xu <quan.xu0 at gmail.com> >> >> So far, pv_idle_ops.poll is the only ops for pv_idle. .poll is called >> in idle path which will poll for a while before we enter the real idle >> state. >> >> In virtualization, idle path includes several heavy operations

...t;> You are aware that pvops is x86 only? >>> yes, I'm aware.. >>> >>>> I really don't see the big difference in maintainability compared to >>>> the >>>> static key / function pointer variant: >>>> >>>> void (*guest_idle_poll_func)(void); >>>> struct static_key guest_idle_poll_key __read_mostly; >>>> >>>> static inline void guest_idle_poll(void) >>>> { >>>> ?????if (static_key_false(&guest_idle_poll_key)) >>>> ???????? guest_idle_poll_func(); >&gt...