search for: guess_dcpath

.../v2v/vCenter.ml +++ b/v2v/vCenter.ml @@ -113,7 +113,7 @@ let get_session_cookie password scheme uri sslverify url = Some !session_cookie ) -let multiple_slash = Str.regexp "/+" +let multiple_slash = PCRE.compile "/+" let default_dc = "ha-datacenter" let guess_dcPath uri = function @@ -136,7 +136,7 @@ let guess_dcPath uri = function * remove the Cluster name (which still works in libvirt). *) (* Collapse multiple slashes to single slash. *) - let path = Str.global_replace multiple_slash "/" path in + let...

See earlier thread on libvir-list: https://www.redhat.com/archives/libvir-list/2015-September/thread.html#00201 Libvirt >= 1.2.20 supplies the correct dcPath parameter. If it is available in the libvirt XML, use it, otherwise fall back to the old method of trying to guess it from the vpx:// path. Patches 1, 2 and 4 are just refactoring around this change. Rich.

..., (None|Some _) -> - debug "vcenter: using --dcpath from the command line: %s" p; - p - | None, Some p -> - debug "vcenter: using <vmware:datacenterpath> from libvirt: %s" p; - p - | None, None -> - let p = VCenter.guess_dcPath parsed_uri scheme in - debug "vcenter: guessed dcPath from URI: %s" p; - p + match xpath_string xpathctx "/domain/vmware:datacenterpath" with + | Some dcPath -> dcPath + | None -> + error (f_"vcenter: <vmware:datacenterpath&gt...

The first commit removes the --dcpath parameter, which just makes the following stuff simpler. Since libvirt has supported getting datacenterpath from VMware since Oct 2015, it's time to drop this hairy parameter. The rest is quite a complicated series of refactorings, followed by a very simple change to add handling of snapshots taken from old virt-v2v. Rich.

v1 was here: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html This is a more complete evolution of the earlier patch. It replaces most important uses of Str with PCRE throughout the code. It also extends the bindings with some useful features like case-insensitive regexps. The main places I *didn't* touch are the generator (GObject uses Str extensively); and

v1: https://www.redhat.com/archives/libguestfs/2017-September/msg00135.html v2: https://www.redhat.com/archives/libguestfs/2017-September/msg00158.html v3 is almost identical to v2, but I have added 4 extra commits to almost finish the job of replacing Str everywhere possible (note it's not possible to replace Str in common/mlstdutils or the generator because those are pure OCaml). As

It turns out that RHEL 5 Xen conversions don't work if the source disk is located on a block device. See patch 1/4 for the gory details. This patch series proposes a new tool called virt-v2v-copy-to-local which essentially is a way to make new virt-v2v work like the old virt-v2v, ie. copy first, convert after. Of course this is very slow and would only be used as a last resort, but I

...e, Some p -> - if verbose () then - printf "vcenter: using <vmware:datacenterpath> from libvirt: %s\n" p; + debug "vcenter: using <vmware:datacenterpath> from libvirt: %s" p; p | None, None -> let p = VCenter.guess_dcPath parsed_uri scheme in - if verbose () then - printf "vcenter: guessed dcPath from URI: %s\n" p; + debug "vcenter: guessed dcPath from URI: %s" p; p ); @@ -135,7 +131,7 @@ object let cmd = sprintf "qemu-img rebase -u...

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.