search for: gtk_check_version

...iles changed, 25 insertions(+), 4 deletions(-) diff --git a/p2v/gui-gtk3-compat.h b/p2v/gui-gtk3-compat.h index 8f32eadbf..04923535e 100644 --- a/p2v/gui-gtk3-compat.h +++ b/p2v/gui-gtk3-compat.h @@ -17,6 +17,18 @@ */ /* Backwards compatibility for some deprecated functions in Gtk 3. */ +#if !GTK_CHECK_VERSION(3,2,0) /* gtk < 3.2 */ +static gboolean +gdk_event_get_button (const GdkEvent *event, guint *button) +{ + if (event->type != GDK_BUTTON_PRESS) + return FALSE; + + *button = ((const GdkEventButton *) event)->button; + return TRUE; +} +#endif + #if GTK_CHECK_VERSION(3,2,0) /* gtk...

It is used only for the about dialog, and this way it will be easier to disable. --- p2v/Makefile.am | 1 - p2v/about-license.c | 38 -------------------------------------- p2v/gui.c | 16 ++++++++++++++++ p2v/p2v.h | 3 --- 4 files changed, 16 insertions(+), 42 deletions(-) delete mode 100644 p2v/about-license.c diff --git a/p2v/Makefile.am b/p2v/Makefile.am index

...ui.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/p2v/gui.c b/p2v/gui.c index 563e1a7..203ca2c 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -134,6 +134,7 @@ static GtkWidget *run_dlg, /* Colour tags used in the v2v_output GtkTextBuffer. */ static GtkTextTag *v2v_output_tags[16]; +#if !GTK_CHECK_VERSION(3,0,0) /* gtk < 3 */ /* The license of virt-p2v, for the About dialog. */ static const char gplv2plus[] = "This program is free software; you can redistribute it and/or modify\n" @@ -149,6 +150,7 @@ static const char gplv2plus[] = "You should have received a copy of the...

...u-nbd curl diff --git a/p2v/gui.c b/p2v/gui.c index 633d3a3..147cadd 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -80,6 +80,104 @@ #define MAX_SUPPORTED_VCPUS 160 #define MAX_SUPPORTED_MEMORY_MB (UINT64_C (4000 * 1024)) +/* Backwards compatibility for some deprecated functions in Gtk 3. */ +#if GTK_CHECK_VERSION(3,2,0) /* gtk >= 3.2 */ +#define hbox_new(box, homogeneous, spacing) \ + do { \ + (box) = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, spacing); \ + if (homogeneous) \ +...

This version of the Gtk 2/3 patch gets alignment and padding mostly right. I still can't work out how to vertically align labels in the middle of a cell in a GtkGrid. The GtkTextView in the final dialog is still broken. Rich.

... and a small initial patch which makes it easier to test virt-p2v without having to start up a virtual machine. There is still a bug in Gtk 3 where the GtkTextView on the final (running) dialog ignores gtk_widget_set_size_request and so the window appears just a single pixel high. Rich.

This is basically the same as what I posted earlier today. The main difference is I split out the GDK thread sychronization (removal of) changes from the other Gtk 2/3 changes, which should make it a bit easier to review. Gtk 3 is still not quite perfect. Apart from the problem with the GtkTextView noted before, there are also vertical alignment and padding problems with labels in GtkGrid

This series for virt-p2v removes the usage of GTK deprecated stuff, and checks for a required Perl module used during build. Tested on: - RHEL 6 (GTK 2) - RHEL 7 (GTK 3) - Fedora 30 (GTK 2 & 3) - Fedora Rawhide/32 (GTK 2 & 3) Pino Toscano (3): Copy GtkAttachOptions from GTK >= 3.4 build: disable deprecated GTK stuff build: require List::MoreUtils Makefile.am | 1 +

On my lab systems, the automatic updates were failing because of the problems with ipod libraries from EPEL being in the way. It turns out that was a good thing, because when I "fixed" it, a massive set of packages was updated, including the new gtk3. These packages are the ones causing problems, I think. gtk3-3.22.10-4.el7.x86_64 gtk3-devel-3.22.10-4.el7.x86_64 In the release notes,

As preliminary steps in splitting virt-p2v to an own repository, continue making p2v more independent within libguestfs. This is accomplished by the following changes: - have only the authors in the about dialog, and read them from a local AUTHORS file - few more cleanups This is still not complete, although I believe most of the work needed is done, and it still makes p2v usable within

This small series for p2v refactors the Reboot menu of the conversion dialog into something slightly more general, and add the possibility to shut the machine down. Lots of work to deal with old GTK versions ... Changes from v1: - fix shutdown command Pino Toscano (2): p2v: turn Reboot button into a Shutdown popup menu button p2v: add a Shutdown action (RHBZ#1642044) p2v/gui.c |

This small series for p2v refactors the Reboot menu of the conversion dialog into something slightly more general, and add the possibility to shut the machine down. Lots of work to deal with old GTK versions ... Pino Toscano (2): p2v: turn Reboot button into a Shutdown popup menu button p2v: add a Shutdown action (RHBZ#1642044) p2v/gui.c | 119

Now that virt-p2v has its own repository [1] and releases [2], it is time to remove it from libguestfs. [1] https://github.com/libguestfs/virt-p2v [2] http://download.libguestfs.org/virt-p2v/ Pino Toscano (2): Remove virt-p2v Remove remaining virt-p2v bits .gitignore | 4 - Makefile.am | 7 +- bash/Makefile.am