search for: gsp_log

...is not needed for normal GSP-RM operation, it is only created if debugfs is available. Otherwise, the NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT RPCs are ignored. Signed-off-by: Timur Tabi <ttabi at nvidia.com<mailto:ttabi at nvidia.com>> --- v5: rebased to drm-misc-next repaced nvkm_gsp_log with nvif_log minor rearrangement of some code drivers/gpu/drm/nouveau/include/nvif/log.h | 32 ++ .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 13 + drivers/gpu/drm/nouveau/nouveau_drm.c | 19 + .../gpu/drm/nouveau/nvkm/subdev/gsp/r535.c | 360 +++++++++++++++++- 4 file...

...> > struct nvif_log _log = { LIST_HEAD_INIT(_log.entry), nvif_log_shutdown } > > > > and change the signature of nvif_log_shutdown() to > > > > static inline void nvif_log_shutdown(struct nvif_log *logs) > > > > you can just call > > > > gsp_logs.shutdown(&gsp_logs); > > > > in nouveau_drm_exit(). > > > > Admittedly, maybe a bit too sneaky though. :) > > gsp_logs.shutdown(&gsp_logs) -- are you sure you want this? ?This is some > weird C++ wanna-be code, IMHO. ?I don't think this is an improve...

On Wed, 2024-07-31 at 16:54 +0200, Danilo Krummrich wrote: > > > > gsp_logs.shutdown(&gsp_logs) -- are you sure you want this? ?This is some > > weird C++ wanna-be code, IMHO. ?I don't think this is an improvement. I'd > > rather keep it as-is. > > That's why I wrote "maybe a bit too sneaky". :) > > I think what I asked...

...gt; > #define NVIF_LOGS_DECLARE(_log) \ > struct nvif_log _log = { LIST_HEAD_INIT(_log.entry), nvif_log_shutdown } > > and change the signature of nvif_log_shutdown() to > > static inline void nvif_log_shutdown(struct nvif_log *logs) > > you can just call > > gsp_logs.shutdown(&gsp_logs); > > in nouveau_drm_exit(). > > Admittedly, maybe a bit too sneaky though. :) gsp_logs.shutdown(&gsp_logs) -- are you sure you want this? ?This is some weird C++ wanna-be code, IMHO. ?I don't think this is an improvement. I'd rather keep it as-is...

...LIST_HEAD_INIT(_log.entry) } If you declare this as #define NVIF_LOGS_DECLARE(_log) \ struct nvif_log _log = { LIST_HEAD_INIT(_log.entry), nvif_log_shutdown } and change the signature of nvif_log_shutdown() to static inline void nvif_log_shutdown(struct nvif_log *logs) you can just call gsp_logs.shutdown(&gsp_logs); in nouveau_drm_exit(). Admittedly, maybe a bit too sneaky though. :) > + > +static inline void nvif_log_shutdown(struct list_head *logs) > +{ > + if (!list_empty(logs)) { > + struct nvif_log *log, *n; > + > + list_for_each_entry_safe(log, n, logs,...

...tatic inline void nvif_log_shutdown(struct list_head *logs) +{ + if (!list_empty(logs)) { + struct nvif_log *log, *n; + + list_for_each_entry_safe(log, n, logs, entry) { + /* shutdown() should also delete the log entry */ + log->shutdown(log); + } + } +} + +#ifdef CONFIG_DEBUG_FS +/** + * gsp_logs - list of nvif_log GSP-RM logging buffers + * + * Head pointer to a a list of nvif_log buffers that is created for each GPU + * upon GSP shutdown if the "keep_gsp_logging" command-line parameter is + * specified. This is used to track the alternative debugfs entries for the + * GSP-RM lo...

Store the struct device pointer used to allocate the DMA buffer in the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release the buffer without needing the nvkm_gsp. This is needed so that we can retain DMA buffers even after the nvkm_gsp object is deleted. Signed-off-by: Timur Tabi <ttabi at nvidia.com> --- v2: rebased to drm-misc-next

Store the struct device pointer used to allocate the DMA buffer in the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release the buffer without needing the nvkm_gsp. This is needed so that we can retain DMA buffers even after the nvkm_gsp object is deleted. Signed-off-by: Timur Tabi <ttabi at nvidia.com> --- Notes: v2: added get/put_device calls

...PU_MSG_EVENT_UCODE_LIBOS_PRINT RPCs are ignored. A simple way to test the buffer migration feature is to have nvkm_gsp_init() return an error code. Signed-off-by: Timur Tabi <ttabi at nvidia.com> --- v9: - rebased to drm-misc-next - move nvkm_gsp logging dentries into debugfs struct - add gsp_logging_debugfs_root and always create the root dentry - remove root struct in r535.c, along with mutex code - rename dir to dent - add missing calls to create_debugfs helper - r535_gsp_copy_log was not calling i_size_write drivers/gpu/drm/nouveau/include/nvif/log.h | 53 +++ .../gpu/drm/nouveau/...

Store the struct device pointer used to allocate the DMA buffer in the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release the buffer without needing the nvkm_gsp. This is needed so that we can retain DMA buffers even after the nvkm_gsp object is deleted. Signed-off-by: Timur Tabi <ttabi at nvidia.com> v2: added get/put_device calls ---

Store the struct device pointer used to allocate the DMA buffer in the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release the buffer without needing the nvkm_gsp. This is needed so that we can retain DMA buffers even after the nvkm_gsp object is deleted. Signed-off-by: Timur Tabi <ttabi at nvidia.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 1 +

...gs->head)) { > + struct nvif_log *log, *n; > + > + list_for_each_entry_safe(log, n, &logs->head, entry) { > + /* shutdown() should also delete the log entry */ > + log->shutdown(log); > + } > + } > +} > + > +#ifdef CONFIG_DEBUG_FS > +/** > + * gsp_logs - list of nvif_log GSP-RM logging buffers > + * > + * Head pointer to a a list of nvif_log buffers that is created for each GPU > + * upon GSP shutdown if the "keep_gsp_logging" command-line parameter is > + * specified. This is used to track the alternative debugfs entries f...

Store the struct device pointer used to allocate the DMA buffer in the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release the buffer without needing the nvkm_gsp. This is needed so that we can retain DMA buffers even after the nvkm_gsp object is deleted. Signed-off-by: Timur Tabi <ttabi at nvidia.com> --- .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 1 +