search for: grace_alarm_handler

...icbowman at comcast dot net *** sshconnect.c 2004-01-27 02:21:27.000000000 -0800 --- sshconnect-new.c 2004-03-26 14:48:24.000000000 -0800 *************** *** 429,434 **** --- 429,444 ---- } /* + * Signal handler for the alarm after the login grace period has expired. + */ + static void + grace_alarm_handler(int sig) + { + /* Log error and exit. */ + fatal("Timeout before authentication"); } + + /* * Waits for the server identification string, and sends our own * identification string. */ *************** *** 441,446 **** --- 451,462 ---- int connection_out = packet_get_connecti...

These days, sshd.c has: static void grace_alarm_handler(int sig) { ... if (getpgid(0) == getpid()) { signal(SIGTERM, SIG_IGN); killpg(0, SIGTERM); } sigdie(...); } however (really) old BSDs do not have getpgid(). They do have getpgrp(), which does what we want here. The question is what to do if...

...ed out by compiler (can't judge if the optimization is correct). The solution is again white-list this syscall or optimize out this condition as the compiler does it. I'm not sure if the condition has some use here. Backtrace from GDB (line numbers differ a bit from upstream sources): #0 grace_alarm_handler (sig=14) at ../openssh-6.8p1/sshd.c:380 #1 <signal handler called> #2 0xb7fd9be8 in ?? () #3 0x080baaef in ssh_dispatch_run (ssh=0x8153780, mode=0, done=0x8151660, ctxt=0x8151660) at ../openssh-6.8p1/dispatch.c:101 #4 0x080bac86 in ssh_dispatch_run_fatal (ssh=0x8153780, mode=0, done=0...

...at /tmp/OpenSSH.roots/OpenSSH/openssh/session.c:2273 #4 0x00007044 in cleanup_exit (i=255) at /tmp/OpenSSH.roots/OpenSSH/openssh/sshd.c:1923 #5 0x00035bb0 in fatal (fmt=0x547d0 "Timeout before authentication for %s") at /tmp/OpenSSH.roots/OpenSSH/openssh/fatal.c:40 #6 0x00002d40 in grace_alarm_handler (sig=14) at /tmp/OpenSSH.roots/OpenSSH/openssh/sshd.c:320 #7 <signal handler called> #8 0x90013bc8 in read () #9 0x0002b5ec in atomicio (f=0x90013bc0 <read>, fd=6, _s=0xbfffef60, n=4) at /tmp/OpenSSH.roots/OpenSSH/openssh/atomicio.c:45 #10 0x00020744 in mm_request_receive (socket=6...

...MAXHOSTNAMELEN; int *startup_pipes = NULL; int startup_pipe; /* in child */ +#ifdef USE_PRIVSEP /* variables used for privilege separation */ int use_privsep; struct monitor *pmonitor = NULL; +#endif /* global authentication context */ Authctxt *the_authctxt = NULL; @@ -308,9 +310,10 @@ grace_alarm_handler(int sig) { /* XXX no idea how fix this signal handler */ +#ifdef USE_PRIVSEP if (use_privsep && pmonitor != NULL && pmonitor->m_pid > 0) kill(pmonitor->m_pid, SIGALRM); - +#endif /* Log error and exit. */ fatal("Timeout before authentication for %s",...

...82 in __lll_lock_wait_private () at ../sysdeps/unix/sysv/linux/i386/lowlevellock.S:65 #2 0xf7a2f394 in openlog (ident=0x5812c1a0 "sshd", logstat=1, logfac=32) at ../misc/syslog.c:384 #3 0x565e99ac in do_log () #4 0x565e9cf4 in sshlogv () #5 0x565e9b29 in sshsigdie () #6 0x56585084 in grace_alarm_handler () #7 <signal handler called> #8 __kernel_vsyscall () at arch/x86/entry/vdso/vdso32/system_call.S:72 #9 0xf7a336b1 in __libc_send (fd=5, buf=0x581644e0, len=153, flags=16384) at ../sysdeps/unix/sysv/linux/send.c:30 #10 0xf7a2f08c in _GI__vsyslog_chk (pri=<optimized out>, flag=<opt...

In sshconnect.c there are two global variables for server_version_string client_version_string. These are used just in a few functions and can easily be passed as parameters. Also, there is a strange construct, where their memory is allocated to the global pointers, then copies of these pointers are assigned to the kex structure. The kex_free finally frees them via cleanup of the kex

Hi, It's that time again... OpenSSH 6.2 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. This release contains some substantial new features and a number of bugfixes. Snapshot releases for portable OpenSSH are available from http://www.mindrot.org/openssh_snap/ The OpenBSD version is available in CVS HEAD: