search for: gpio

Trello: https://trello.com/c/admzDRvd/50-reduce-performance-refuse-to-boot-if-not-all-the-power-connectors-are-plugged Fixed commit messages. Mark Menzynski (4): bios/gpio: sort gpios by values gpio: fail if gpu external power is missing gpio: check the gpio function 16 in the power check as well gpio: check function 76 in the power check as well drm/nouveau/include/nvkm/subdev/bios/gpio.h | 5 ++++- drm/nouveau/nvkm/subdev/gpio/base.c | 25 +++++++++...

Added config override for power checks. Mark Menzynski (4): bios/gpio: sort gpios by values gpio: fail if gpu external power is missing gpio: check the gpio function 16 in the power check as well gpio: check function 76 in the power check as well drm/nouveau/include/nvkm/subdev/bios/gpio.h | 5 +++- drm/nouveau/nvkm/subdev/gpio/base.c | 32 ++++++++++...

trello card: https://trello.com/c/admzDRvd/50-reduce-performance-refuse-to-boot-if-not-all-the-power-connectors-are-plugged Mark Menzynski (4): moved gpio so it is sorted by values gpio: checking if gpu power cable is connected gpio: added power check for another GPIO gpio: added power check for another GPIO drm/nouveau/include/nvkm/subdev/bios/gpio.h | 5 ++++- drm/nouveau/nvkm/subdev/gpio/base.c | 25 +++++++++++++++++++++ 2 files...

...ith workarounds while the issue is being worked out. On Mon, Jul 15, 2019 at 5:43 AM Mark Menzynski <mmenzyns at redhat.com> wrote: > > Currently, nouveau doesn't check if GPU is missing power. This > patch makes nouveau fail when this happens on latest GPUs. > > It checks GPIO function 121 (External Power Emergency), which > should detect power problems on GPU initialization. > > Tested on TU104, GP106 and GF100. > > Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> > --- > drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + > drm/nouv...

...interrupt lines, while nv94 and later has 32. Accessing 0xe0c{0,4} registers on nv92 can lead to incorrect PDISP setup. This is a regression introduced with commit 9d0f5ec9ee0fd5dc5fc1cc2cf559286431e406e3 Author: Ben Skeggs <bskeggs at redhat.com> Date: Mon May 12 15:22:42 2014 +1000 gpio: split g92 class from nv50 Reported-by: estece on #nouveau Cc: stable at vger.kernel.org # 3.16+ Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com> --- nvkm/engine/device/nv50.c | 22 ++++++------- nvkm/engine/device/nvc0.c | 14 ++++----- nvkm/subdev/gpio/Makefile.am | 2 +-...

...64 u32 mask = (1ULL << lines) - 1; // ffffffff everywhere Signed-off-by: Adam Borowski <kilobyte at angband.pl> --- To be honest, I can't tell the difference other than UBSAN stopping its complaints, but the current code is obviously wrong. drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c index 77c649723ad7..4a57defc99b3 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gpio/base.c +++ b/drivers/gpu/drm/nouveau/nv...

Currently, nouveau doesn't check if GPU is missing power. This patch makes nouveau fail when this happens on latest GPUs. It checks GPIO function 121 (External Power Emergency), which should detect power problems on GPU initialization. Tested on TU104, GP106 and GF100. Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nvkm/subdev/gpio/base.c |...

...est pstate? Ben. > > On Mon, Jul 15, 2019 at 5:43 AM Mark Menzynski <mmenzyns at redhat.com> wrote: > > > > Currently, nouveau doesn't check if GPU is missing power. This > > patch makes nouveau fail when this happens on latest GPUs. > > > > It checks GPIO function 121 (External Power Emergency), which > > should detect power problems on GPU initialization. > > > > Tested on TU104, GP106 and GF100. > > > > Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> > > --- > > drm/nouveau/include/nvkm/subde...

Tested on TU104, GP106 and GF100 Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nvkm/subdev/gpio/base.c | 23 +++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h index 2f40935f..a70ec9e8 100644 --- a/drm/nouveau/include/nvkm/subdev/bios/gpio...

this one is mainly used on Rankine and Curie and rarely on Tesla GPUs untested, wrote according to documentation Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 1 + drm/nouveau/nvkm/subdev/gpio/base.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h index a70ec9e8..fc2b5fb0 100644 --- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h +++ b/drm/nouveau/in...

Great, thanks! Also just for context, this sounded reminiscent of one of the first NUT drivers, `genericups` (for simple contact-closure support, with IIRC serial-port connections rather than GPIO). Nearby there's also a `generic_modbus" name. Wondering if the new driver should be (similar to) `generic_gpio`. @Community verdict: Then there was also an effort some years ago to name drivers with a `nutdrv-*` prefix... WDYT? As usual, naming is among the hardest problems in IT ;) J...

Hi! I have CyberPower CyberShield CSN27U12V UPS. This device don't have usual for UPS interface, just open collector pins. I connected these pins to GPIO interface on Orange Pi Zero and wrote NUT driver for this case. Any interest from NUT community to add this driver to regular build tree? See driver code in attachment. Code is fully functional, needs cleanup to match coding guidelines and needs more tests for rules processing part. Driver rea...

Jim Klimov via Nut-upsdev <nut-upsdev at alioth-lists.debian.net> writes: > Nearby there's also a `generic_modbus" name. Wondering if the new driver > should be (similar to) `generic_gpio`. sound good. It would be nice if there were an abstraction layer for various GPIO access methods, rather than hard-coding linux, even if there is only one implementation of the abstraction. I'm not that clear on GPIO, but I gather there are differences. Or maybe there is already a portable...

...t; Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com> Cc: dri-devel at lists.freedesktop.org Cc: Ben Skeggs <bskeggs at redhat.com> --- Considering that no-one has reported this issue before, I'm rather curious if we should CC stable --- drivers/gpu/drm/nouveau/core/subdev/gpio/nv50.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/gpio/nv50.c b/drivers/gpu/drm/nouveau/core/subdev/gpio/nv50.c index bf489dc..c4c1d41 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/gpio/nv50.c +++ b/drivers/gpu/drm/nouveau/c...

...t into 2 files, may to go for library? On 2/22/23 20:17, Greg Troxel wrote: > Jim Klimov via Nut-upsdev <nut-upsdev at alioth-lists.debian.net> writes: > >> Nearby there's also a `generic_modbus" name. Wondering if the new driver >> should be (similar to) `generic_gpio`. > sound good. > > It would be nice if there were an abstraction layer for various GPIO > access methods, rather than hard-coding linux, even if there is only one > implementation of the abstraction. I'm not that clear on GPIO, but I > gather there are differences. Or maybe...

Signed-off-by: Mark Menzynski <mmenzyns at redhat.com> --- drm/nouveau/include/nvkm/subdev/bios/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h index b71a3555..2f40935f 100644 --- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h +++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h @@ -3,9...

Otherwise my card (nv92) never resumes from suspend to ram, hanging on nv_mask in nv50_gpio_drive. Before rework, initialization was done only from POST, so this patch restores previous behaviour. Signed-off-by: Marcin Slusarz <marcin.slusarz at gmail.com> --- Let me tell you little story about this patch... It took me ~week to figure it out. 1) I bisected it to "drm/nouveau...

...r library? > > On 2/22/23 20:17, Greg Troxel wrote: > > Jim Klimov via Nut-upsdev <nut-upsdev at alioth-lists.debian.net> writes: > > > >> Nearby there's also a `generic_modbus" name. Wondering if the new driver > >> should be (similar to) `generic_gpio`. > > sound good. > > > > It would be nice if there were an abstraction layer for various GPIO > > access methods, rather than hard-coding linux, even if there is only one > > implementation of the abstraction. I'm not that clear on GPIO, but I > > gather th...

...struct nvkm_iccsense *iccsense, u8 idx); #endif diff --git a/drm/nouveau/nvkm/engine/device/base.c b/drm/nouveau/nvkm/engine/device/base.c index a239e49..2536890 100644 --- a/drm/nouveau/nvkm/engine/device/base.c +++ b/drm/nouveau/nvkm/engine/device/base.c @@ -1347,6 +1347,7 @@ nvc0_chipset = { .gpio = g94_gpio_new, .i2c = g94_i2c_new, .ibus = gf100_ibus_new, + .iccsense = gf100_iccsense_new, .imem = nv50_instmem_new, .ltc = gf100_ltc_new, .mc = gf100_mc_new, @@ -1383,6 +1384,7 @@ nvc1_chipset = { .gpio = g94_gpio_new, .i2c = g94_i2c_new, .ibus = gf100_ibus_new, + .iccsense = gf...

.../nouveau/nvkm/subdev/fb/sddr2.c:60:1: warning: no previous prototype for 'nvkm_sddr2_calc' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c:69:1: warning: no previous prototype for 'nvkm_sddr3_calc' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:35:1: warning: no previous prototype for 'nvkm_voltgpio_get' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:54:1: warning: no previous prototype for 'nvkm_voltgpio_set' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c:71:1: warning: no...