search for: googletestframework

Hi Kees, You added some support for Minix to LLVM's copy of googletest: http://llvm.org/viewvc/llvm-project?view=rev&revision=100895 Is it still being used? If so, would you mind pushing these patches upstream to the googletest project: http://code.google.com/p/googletest/ Otherwise we may drop them, because it makes it harder to import new releases of googletest into the LLVM

On 27 July 2011 11:20, dr. ir. Kees van Reeuwijk <reeuwijk at few.vu.nl> wrote: > At the time I submitted  those patches I also submitted them to googletest. As far as I know they got accepted, although I didn't verify that. OK, I see from this thread: http://groups.google.com/group/googletestframework/browse_thread/thread/3081a14965764366/332ce9869f4bbe31 ... that rather than add explicit support for Minix, they suggested that you build with CPPFLAGS="-DGTEST_HAS_POSIX_REGEX=1 -DGTEST_HAS_STD_WSTRING=0". I'm not sure what (if anything) we have to do in LLVM to support that. Jay.