search for: googletest

I'm seeing some test failures for unit tests for msan (check-msan) happening in googletest, which I find weird. I'm on Arch Linux, with r342711. Below is one type of error that I see. The full log is 416MB (!) big. My guess is that those errors are related, but if anyone needs the full log, I'll provide it. Here is a reduced log from the end: https://drive.google.com/file/d/1R5bL...

...t, specifically the "Combine" feature for use in combinatorially generating parameterised tests. A FIXME comment in ProfileData\CoverageMappingTest.cpp suggests that I'm not the only one to have tried and discovered that they cannot use this feature. The problem is that the version of googletest (v 1.8.0, released in Aug 2016) in the LLVM tree requires TR1 tuple support for this feature, which is not really supported in recent compilers, and has been explicitly disabled in our googletest CMakeLists.txt, thus disabling "Combine". I did a bit of looking around, and v 1.8.0 is inde...

...> "Combine" feature for use in combinatorially generating parameterised > tests. A FIXME comment in ProfileData\CoverageMappingTest.cpp suggests that > I'm not the only one to have tried and discovered that they cannot use this > feature. The problem is that the version of googletest (v 1.8.0, released > in Aug 2016) in the LLVM tree requires TR1 tuple support for this feature, > which is not really supported in recent compilers, and has been explicitly > disabled in our googletest CMakeLists.txt, thus disabling "Combine". > > I did a bit of looking aro...

Hi Kees, You added some support for Minix to LLVM's copy of googletest: http://llvm.org/viewvc/llvm-project?view=rev&revision=100895 Is it still being used? If so, would you mind pushing these patches upstream to the googletest project: http://code.google.com/p/googletest/ Otherwise we may drop them, because it makes it harder to import new releases of googlet...

...ot;make all". To build and run the unit tests, use "make check-unit". 3) I did not actually include the testing framework in the patch; It will need to be checked in separately. There are two approaches to this. One approach is to use the svn:external feature to create a link to the googletest svn repository from the LLVM svn repository. The other approach is to take a snapshot of googletest and check it in to the LLVM repository. The GoogleTest tar archive is here: http://code.google.com/p/googletest/downloads/list. I've located it within the LLVM source tree in the location "...

...ot; >> feature for use in combinatorially generating parameterised tests. A FIXME >> comment in ProfileData\CoverageMappingTest.cpp suggests that I'm not the >> only one to have tried and discovered that they cannot use this feature. The >> problem is that the version of googletest (v 1.8.0, released in Aug 2016) in >> the LLVM tree requires TR1 tuple support for this feature, which is not >> really supported in recent compilers, and has been explicitly disabled in >> our googletest CMakeLists.txt, thus disabling "Combine". >> >> I did...

On Thu, Mar 15, 2018 at 11:10 AM David Blaikie via llvm-dev < llvm-dev at lists.llvm.org> wrote: > +Chandler who might have some thoughts on this. > FWIW, I have no concerns about updating to a modern googletest. More modern the better IMO if someone is willing to do the work to make sure it works on all our platforms, etc. However: > Could you provide an example here of the motivation for the feature you're > missing? > I definitely think that the whole space of combinatorial testing shoul...

...ILD_TYPE=Release -DCMAKE_INSTALL_PREFIX:PATH=/opt/llvm/current && gmake (I am aware of FreeBSD llvm/clang ports, but the source build should always succeed as well.) Yuri ---errors--- Scanning dependencies of target gtest [ 91%] Building CXX object utils/unittest/CMakeFiles/gtest.dir/googletest/src/gtest-all.cc.o In file included from /xpool/llvm/latest/llvm/utils/unittest/googletest/src/gtest-all.cc:42: In file included from /xpool/llvm/latest/llvm/utils/unittest/googletest/src/gtest.cc:132: /xpool/llvm/latest/llvm/utils/unittest/googletest/src/gtest-internal-inl.h:153:3: error: field...

What is googletest ? Its aufully messy warnings wise on Cygwin. Aaron -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090219/8de0a211/attachment.html>

...n combinatorially generating parameterised tests. A > FIXME > >> comment in ProfileData\CoverageMappingTest.cpp suggests that I'm not > the > >> only one to have tried and discovered that they cannot use this > feature. The > >> problem is that the version of googletest (v 1.8.0, released in Aug > 2016) in > >> the LLVM tree requires TR1 tuple support for this feature, which is not > >> really supported in recent compilers, and has been explicitly disabled > in > >> our googletest CMakeLists.txt, thus disabling "Combine"....

...e>::Compare(const char*, const char*, >> const T1&, T2*) [with T1 = int, T2 = const clang::DirectoryEntry]' > > yes, they are annoying aren't they.  They all come from google's unittest > library.  I think it is best to fix them upstream at google. We're using googletest 1.5.0. These warnings seem to be fixed in 1.6.0, so here's a patch to upgrade us. Disclaimer: I've only tested this by doing "make check-all" on Linux/x86_64. Incidentally, the upgrade would have been much easier if we weren't carrying local changes to support Haiku OS and Mi...

Hi Jay, >> yes, they are annoying aren't they. They all come from google's unittest >> library. I think it is best to fix them upstream at google. > > We're using googletest 1.5.0. These warnings seem to be fixed in > 1.6.0, so here's a patch to upgrade us. Disclaimer: I've only tested > this by doing "make check-all" on Linux/x86_64. > > Incidentally, the upgrade would have been much easier if we weren't > carrying local changes to...

...andler Carruth <chandlerc at gmail.com> wrote: > On Thu, Mar 15, 2018 at 11:10 AM David Blaikie via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> +Chandler who might have some thoughts on this. >> > > FWIW, I have no concerns about updating to a modern googletest. More > modern the better IMO if someone is willing to do the work to make sure it > works on all our platforms, etc. > I'd be happy to do some of the work of this, and testing using MSVC14, perhaps 15 too, on x86_64 Windows 10 and (fairly elderly) GCC, possibly clang too, and Ubuntu...

> What is googletest ? Framework for units tests in llvm. http://code.google.com/p/googletest/ > Its aufully messy warnings wise on Cygwin. If you have gcc 3.X you are going to get a bunch of warnings. What gcc are you using? -Tanya

Hello Jay, At the time I submitted those patches I also submitted them to googletest. As far as I know they got accepted, although I didn't verify that. I am no longer working on the Minix project, but since the Minix project is most definitely using llvm, I am cc:-ing this to the Minix developers mailing list. Perhaps they want to respond to this. -- Kees On 27 Jul 2011, a...

...check-unit". >> >> 3) I did not actually include the testing framework in the patch; >> It will >> need to be checked in separately. There are two approaches to this. >> One >> approach is to use the svn:external feature to create a link to the >> googletest svn repository from the LLVM svn repository. The other >> approach >> is to take a snapshot of googletest and check it in to the LLVM >> repository. >> >> The GoogleTest tar archive is here: >> http://code.google.com/p/googletest/downloads/list. I've loca...

...Test.cpp:64 #7 0x000000000046c749 in InputGraphTest_Observer_Test::TestBody (this=0xa1e6b0) at /home/rengolin/devel/llvm/src/llvm/tools/lld/unittests/DriverTests/InputGraphTest.cpp:201 #8 0x0000000000479bda in testing::Test::Run (this=0xa1e6b0) at /home/rengolin/devel/llvm/src/llvm/utils/unittest/googletest/src/gtest.cc:2162 #9 0x000000000047abd0 in testing::TestInfo::Run (this=0xa1d6f0) at /home/rengolin/devel/llvm/src/llvm/utils/unittest/googletest/src/gtest.cc:2309 #10 0x000000000047adc5 in testing::TestCase::Run (this=0xa1cfe0) at /home/rengolin/devel/llvm/src/llvm/utils/unittest/googletest/src/g...

...t find -lLLVMgtest $(ld): cannot find -lLLVMgtest_main --- unittests/Makefile.unittest | 2 +- utils/llvm-build/llvmbuild/componentinfo.py | 4 ++-- utils/llvm-build/llvmbuild/main.py | 5 ++++- utils/unittest/UnitTestMain/Makefile | 2 +- utils/unittest/googletest/Makefile | 2 +- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/unittests/Makefile.unittest b/unittests/Makefile.unittest index 580ad7d..bd32aed 100644 --- a/unittests/Makefile.unittest +++ b/unittests/Makefile.unittest @@ -34,7 +34,7 @@ ifneq ($(HAVE_PTHREAD), 1) CPP...

...ds a unit test framework to LLVM, along with a sample unit test > for DenseMap. I don't expect this patch to be accepted as-is, this is mainly > a trial balloon and proof of concept. I think this is a great idea! As Keir already noted, I would also agree with LLVM snapshotting a copy of googletest, but I think it should live in llvm/test/googletest (rather than top-level), since it's not going to be linked into anything outside of llvm/test. On the assumption that we'll end up using googletest, here are some comments on your patch: * s/Insure/Ensure/ * LLVM uses "llvm/foo.h&q...

Hi Paul, You added some support for Haiku to LLVM's copy of googletest: http://llvm.org/viewvc/llvm-project?view=rev&revision=83823 http://llvm.org/viewvc/llvm-project?view=rev&revision=106620 Is it still being used? If so, would you mind pushing these patches upstream to the googletest project: http://code.google.com/p/googletest/ Otherwise we may drop th...