search for: glut_player

Hi, the attached patch adds rendering of Kate streams using libtiger. To do so, it adds a new type of RGBA video. One can request the incoming video (in YUV) to be sent in RGBA (ie, asking liboggplay to do the conversion in the first place). The large changes in the GLUT player also include fixes for crash-on-no-sound, mono sound, and locking fixes (I *think* - at least it works fine for me

...dering(OggPlay *me, int track, int use_tiger); OggPlayErrorCode oggplay_overlay_kate_track_on_video(OggPlay *me, int kate_track, int video_track); -----------------8<--------------------------- Typo in the comment (is should be if): + unsigned char * rgba; /* may be NULL is no alpha */ In glut_player.c, If realloc fails then it returns NULL and this will overwrite the existing value of 'buffer' with null. That 'buffer' will then never be free'd and result in a memory leak. Although I suspect it'd crash anyway due to buffer being NULL when float_to_short_array is called:...

...could, but would change the API, and the implementation just returns a "not implemented" error currently if HAVE_KATE is undefined, (and a couple checks for validity) so it's not much dead code at all. If the 'moving target API' isn't a problem I can change it so. > In glut_player.c, If realloc fails then it returns NULL and this will > overwrite the existing value of 'buffer' with null. That 'buffer' will > then never be free'd and result in a memory leak. Although I suspect Good point. Common lazy programer idiom. Will fix. > In oggplay.c the...