search for: glthread

...uestfs_h *g) -{ - g->error_cb = default_error_cb; - g->error_cb_data = NULL; } static void diff --git a/lib/guestfs-internal.h b/lib/guestfs-internal.h index 37878b88d..c0a244a1e 100644 --- a/lib/guestfs-internal.h +++ b/lib/guestfs-internal.h @@ -54,6 +54,7 @@ #endif #include "glthread/lock.h" +#include "glthread/tls.h" #include "hash.h" #include "guestfs-internal-frontend.h" @@ -373,15 +374,6 @@ struct connection_ops { }; /** - * Stack of old error handlers. - */ -struct error_cb_stack { - struct error_cb_stack *next; - guestfs_erro...

...t;error_cb_data = NULL; -} - static void default_error_cb (guestfs_h *g, void *data, const char *msg) { diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index 6601096..1416c02 100644 --- a/src/guestfs-internal.h +++ b/src/guestfs-internal.h @@ -34,6 +34,7 @@ #endif #include "glthread/lock.h" +#include "glthread/tls.h" #include "hash.h" #include "guestfs-internal-frontend.h" @@ -387,13 +388,6 @@ struct connection_ops { int (*can_read_data) (guestfs_h *g, struct connection *); }; -/* Stack of old error handlers. */ -struct error_cb_sta...

...ISOs have the right version number. --- src/osinfo.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/osinfo.c b/src/osinfo.c index 0caacfa..907580e 100644 --- a/src/osinfo.c +++ b/src/osinfo.c @@ -62,6 +62,7 @@ #include "ignore-value.h" #include "glthread/lock.h" +#include "c-ctype.h" #include "guestfs.h" #include "guestfs-internal.h" @@ -548,9 +549,12 @@ parse_version (guestfs_h *g, xmlNodePtr node, struct osinfo *osinfo) CLEANUP_FREE char *content = NULL; content = (char *) xmlNodeGetContent (node); -...

...nary-io.lo CC bitrotate.lo CC c-ctype.lo CC c-strcasecmp.lo CC c-strncasecmp.lo CC c-strcasestr.lo CC careadlinkat.lo CC cloexec.lo CC count-one-bits.lo CC md5.lo CC sha256.lo CC dirname-lgpl.lo CC basename-lgpl.lo CC stripslash.lo CC fd-hook.lo CC freading.lo CC getugroups.lo CC localcharset.lo CC glthread/lock.lo CC malloca.lo CC mgetgroups.lo CC nonblocking.lo CC passfd.lo CC physmem.lo CC pipe2.lo CC sig-handler.lo CC sockets.lo CC stat-time.lo CC strnlen1.lo CC sys_socket.lo CC tempname.lo CC glthread/threadlib.lo CC unistd.lo CC wctype-h.lo CC xsize.lo CC asnprintf.lo CC canonicalize-lgpl.lo CC...

Previous discussion here: https://www.redhat.com/archives/libguestfs/2015-June/thread.html#00048 v2: - Use a cleanup handler to release the lock. - Rebase to upstream. Note I have not fixed the problem(s) with error handling (patch 3).

...+gl_THREADLIB_EARLY gl_INIT +gl_THREADLIB AM_PROG_LIBTOOL diff --git a/lib/Makefile.am b/lib/Makefile.am index 4a7cea1..62cdf35 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -38,6 +38,8 @@ libhivex_la_SOURCES = \ visit.c \ write.c +libhivex_la_SOURCES += $(top_srcdir)/gnulib/lib/glthread/threadlib.c + libhivex_la_LIBADD = ../gnulib/lib/libgnu.la $(LTLIBOBJS) libhivex_la_LDFLAGS = \ -version-info 0:0:0 \ diff --git a/lib/handle.c b/lib/handle.c index 9dcf81d..01b8d80 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -30,6 +30,8 @@ #include <sys/stat.h> #include <errno....

...gt; #include <unistd.h> #include <string.h> -#include <fcntl.h> -#include <time.h> #include <sys/stat.h> -#include <sys/select.h> #include <sys/types.h> #include <sys/wait.h> -#include <utime.h> #include <libintl.h> -#include "glthread/lock.h" #include "ignore-value.h" #include "guestfs.h" #include "guestfs-internal.h" -#include "guestfs-internal-actions.h" -#include "guestfs_protocol.h" /* Old-style appliance is going to be obsoleted. */ static const char *kernel_na...

Previously posted in 2015: v1: https://www.redhat.com/archives/libguestfs/2015-June/msg00048.html v2: https://www.redhat.com/archives/libguestfs/2015-June/msg00118.html I have rebased and tidied up the patches, fixing a few spelling mistakes, but they are broadly the same as before. I also ran all the tests, which pass. As with the previous versions, this makes a change to the API, where you

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

...b/lib/Makefile.in > +++ gnulib/lib/Makefile.in > @@ -265,7 +265,7 @@ am_libgnu_la_OBJECTS = accept4.lo allocator.lo areadlink.lo \ > fd-hook.lo filenamecat-lgpl.lo filevercmp.lo full-read.lo \ > full-write.lo gettime.lo hash.lo hash-pjw.lo human.lo \ > i-ring.lo localcharset.lo glthread/lock.lo malloca.lo \ > - openat-die.lo openat-safer.lo pipe2.lo quotearg.lo \ > + open_memstream.lo openat-die.lo openat-safer.lo pipe2.lo quotearg.lo \ > read-file.lo safe-read.lo safe-write.lo save-cwd.lo sockets.lo \ > stat-time.lo strnlen1.lo sys_socket.lo tempname.lo \ > g...

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

...not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#include <config.h> + +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <string.h> +#include <errno.h> + +#include "glthread/lock.h" +#include "ignore-value.h" + +#include "guestfs.h" +#include "guestfs-internal.h" +#include "guestfs-internal-actions.h" +#include "guestfs_protocol.h" + +#include "locking.h" + +static gl_lock_t guestfs___lookup_lock_or_abort...

--- generator/c.ml | 2 -- 1 file changed, 2 deletions(-) diff --git a/generator/c.ml b/generator/c.ml index 055b683..963cf21 100644 --- a/generator/c.ml +++ b/generator/c.ml @@ -1213,9 +1213,7 @@ and generate_client_actions hash () = #include <stdlib.h> #include <stdint.h> #include <inttypes.h> -#include <sys/types.h> #include <sys/stat.h> -#include

...ad.c lib/full-read.h lib/full-write.c lib/futimens.c lib/gai_strerror.c lib/getaddrinfo.c lib/getcwd-lgpl.c lib/getdelim.c lib/getdtablesize.c lib/getline.c lib/getlogin_r.c lib/gettext.h lib/gettime.c lib/gettimeofday.c lib/glob-libc.h lib/glob.c lib/glob.in.h lib/glthread/lock.c lib/glthread/lock.h lib/glthread/threadlib.c lib/hash.c lib/hash.h lib/ignore-value.h lib/inet_ntop.c lib/intprops.h lib/lchown.c lib/localcharset.c lib/localcharset.h lib/lseek.c lib/lstat.c lib/malloc.c lib/mbrtowc.c lib/mbsinit.c lib/mbsrtowcs-impl.h lib/...

From: Maros Zatko <mzatko@redhat.com> Patch adds recursive mutex around C calls, which tries to fix potential race condition in guestfs_umount_local (see [1]). [1] - https://bugzilla.redhat.com/show_bug.cgi?id=917706 Maros Zatko (1): generator: c.ml - wrap non deamon function with recursive mutex generator/c.ml | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 1.8.5.3

This patch isn't ready to go upstream. In fact, I think we might do a quick 1.30 release soon, and save this patch, and also the extensive changes proposed for the test suite[1], to after 1.30. Currently it is not safe to use the same handle from multiple threads, unless you implement your own mutexes. See: http://libguestfs.org/guestfs.3.html#multiple-handles-and-multiple-threads These