search for: glsl_to_tgsi

all subexpression inside an ir_assignment needs to be tagged as precise. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 80 ++++++++++++++++++++++++------ 1 file changed, 65 insertions(+), 15 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index c5d2e0fcd2..19f90f21fe 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++ b/src/mesa/state_...

...> But this series is a good idea, since it might allow us to become more > aggressive with optimizations in radeonsi as well. > > >> This series fixes this bug in Tomb Raider and one CTS test for 4.4 and >> 4.5 >> >> Note on Patch 3: I really dislike how I tell glsl_to_tgsi_visitor to >> apply the >> precise flag on instruction emited in ir_assignment->rhs->accept(); >> but I found >> no other easy way to handle this. Maybe somebody of you has a better >> idea? > > Sent a suggestion, as well as comments on patches 4 & 5....

...related to how conservative LLVM is. But this series is a good idea, since it might allow us to become more aggressive with optimizations in radeonsi as well. > This series fixes this bug in Tomb Raider and one CTS test for 4.4 and 4.5 > > Note on Patch 3: I really dislike how I tell glsl_to_tgsi_visitor to apply the > precise flag on instruction emited in ir_assignment->rhs->accept(); but I found > no other easy way to handle this. Maybe somebody of you has a better idea? Sent a suggestion, as well as comments on patches 4 & 5. Patches 1 & 2: Reviewed-by: Nicolai Hähn...

...good idea, since it might allow us to become more >> aggressive with optimizations in radeonsi as well. >> >> >>> This series fixes this bug in Tomb Raider and one CTS test for 4.4 and >>> 4.5 >>> >>> Note on Patch 3: I really dislike how I tell glsl_to_tgsi_visitor to >>> apply the >>> precise flag on instruction emited in ir_assignment->rhs->accept(); >>> but I found >>> no other easy way to handle this. Maybe somebody of you has a better >>> idea? >> >> Sent a suggestion, as well as comm...

...to TGSI, which can be then used by drivers to disable certain unsafe optimisations which may otherwise alter calculations, which depend on having the same result across shaders. This series fixes this bug in Tomb Raider and one CTS test for 4.4 and 4.5 Note on Patch 3: I really dislike how I tell glsl_to_tgsi_visitor to apply the precise flag on instruction emited in ir_assignment->rhs->accept(); but I found no other easy way to handle this. Maybe somebody of you has a better idea? Karol Herbst (9): tgsi: add precise flag to tgsi_instruction tgsi/dump: print _PRECISE modifier on Instrutions...