search for: globallyhashedtype

Look for this code in lld/coff/pdb.cpp if (Config->DebugGHashes) { ArrayRef<GloballyHashedType> Hashes; std::vector<GloballyHashedType> OwnedHashes; if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) Hashes = getHashesFromDebugH(*DebugH); else { OwnedHashes = GloballyHashedType::hashTypes(Types); Hashes = OwnedHashes; } In the else block there, add a log message...

...GO to see how much faster can it get? I might try that as well, as 10% speed improvement might be handy. On Sun, Jan 28, 2018 at 11:14 PM, Zachary Turner <zturner at google.com> wrote: > Look for this code in lld/coff/pdb.cpp > > > if (Config->DebugGHashes) { > ArrayRef<GloballyHashedType> Hashes; > std::vector<GloballyHashedType> OwnedHashes; > if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) > Hashes = getHashesFromDebugH(*DebugH); > else { > OwnedHashes = GloballyHashedType::hashTypes(Types); > Hashes = OwnedHashes; > } > >...

...ht try that as well, as 10% speed improvement might > be handy. > > On Sun, Jan 28, 2018 at 11:14 PM, Zachary Turner <zturner at google.com> > wrote: > >> Look for this code in lld/coff/pdb.cpp >> >> >> if (Config->DebugGHashes) { >> ArrayRef<GloballyHashedType> Hashes; >> std::vector<GloballyHashedType> OwnedHashes; >> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >> Hashes = getHashesFromDebugH(*DebugH); >> else { >> OwnedHashes = GloballyHashedType::hashTypes(Types); >> Hashes = Owned...

...gt;> >>> On Sun, Jan 28, 2018 at 11:14 PM, Zachary Turner <zturner at google.com> >>> wrote: >>> >>>> Look for this code in lld/coff/pdb.cpp >>>> >>>> >>>> if (Config->DebugGHashes) { >>>> ArrayRef<GloballyHashedType> Hashes; >>>> std::vector<GloballyHashedType> OwnedHashes; >>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>> Hashes = getHashesFromDebugH(*DebugH); >>>> else { >>>> OwnedHashes = GloballyHashedType::h...

...ement >> might be handy. >> >> On Sun, Jan 28, 2018 at 11:14 PM, Zachary Turner <zturner at google.com> >> wrote: >> >>> Look for this code in lld/coff/pdb.cpp >>> >>> >>> if (Config->DebugGHashes) { >>> ArrayRef<GloballyHashedType> Hashes; >>> std::vector<GloballyHashedType> OwnedHashes; >>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>> Hashes = getHashesFromDebugH(*DebugH); >>> else { >>> OwnedHashes = GloballyHashedType::hashTypes(Types); &gt...

...Jan 28, 2018 at 11:14 PM, Zachary Turner <zturner at google.com> >>>> wrote: >>>> >>>>> Look for this code in lld/coff/pdb.cpp >>>>> >>>>> >>>>> if (Config->DebugGHashes) { >>>>> ArrayRef<GloballyHashedType> Hashes; >>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>> Hashes = getHashesFromDebugH(*DebugH); >>>>> else { >>>>> OwnedHashes = G...

...achary Turner <zturner at google.com> >>>>> wrote: >>>>> >>>>>> Look for this code in lld/coff/pdb.cpp >>>>>> >>>>>> >>>>>> if (Config->DebugGHashes) { >>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>> Hashes = getHashesFromDebugH(*DebugH); >>>>>> else { >>>>>...

...google.com> >>>>>> wrote: >>>>>> >>>>>>> Look for this code in lld/coff/pdb.cpp >>>>>>> >>>>>>> >>>>>>> if (Config->DebugGHashes) { >>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>> Hashes = getHashesFromDebugH(*DebugH); >>>>>>> else { >...

...gt;>> > wrote: >>>>>>> >>>>>>>> Look for this code in lld/coff/pdb.cpp >>>>>>>> >>>>>>>> >>>>>>>> if (Config->DebugGHashes) { >>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>> Hashes = getHashesFromDebugH(*DebugH); >>>>>>>...

...>>>>>>>> >>>>>>>>> Look for this code in lld/coff/pdb.cpp >>>>>>>>> >>>>>>>>> >>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>> Hashes = getHashesFromDebugH(*DebugH); >>>>...

Ok I went for kind of middle ground solution, I patch in the obj files, but as adding a new section didn't seem to work, I add a "shadow" section, by editing the pointer to line number and the virtual size on the .debug$T section. Although technically broken, both link.exe and lld-link.exe don't seem to mind the alterations and as the shadow .debug$H is not really a section

...>>> >>>>>>>>>> Look for this code in lld/coff/pdb.cpp >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>>> Hashes = getHashesFromDebugH(*DebugH); >...

...;>>>>>>>>> Look for this code in lld/coff/pdb.cpp >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>>>> Hashes = getHashesFromDebugH(*D...

...;> Look for this code in lld/coff/pdb.cpp >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>>>>>> Hashes...

...;>>>>> Look for this code in lld/coff/pdb.cpp >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>>>>> Hashes = getHashesF...

We don't generate any .lib as those don't work well with incremental linking (and give zero advantages when linking AFAIK), and it would be pretty easy to have a modern format for having a .ghash for multiple files, something simple like size prefixed name and then size prefixed ghash blobs. On Fri, Jan 26, 2018 at 8:44 PM, Zachary Turner <zturner at google.com> wrote: > We

...his code in lld/coff/pdb.cpp >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>>>>>>...

...coff/pdb.cpp >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> if (Config->DebugGHashes) { >>>>>>>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; >>>>>>>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; >>>>>>>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) >>>>>>>>>>>...

...t;>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> if (Config->DebugGHashes) { > >>>>>>>>>>>>>>> ArrayRef<GloballyHashedType> Hashes; > >>>>>>>>>>>>>>> std::vector<GloballyHashedType> OwnedHashes; > >>>>>>>>>>>>>>> if (Optional<ArrayRef<uint8_t>> DebugH = getDebugH(File)) > >>>>>>>&...

...Sections / getSectionName) looking for .debug$T and .debug$H sections. If you find a .debug$H section then you can just skip that object file. If you find a .debug$T but not a .debug$H, then basically do the same thing that LLD does in PDBLinker::mergeDebugT (create a CVTypeArray, and pass it to GloballyHashedType::hashTypes. That will return an array of hash values. (the format of .debug$H is the header, followed by the hash values). Then when you're writing the list of sections, just add in the .debug$H section right after the .debug$T section. Currently llvm-objcopy only writes ELF files, so it wo...