search for: global_unlock

Hello, I work at SmarctJog.com, we have here some patches on IceCast for performance and reliability, these are mostly client/connection/source cleanups (a slave merge is underway, and some more good stuff (c)), but we'd like this to be merged in before the list gets any longer. Please find attached a list of our patches with a short desc: This one is actually not from us/me, it was found

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi In connection.c arround line 847 icecast2 does: if (global.clients >= client_limit) { client_send_504(client, "The server is already full. Try again later."); global_unlock(); return; } Then just a little bit later, does the same thing in the if (source) {} block. Is this code redundant ? - -- Mihai RUSU Email: dizzy@roedu.net GPG : http://dizzy.roedu.net/dizzy-gpg.txt WWW: http://dizzy.roedu.net...

...if (!read_only) { - if (shm_ds.shm_perm.cuid != 0 || shm_ds.shm_perm.cgid != 0) { + if (shm_ds.shm_perm.cuid != 0 || shm_ds.shm_perm.cgid != root_gid) { DEBUG(0,("ERROR: root did not create the shmem\n")); global_unlock(); return NULL; -- -------------------------------------------------------- Buying an operating system without source is like buying a self-assembly Space Shuttle with no instructions. --------------------------------------------------------

On Thursday 12 February 2004 02:36, Mihai RUSU wrote: > Hi > > In connection.c arround line 847 icecast2 does: > if (global.clients >= client_limit) { > client_send_504(client, > "The server is already full. Try again later."); > global_unlock(); > return; > } > > Then just a little bit later, does the same thing in the if (source) {} > block. > > Is this code redundant ? No. The first check comes early - it allows us to reject the client immediately if there's no chance of it being allowed in. The...

...f (shm_ds.shm_perm.cuid != 0 || shm_ds.shm_perm.cgid != 0) { + if (shm_ds.shm_perm.cuid != 0 || ((shm_ds.shm_perm.cgid != root_gid) && (shm_ds.shm_perm.cgid != 0))) { DEBUG(0,("ERROR: root did not create the shmem\n")); global_unlock(); return NULL; -- -------------------------------------------------------- Buying an operating system without source is like buying a self-assembly Space Shuttle with no instructions. --------------------------------------------------------

I just installed the 8/99 release of Solaris 7 on three Sun Ultra 10's and it seems to have broken Samba. I am running Samba 2.0.5a and it works fine on an Ultra 10 running the 5/99 release of Solaris 7. All of the Ultra 10's are using the 64 bit kernel. This is the errors that I am getting. [1999/10/22 21:09:56, 0] locking/shmem_sysv.c:sysv_shm_open(597) ERROR: root did not create the

...+415,7 @@ */ global_lock(); if (global.sources >= source_limit) { - INFO1("Source (%s) logged in, but there are too many sources", mount); + INFO1("Source (%s) logged in, but there are too many sources, %s", mount, client->con->ip); global_unlock(); return 0; } @@ -442,7 +442,7 @@ if (contenttype != NULL) { format_type_t format = format_get_type(contenttype); if (format == FORMAT_ERROR) { - WARN1("Content-type \"%s\" not supported, dropping source", contenttype); +...