search for: gl_warn_add

...p, " %.*s = ", (int) k, values[j]); | ^~~~~~~~~~~ --- m4/guestfs-c.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/m4/guestfs-c.m4 b/m4/guestfs-c.m4 index 3fd44ed6b..e20721f5f 100644 --- a/m4/guestfs-c.m4 +++ b/m4/guestfs-c.m4 @@ -105,6 +105,9 @@ gl_WARN_ADD([-Wimplicit-fallthrough=4]) dnl GCC level 2 gives incorrect warnings, so use level 1. gl_WARN_ADD([-Wformat-truncation=1]) +dnl GCC 9 at level 2 gives apparently bogus errors when %.*s is used. +gl_WARN_ADD([-Wformat-overflow=1]) + AC_SUBST([WARN_CFLAGS]) NO_SNV_CFLAGS= -- 2.20.1

These patches first make src/ warning free, and then turn on the strict warning options. 75 0001-build-suppress-an-ignored-write-return-value-warning.patch 38 0002-build-suppress-an-ignored-dup-return-value-warning.patch 27 0003-generator.ml-suppress-signed-unsigned-compare-warnin.patch 48 0004-build-don-t-perform-arithmetic-on-void-pointers.patch 30

...s_a_CFLAGS = \ - $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(WARN_CFLAGS) $(NO_SNV_CFLAGS) $(WERROR_CFLAGS) \ $(LIBVIRT_CFLAGS) $(LIBXML2_CFLAGS) \ -fPIC diff --git a/m4/guestfs-c.m4 b/m4/guestfs-c.m4 index 6621a2747..13310d5db 100644 --- a/m4/guestfs-c.m4 +++ b/m4/guestfs-c.m4 @@ -105,6 +105,12 @@ gl_WARN_ADD([-Wformat-truncation=1]) AC_SUBST([WARN_CFLAGS]) +NO_SNV_CFLAGS= +gl_COMPILER_OPTION_IF([-Wno-shift-negative-value],[ + NO_SNV_CFLAGS="-Wno-shift-negative-value" +]) +AC_SUBST([NO_SNV_CFLAGS]) + AC_DEFINE([lint], [1], [Define to 1 if the compiler is checking for lint.]) AC_DEFIN...

...ed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index fa97479..6e42423 100644 --- a/configure.ac +++ b/configure.ac @@ -141,6 +141,10 @@ if test "$gl_gcc_warnings" = yes; then # Work around warning in src/inspect.c. This seems to be a bug in gcc 4.5.1. gl_WARN_ADD([-Wno-strict-overflow]) + # Missing field initializers is not a bug in C. Adding this to $nw above + # did not work, so force it here instead. + gl_WARN_ADD([-Wno-missing-field-initializers]) + gl_WARN_ADD([-fdiagnostics-show-option]) AC_SUBST([WARN_CFLAGS]) -- 1.7.6

The warnings in daemon were aggravating and risky for development (too easy to miss new ones) so I spent some time last week and today working on removing them. The first patch gets us down to almost no warnings with the original -Wall setting. That was by far the hardest part. Once I'd done that, I enabled nearly all of gcc's warnings via gnulib's warnings and manywarnings modules

Hi, as it was already discussed on this list, here it is my attempt in splitting virt-p2v in an own repository. Sadly there are things that must be copied from libguestfs, as it cannot be avoided. The approach taken was to run a script (will send separately) to just get the "p2v" subdirectory with its history as own repository, and then add in few followup commits all the bits needed

Various changes/fixes to use smaller stack frames. Rich.

...(s, r->val[i].%s, len);\n" name; pr " s[len] = 0;\n"; pr " (*env)->SetObjectField (env, jfl, fl,\n"; diff --git a/m4/guestfs_c.m4 b/m4/guestfs_c.m4 index 002c32f..7be006d 100644 --- a/m4/guestfs_c.m4 +++ b/m4/guestfs_c.m4 @@ -87,9 +87,13 @@ gl_WARN_ADD([-fdiagnostics-show-option]) dnl Now some warnings we want to enable and/or customize ... -dnl Warn about large stack allocations. 10000 happens to be the -dnl same size as Coverity warns about. -gl_WARN_ADD([-Wframe-larger-than=10000]) +dnl Warn about large stack frames. This does not inclu...

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a