Displaying 3 results from an estimated 3 matches for "gk20a_instobj_new".
2016 Dec 12
1
[bug report] drm/nouveau/imem: convert to new-style nvkm_subdev
...-dan ]
Hello Ben Skeggs,
This is a semi-automatic email about new static checker warnings.
The patch b7a2bc1886d0: "drm/nouveau/imem: convert to new-style
nvkm_subdev" from Aug 20, 2015, leads to the following Smatch
complaint:
drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c:536 gk20a_instobj_new()
error: we previously assumed 'node' could be null (see line 532)
drivers/gpu/drm/nouveau/nvkm/subdev/instmem/gk20a.c
531 align, &node);
532 *pmemory = node ? &node->memory : NULL;
^^^^
Added a new check for NULL.
533 if (ret)...
2023 Dec 08
1
[PATCH] drm/nouveau: Fixup gk20a instobj hierarchy
...se.memory);
- node->base.memory.ptrs = &gk20a_instobj_ptrs;
+ nvkm_memory_ctor(&gk20a_instobj_func_iommu, &node->base.base.memory);
+ node->base.base.memory.ptrs = &gk20a_instobj_ptrs;
/* Allocate backing memory */
for (i = 0; i < npages; i++) {
@@ -533,7 +533,7 @@ gk20a_instobj_new(struct nvkm_instmem *base, u32 size, u32 align, bool zero,
else
ret = gk20a_instobj_ctor_dma(imem, size >> PAGE_SHIFT,
align, &node);
- *pmemory = node ? &node->memory : NULL;
+ *pmemory = node ? &node->base.memory : NULL;
if (ret)
return ret;
--
2.43...
2023 Dec 14
1
[PATCH] drm/nouveau: Fixup gk20a instobj hierarchy
...y.ptrs = &gk20a_instobj_ptrs;
> + nvkm_memory_ctor(&gk20a_instobj_func_iommu, &node->base.base.memory);
> + node->base.base.memory.ptrs = &gk20a_instobj_ptrs;
>
> /* Allocate backing memory */
> for (i = 0; i < npages; i++) {
> @@ -533,7 +533,7 @@ gk20a_instobj_new(struct nvkm_instmem *base, u32 size, u32 align, bool zero,
> else
> ret = gk20a_instobj_ctor_dma(imem, size >> PAGE_SHIFT,
> align, &node);
> - *pmemory = node ? &node->memory : NULL;
> + *pmemory = node ? &node->base.memory : NULL;
>...