search for: giantdisast

...e stream (EOF) was terminating the receiver. The change is fully compatible as it is explained in more detail in the commit itself. Unfortunately the change to the sender is only compatible together with a kernel change, it is therefore not part of this patch set. Everything is also on git://btrfs.giantdisaster.de/git/btrfs-progs recv1 Alex Lyakas (1): btrfs-progs: Fix the receive code pathing Stefan Behrens (16): Btrfs-progs: Use /proc/mounts instead of /etc/mtab Btrfs-progs: ignore subvols above BTRFS_LAST_FREE_OBJECTID Btrfs-progs: close file descriptor in cmds-send.c Btrfs-progs: fix a...

...f-by-one in snprintf() check Product: rsync Version: 3.1.1 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core Assignee: wayned at samba.org Reporter: sbehrens at giantdisaster.de QA Contact: rsync-qa at samba.org >From 55639a2dbc7b2fd5bca9f7068ae0153627e8a7fa Mon Sep 17 00:00:00 2001 From: Stefan Behrens <sbehrens at giantdisaster.de> Date: Tue, 21 Apr 2015 13:50:38 +0200 Subject: [PATCH] rsync: fix of-by-one in check of snprintf() result Signed-off-...

...when scrub tries to repair an I/O or checksum error and one of the devices containing the mirror is missing, it crashes in bio_add_page because the bdev is a NULL pointer for missing devices. Reported-by: Marco L. Crociani <marco.crociani@gmail.com> Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- fs/btrfs/scrub.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index b679bf6..7e487be 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c @@ -998,6 +998,7 @@ static int scrub_setup_recheck_block(struct scrub_dev *sdev, page = sb...

...asks in parallel. It is prevented that the device add/delete/balance/replace/resize operations are started in parallel. By mistake, the defragmentation operation was included in the check for mutually exclusiveness as well. This is fixed with this commit. Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- fs/btrfs/ioctl.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index b908960..40631cf 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2245,13 +2245,6 @@ static int btrfs_ioctl_defrag(struct file *file, void __user *argp) if (...

The btrfs-progs tools changed the output: - 100GiB instead of 100GB - The number of spaces was changed Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- common/filter | 2 +- common/filter.btrfs | 3 ++- tests/btrfs/006 | 6 +++--- tests/btrfs/006.out | 36 ++++++++++++++++++------------------ 4 files changed, 24 insertions(+), 23 deletions(-) diff --git a/common/filter b/common/filter index dbb1674..ee738ca 100644 --- a...

From: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Scrubing supers is not in a transaction context, when trying to write supers to disk, we should check if we are trying to scrub supers.Fix it. Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> --- fs/btrfs/disk-io.c | 2 ++ fs/btrfs/transaction.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/fs/btrfs/disk-io.c

Reduce ioprio class of scrub readahead threads to idle priority. This setting is fixed. This priority has shown the best performance during all measurements. Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- fs/btrfs/ctree.h | 3 +++ fs/btrfs/reada.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index ec42a24..e6f772d 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -173,6 +173,9 @@ static int btrfs_csum_sizes[] = { 4, 0 }; #de...

During unmount, it could happen that the integrity checker printed a warning message "attempt to free ... on umount which is not yet iodone" which turned out to be a false positive. Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- fs/btrfs/check-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index d85b9d1..b5e9891 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c @@ -3338,7 +3338,7 @@ void btrfsic_...

gcc says "warning: comparison of unsigned expression >= 0 is always true" because i is an unsigned long. And gcc is right this time. Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- fs/btrfs/extent_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 64dc93f..a32ebfe 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -4104,8 +4104,8 @@ struct extent_buffer *alloc_dummy_extent_b...

Hi everyone, I was trying the new send/receive feature today but can''t make it work. These are the commands I was using: btrfs subvol snap -r /mnt/data1/@downloads/ /mnt/data1/snapshots/testsnap btrfs send /mnt/data1/snapshots/testsnap | btrfs receive /mnt/data1/snapshots/testreceive/ This command never finishes. A ''ls /mnt/data1/snapshots/testreceive/ '' never

The goal is to detect when drives start to get an increased error rate, when drives should be replaced soon. Therefore statistic counters are added that count IO errors (read, write and flush). Additionally, the software detected errors like checksum errors and corrupted blocks are counted. An ioctl interface is added to get the device statistic counters. A second ioctl is added to atomically get

Sigh. In the previously sent v2 patch the mail 1/4 exceeded the archaic 100,000 chars limit of vger.kernel.org (no complains from checkpatch.pl though). Therefore I now prepared a git-daemon for pulling. Please pull from git://btrfs.giantdisaster.de/git/btrfs integrity-check-patch-v2 Changes v1-v2: - Merge with updated disk flush code - Use bdevname to print the bdev''s name instead of the disk''s name - Fix v1 formatting issue (labels, and a few casts still had been wrong) - Merge with current scrub.c - Cast all u64 p...

...ultiplex a request/response handshake plus Btrfs send streams, all in the same stream. In this case you cannot evaluate an EOF condition as an end of the Btrfs send stream. You need something else, and the <end cmd> is just perfect for this purpose. Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- cmds-send.c | 35 +++++++++++++++++++++++++++++++---- ioctl.h | 15 ++++++++++++++- 2 files changed, 45 insertions(+), 5 deletions(-) diff --git a/cmds-send.c b/cmds-send.c index 9bb4206..adfb67d 100644 --- a/cmds-send.c +++ b/cmds-send.c @@ -244,7 +244,8 @@ out: return ERR_PTR...

...code copy) > Paul Mackerras > Scott Howard Yes, but there are more than that. And searching for attributed authors gives: $ git log -p | awk '$1 == "Author:"'| sort | uniq -c | sort -nk1 1 Author: restrict <restrict> 1 Author: Stefan Behrens <sbehrens at giantdisaster.de> 2 Author: Ben Walton <bwalton at artsci.utoronto.ca> 3 Author: John H Terpstra <jht at samba.org> 4 Author: Jos Backus <jos at samba.org> 10 Author: Tiziano Müller <tiziano.mueller at stepping-stone.ch> 11 Author: Paul Mackerras <paulus at samba.or...

Changes v1-v2: - Remove restriction that BTRFS_IOC_GET_DEVICE_STATS is a privileged operation - Cast u64 to unsigned long long for printf() Changes v2-v3: - Rebased on Chris'' current master Changes v3-v4: - Add padding at end of ioctl structure Changes v4-v5: - The statistic members in the ioctl are now organized as an array of 64 bit values. Symbolic names for the array indexes

...; Scott Howard > > Yes, but there are more than that. And searching for attributed > authors gives: > > $ git log -p | awk '$1 == "Author:"'| sort | uniq -c | sort -nk1 > 1 Author: restrict <restrict> > 1 Author: Stefan Behrens <sbehrens at giantdisaster.de> > 2 Author: Ben Walton <bwalton at artsci.utoronto.ca> > 3 Author: John H Terpstra <jht at samba.org> > 4 Author: Jos Backus <jos at samba.org> > 10 Author: Tiziano Müller <tiziano.mueller at stepping-stone.ch> > 11 Author: Paul Mackerr...

Hi, I am maintaining a port of rsync (https://github.com/perlundq/yajsync) which is GPL:ed of course. The main purpose of the project is to provide a Java API library for the rsync protocol. It would therefore be really nice to be able to use LGPL as the license. But in order to do so I would first have to get a list of all the individual contributors to rsync and then be able to contact them

...head IO priority. Another fact which is no big surprise is that the overall data throughput of SSDs does not improve from the modified IO priority. The only effect on SSDs is that it is now possible to control the amount of IO time slice spent for scrub. Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- btrfs.c | 8 ++++++-- man/btrfs.8.in | 21 +++++++++++++++++---- scrub.c | 33 +++++++++++++++++++++++++++++++-- 3 files changed, 54 insertions(+), 8 deletions(-) diff --git a/btrfs.c b/btrfs.c index 1def354..ab9fcee 100644 --- a/btrfs.c +++ b/btrfs.c @@ -131,12...

A few months ago, my btrfs storage array became corrupted because of a power failure. A while ago, I made this thread to try and resolve the problem. (http://www.digipedia.pl/usenet/thread/11904/15955/) You can find detailed information about the problem in the previous thread, but I am happy to provide any other details. It didn''t really go anywhere in the way of solving my problem. The

...e the received UUID, all generation values and all time values. The parameters to the "--fields" option is a list of items to print: --fields=gen,dirid,uuid,puuid,ruuid,cgen,ogen,sgen,rgen,ctime,otime, stime,rtime,path,rootid,parent,topid,all Signed-off-by: Stefan Behrens <sbehrens@giantdisaster.de> --- btrfs-list.c | 418 ++++++++++++++++++++++++++++++++++++------------------- btrfs-list.h | 40 +++++- cmds-subvolume.c | 57 +++----- man/btrfs.8.in | 19 +-- 4 files changed, 339 insertions(+), 195 deletions(-) diff --git a/btrfs-list.c b/btrfs-list.c index 1246a25..b0d...