search for: gfp_none

On Mon, Jun 11, 2018 at 6:36 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > Maybe it will help to have GFP_NONE which will make any allocation > fail if attempted. Linus, would this address your comment? It would definitely have helped me initially overlook that call chain. But then when I started looking at the whole dma_map_page() thing, it just raised my hackles again. I would seriously suggest havi...

On Mon, Jun 11, 2018 at 6:36 PM Michael S. Tsirkin <mst at redhat.com> wrote: > > Maybe it will help to have GFP_NONE which will make any allocation > fail if attempted. Linus, would this address your comment? It would definitely have helped me initially overlook that call chain. But then when I started looking at the whole dma_map_page() thing, it just raised my hackles again. I would seriously suggest havi...

On Mon, Jun 11, 2018 at 11:32 AM Linus Torvalds <torvalds at linux-foundation.org> wrote: > > So now we apparently do a GFP_KERNEL allocation insider the mm zone > lock, which is broken on just _so_ many levels. Oh, I see the comment about how it doesn't actually do an allocation at all because it's a single-entry. Still too damn ugly to live, and much too fragile. No way

On Mon, Jun 11, 2018 at 11:32 AM Linus Torvalds <torvalds at linux-foundation.org> wrote: > > So now we apparently do a GFP_KERNEL allocation insider the mm zone > lock, which is broken on just _so_ many levels. Oh, I see the comment about how it doesn't actually do an allocation at all because it's a single-entry. Still too damn ugly to live, and much too fragile. No way

...n. But I hear what you are saying about it being fragile. > Maybe there's some reason why that doesn't happen either, but > basically this whole callchain looks *way* to complicated to be used > under a core VM spinlock. > > Linus Maybe it will help to have GFP_NONE which will make any allocation fail if attempted. Linus, would this address your comment? -- MST

...esh Narayan Lal wrote: > Hi Wei, > > > On 06/12/2018 07:05 AM, Wei Wang wrote: >> On 06/12/2018 09:59 AM, Linus Torvalds wrote: >>> On Mon, Jun 11, 2018 at 6:36 PM Michael S. Tsirkin <mst at redhat.com> >>> wrote: >>>> Maybe it will help to have GFP_NONE which will make any allocation >>>> fail if attempted. Linus, would this address your comment? >>> It would definitely have helped me initially overlook that call chain. >>> >>> But then when I started looking at the whole dma_map_page() thing, it >>>...