Displaying 7 results from an estimated 7 matches for "getvalueexpectedflag".
2011 Dec 01
2
[LLVMdev] anchoring explicit template instantiations
...@@ static inline bool ProvideOption(Option *Handler,
>> StringRef ArgName,
>> break;
>>
>> default:
>> - errs() << ProgramName
>> - << ": Bad ValueMask flag! CommandLine usage error:"
>> - << Handler->getValueExpectedFlag() << "\n";
>> - llvm_unreachable(0);
>> + llvm_unreachable("Bad ValueMask flag!");
>
> This patch would lose the expected flag value, which is unfortunate.
It is unfortunate - though I'm not sure whether you're suggesting that
the change sh...
2011 Dec 01
3
[LLVMdev] anchoring explicit template instantiations
...Line.cpp
+++ b/lib/Support/CommandLine.cpp
@@ -294,10 +294,7 @@ static inline bool ProvideOption(Option *Handler,
StringRef ArgName,
break;
default:
- errs() << ProgramName
- << ": Bad ValueMask flag! CommandLine usage error:"
- << Handler->getValueExpectedFlag() << "\n";
- llvm_unreachable(0);
+ llvm_unreachable("Bad ValueMask flag!");
}
and
--- a/lib/Support/APInt.cpp
+++ b/lib/Support/APInt.cpp
@@ -1440,16 +1440,14 @@ APInt APInt::sqrt() const {
APInt nextSquare((x_old + 1) * (x_old +1));
if (this->ult(squ...
2011 Dec 01
0
[LLVMdev] anchoring explicit template instantiations
....cpp
> @@ -294,10 +294,7 @@ static inline bool ProvideOption(Option *Handler,
> StringRef ArgName,
> break;
>
> default:
> - errs() << ProgramName
> - << ": Bad ValueMask flag! CommandLine usage error:"
> - << Handler->getValueExpectedFlag() << "\n";
> - llvm_unreachable(0);
> + llvm_unreachable("Bad ValueMask flag!");
This patch would lose the expected flag value, which is unfortunate.
> +++ b/lib/Support/APInt.cpp
> @@ -1440,16 +1440,14 @@ APInt APInt::sqrt() const {
> APInt nextSq...
2011 Dec 01
0
[LLVMdev] anchoring explicit template instantiations
...eOption(Option *Handler,
>>> StringRef ArgName,
>>> break;
>>>
>>> default:
>>> - errs() << ProgramName
>>> - << ": Bad ValueMask flag! CommandLine usage error:"
>>> - << Handler->getValueExpectedFlag() << "\n";
>>> - llvm_unreachable(0);
>>> + llvm_unreachable("Bad ValueMask flag!");
>>
>> This patch would lose the expected flag value, which is unfortunate.
>
> It is unfortunate - though I'm not sure whether you're su...
2011 Dec 01
0
[LLVMdev] anchoring explicit template instantiations
On Nov 29, 2011, at 12:26 AM, David Blaikie wrote:
> For a bit of an experiment I've been trying to compile LLVM & Clang
> with -Weverything (disabling any errors that seem like more noise/less
> interesting). One warning I've recently hit a few instances of is
> -Wweak-vtable which is, in fact, an explicitly documented LLVM coding
> standard (
2011 Nov 29
2
[LLVMdev] anchoring explicit template instantiations
For a bit of an experiment I've been trying to compile LLVM & Clang
with -Weverything (disabling any errors that seem like more noise/less
interesting). One warning I've recently hit a few instances of is
-Wweak-vtable which is, in fact, an explicitly documented LLVM coding
standard ( http://llvm.org/docs/CodingStandards.html#ll_virtual_anch
). Some instances of this have been easy to
2011 Dec 11
5
[LLVMdev] anchoring explicit template instantiations
...@@ static inline bool ProvideOption(Option *Handler,
>> StringRef ArgName,
>> break;
>>
>> default:
>> - errs() << ProgramName
>> - << ": Bad ValueMask flag! CommandLine usage error:"
>> - << Handler->getValueExpectedFlag() << "\n";
>> - llvm_unreachable(0);
>> + llvm_unreachable("Bad ValueMask flag!");
>
> This patch would lose the expected flag value, which is unfortunate.
>
>> +++ b/lib/Support/APInt.cpp
>> @@ -1440,16 +1440,14 @@ APInt APInt::sqrt(...