search for: getthreadlocalmod

...the current constructors. Is the idea that we wouldn't change the constructors, and clang would call setThreadLocalMode() when it creates global variables? I would feel better if we changed the constructors, to avoid the risk of forgetting to do stuff like NewGV->setThreadLocalMode(OldGV->getThreadLocalMode()) when new variables are created based on old ones. Thanks, Hans

> Attaching a new patch that has the behaviour we discussed. > > The "globaldynamic" and default values have been merged, and LLVM will > start off with the user-specified model, but choose a more specific > one if possible. > > Please review. Awesome, thanks! I will try to do a more complete review tonight or tomorrow. For now, just two quick observations *) This

...false, GlobalValue::InternalLinkage, ConstantInt::getFalse(GV->getContext()), GV->getName()+".b", GV->getThreadLocalMode(), GV->getType()->getAddressSpace()); GV->getParent()->getGlobalList().insert(GV, NewGV); ... // Retain the name of the old global variable. People who are debugging their // programs may expect these variables to be named the same....

...ed the constructors, to avoid the risk of forgetting > to do stuff like No, this was just a hack to get clang to build. I would suggest changing the constructor just like your patch does, but keeping the existing ones just forwarding to the new ones. > NewGV->setThreadLocalMode(OldGV->getThreadLocalMode()) when new > variables are created based on old ones. The rest of the review: + separated copy of the variable). Optionally, a suggested TLS model may be Not sure I would call it "suggested". What it is is a promise by the FE/user that some restrictions apply to how the variable...

...pe()->getElementType(), + GV->isConstant(), + GlobalValue::ExternalLinkage, + 0 /* InitVal */, + Twine(GV->getName()), + 0 /* Before */, + GV->getThreadLocalMode(), + GV->getType()->getPointerAddressSpace(), + GV->hasInitializer() ? true : false); + return G; +} + +void ModPartXform::CollectGlobalSymbol(Function *F, + Module *New, +...