search for: getrawedgecount

....h (revision 74697) > +++ include/llvm/Analysis/Passes.h (working copy) ... > + ModulePass *createProfileLoaderPass(ProfileInfoLoader *PIL); I avoided the need for this by just loading the profile info twice, as a sort of intermediate step. > + std::vector<unsigned> ECs = PIL->getRawEdgeCounts(); This copies the vector, it should be a (const) refererence. > + // Instrument all of the edges... > + unsigned i = 0; > + for (Module::iterator F = M.begin(), E = M.end(); F != E; ++F) > + for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) { > +...

Hi, this is the first in a series of patches to cleanup and improve the LLVM Profiling Infrastructure. First and foremost this patch removes duplicate functionality from ProfileInfoLoader and ProfileInfo: The ProfileInfoLoader performed not only the loading of the profile information but also some synthesis of block and function execution counts from edge profiling information. Since the

...ude/llvm/Analysis/Passes.h (working copy) > ... >> + ModulePass *createProfileLoaderPass(ProfileInfoLoader *PIL); > > I avoided the need for this by just loading the profile info twice, as > a sort of intermediate step. > >> + std::vector<unsigned> ECs = PIL->getRawEdgeCounts(); > > This copies the vector, it should be a (const) refererence. > >> + // Instrument all of the edges... >> + unsigned i = 0; >> + for (Module::iterator F = M.begin(), E = M.end(); F != E; ++F) >> + for (Function::iterator BB = F->begin(), E = F->e...

Hi Daniel, Daniel Dunbar wrote: > Hi Andreas, > > First, thanks again for undertaking this work and submitting it back. There is a > lot of good stuff here and it would be great to see it get back into the tree. Thanks for taking the time to review this, I know its a huge patch. I still have a few questions on how you would like this patch to be re-factored and split up. > [...]