Displaying 6 results from an estimated 6 matches for "getprinterpass".
2010 Mar 14
3
[LLVMdev] [PATCH] Before/After IR Dumps
...Probably because
> MachineFunctionPrinterPass.h includes <string> somewhere along
> the line.
This is much better than the first iteration but still has many issues. There is no need to keep cc'ing cfe-dev on these patches which have nothing to do with clang.
Please rename the getPrinterPass method to createPrinterPass to indicate that the result returns a new pass, not returning an existing one. Please make it take a StringRef, not an std::string and eliminate the <string> #include from Pass.h.
MachineFunctionPrinterPass.h doesn't need to #include MachineFunctionPass.h, ju...
2010 Mar 12
0
[LLVMdev] [PATCH] Before/After IR Dumps
On Friday 12 March 2010 08:13:05 Kalle Raiskila wrote:
> David Greene wrote:
> > Here's a rework using PassManager as Chris suggested. Comments?
>
> Tried this second patch with the svn version 97812 (the one the patch is
> made against), but it doesn't compile:
> "llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&"
>
2010 Mar 12
2
[LLVMdev] [PATCH] Before/After IR Dumps
David Greene wrote:
> Here's a rework using PassManager as Chris suggested. Comments?
Tried this second patch with the svn version 97812 (the one the patch is
made against), but it doesn't compile:
"llvm/include/llvm/Pass.h:127: Error: expected unqualified-id before "&"
token"
Seems raw_ostream is forward declared but not defined (adding a missing
#include
2010 Mar 15
0
[LLVMdev] [PATCH] Before/After IR Dumps
...nday 14 March 2010 18:32:35 Chris Lattner wrote:
> This is much better than the first iteration but still has many issues.
> There is no need to keep cc'ing cfe-dev on these patches which have nothing
> to do with clang.
There's a clang patch in this set.
> Please rename the getPrinterPass method to createPrinterPass to indicate
> that the result returns a new pass, not returning an existing one. Please
Ok.
> make it take a StringRef, not an std::string and eliminate the <string>
> #include from Pass.h.
Ok.
> MachineFunctionPrinterPass.h doesn't need to #in...
2010 Mar 05
0
[LLVMdev] [PATCH] Before/After IR Dumps
...is intuitive. This requires that
> passes show up in the print option as a result of registering them with
> the PassManager.
I'd expect the pass manager to manage all of this. To get the appropriate printer for a pass, it would invoke a virtual method on the pass itself, e.g.:
P->getPrinterPass();
which would return a ModulePrinter, FunctionPrinter, MachineFunctionPrinter etc depending on the pass.
-Chris
2010 Mar 04
6
[LLVMdev] [PATCH] Before/After IR Dumps
On Thursday 04 March 2010 01:54:55 Chris Lattner wrote:
> On Mar 2, 2010, at 1:45 PM, David Greene wrote:
> > This set of patches adds support for dumping IR before or after specified
> > Passes. It adds the following command-line options:
> >
> > -print-before=<pass-option>
> > -print-after=<pass-option>
> > -print-before-all
> >