search for: getorcreateglobalvariabledi

We're inconsistent about using DW_AT_MIPS_linkage_name versus DW_AT_linkage_name. Variables (see DwarfCompileUnit::getOrCreateGlobalVariableDIE()) get the standard attribute for DWARF >= 4, MIPS for older. Subprograms (see DwarfUnit::applySubprogramDefinitionAttributes()) always get DW_AT_MIPS_linkage_name (no version check). Before I go drudging through however many tests will die if I add a version check... we DO want to fix this,...

...eType) + 2221 10 clang 0x00000000016b7e9c llvm::DwarfUnit::getOrCreateTypeDIE(llvm::MDNode const*) + 412 11 clang 0x00000000016b80a9 llvm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute) + 185 12 clang 0x00000000016dcd3d llvm::DwarfCompileUnit::getOrCreateGlobalVariableDIE(llvm::DIGlobalVariable) + 1757 13 clang 0x00000000016aa1aa 14 clang 0x00000000016aafde llvm::DwarfDebug::DwarfDebug(llvm::AsmPrinter*, llvm::Module*) + 2398 15 clang 0x000000000169186e llvm::AsmPrinter::doInitialization(llvm::Module&) + 974 16 clang 0x00...

...t;> llvm::DwarfUnit::getOrCreateTypeDIE(llvm::MDNode const*) + 412 >> 11 clang 0x00000000016b80a9 >> llvm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute) >> + 185 >> 12 clang 0x00000000016dcd3d >> llvm::DwarfCompileUnit::getOrCreateGlobalVariableDIE(llvm::DIGlobalVariable) >> + 1757 >> 13 clang 0x00000000016aa1aa >> 14 clang 0x00000000016aafde >> llvm::DwarfDebug::DwarfDebug(llvm::AsmPrinter*, llvm::Module*) + 2398 >> 15 clang 0x000000000169186e >> llvm::AsmPrinter::doInitializ...

...IE(llvm::MDNode const*) + 412 >>>> 11 clang 0x00000000016b80a9 >>>> llvm::DwarfUnit::addType(llvm::DIE&, llvm::DIType, llvm::dwarf::Attribute) + >>>> 185 >>>> 12 clang 0x00000000016dcd3d >>>> llvm::DwarfCompileUnit::getOrCreateGlobalVariableDIE(llvm::DIGlobalVariable) >>>> + 1757 >>>> 13 clang 0x00000000016aa1aa >>>> 14 clang 0x00000000016aafde >>>> llvm::DwarfDebug::DwarfDebug(llvm::AsmPrinter*, llvm::Module*) + 2398 >>>> 15 clang 0x000000000169186...

...gets optimized away) > Thanks David. I was thinking about this representational change for DIGlobalVariable: 1) replace the Variable field with a Value field of type ConstantData, and use it exclusively for constant initializers 2) change the logic in the debug info emitter (DwarfCompileUnit::getOrCreateGlobalVariableDIE) to look like this: if (the DIGlobalVariable was attached to a GlobalVariable) { // add a location to the variable DIE } else if (the DIGlobalVariable has an associated value) { // add a constant to the variable DIE } It seems that this way we would be able to do "emit an address, or a...

...lobal variable, which would tell the debugger how to calculate its address. But if the global has no address we would instead need a DW_AT_const_value attribute to represent the value, wouldn't we? Peter -- adrian > > 2) change the logic in the debug info emitter > (DwarfCompileUnit::getOrCreateGlobalVariableDIE) to look like this: > > if (the DIGlobalVariable was attached to a GlobalVariable) { > // add a location to the variable DIE > } else if (the DIGlobalVariable has an associated value) { > // add a constant to the variable DIE > } > > It seems that this way we would be a...

...ing about this representational change for >> DIGlobalVariable: >> >> 1) replace the Variable field with a Value field of type ConstantData, >> and use it exclusively for constant initializers >> 2) change the logic in the debug info emitter >> (DwarfCompileUnit::getOrCreateGlobalVariableDIE) to look like this: >> >> if (the DIGlobalVariable was attached to a GlobalVariable) { >> // add a location to the variable DIE >> } else if (the DIGlobalVariable has an associated value) { >> // add a constant to the variable DIE >> } >> >> It s...

On Mon, May 9, 2016 at 3:17 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: > > > On Mon, May 9, 2016 at 2:33 PM, David Blaikie <dblaikie at gmail.com> wrote: > >> >> >> On Mon, May 9, 2016 at 1:53 PM, Peter Collingbourne <peter at pcc.me.uk> >> wrote: >> >>> >>> >>> On Fri, May 6, 2016 at 2:10 PM, David