search for: getorcreatedatafrag

...rrently use any string attributes, so I did not implement them. *) Having an attribute emitter class is a nice way to separate the job of creating the attributes and the decisions of what attributes to use. *) The best way I could find of avoiding code duplication was to make getCurrentFragment and getOrCreateDataFragment public. If they must really be protected we can then create a special ARM streamer that has the same functionality as the attribute emitter in this patch. Yet another option is adding a method for writing over old data in the streamer API. *) I added support for multiple vendors, but that is no...

...roduce correct relocation records for my jump table with the below code, but am baffled to how to emit the text addresses to the data section. I'm sure it is just a few lines of code. Any suggestions? Jack void MCObjectStreamer::EmitGPRel32Value(const MCExpr *Value) { MCDataFragment *DF = getOrCreateDataFragment(); int Size = 4; // Assumption is that this is alway for 4 byte value DF->addFixup(MCFixup::Create(DF->getContents().size(), Value, FK_GPRel_4)); DF->getContents().resize(DF->getContents().size() + Size, 0); } ---...

On Fri, Jul 16, 2010 at 11:25 AM, Daniel Dunbar <daniel at zuster.org> wrote: > Hi Michael, > > Overall patch looks good. I do have a few comments below. My main > comment is please try to make the style match that used in the > MCMachOStreamer more closely. I intend to refactor more functionality > into the base MCObjectStreamer class, and having them use consistent >

---------- Forwarded message ---------- From: Jason Kim <jasonwkim at google.com> Date: Fri, Oct 22, 2010 at 12:59 PM Subject: Re: [llvm-commits] Fwd: Proof of concept patch for unifying the .s/ELF emission of .ARM.attributes To: Rafael Espíndola <rafael.espindola at gmail.com> On Fri, Oct 22, 2010 at 12:51 PM, Jason Kim <jasonwkim at google.com> wrote: > On Thu, Oct 21,

> Also what is the preferred method for MC way of setting out subsection > sizes after the fact? I am guessing I need to use an MCFixup? > How do I get an MCExpr to evaluate a method for the subsection size? > Is there an equivalent use in the places using MCFixup? > Do I need to add a new subclass to MCExpr for doing this? > > JimG, can you please comment on the MachO

...ment = new MCDataFragment(getSectionData()); There is no need to always create a new data fragment here; it is better to try and reuse the current fragment if possible. Take a look at MCMachOStreamer::EmitLabel for how I am doing this currently; I intend on moving some of the helper functions like getOrCreateDataFragment to the base class. > + > + getSymbolData(Symbol)->Fragment = Fragment; > + > + AddFragment(Fragment); > } > > void WinCOFFStreamer::EmitAssemblerFlag(MCAssemblerFlag Flag) { > @@ -91,10 +250,29 @@ void WinCOFFStreamer::EmitAssemblerFlag(MCAssemblerFlag Flag) { &g...

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer