search for: getnominalok

...ly, a "true" value in C is non-zero. In reading through the code quickly, I would assume that a variable "xyzOK" means that the value for "xyz" is OK/valid if the variable is non-zero. However, in drivers/riello_ser.c, line 749, several dstate values are set to zero if getnominalOK is true. I hate to sound picky, but this is open source - if you want anyone to contribute improvements back to the code, they need to be able to quickly understand what is going on. 2) I don't know that it makes sense to set the aforementioned values to zero if they cannot be read. If there...

...ly, a "true" value in C is non-zero. In reading through the code quickly, I would assume that a variable "xyzOK" means that the value for "xyz" is OK/valid if the variable is non-zero. However, in drivers/riello_ser.c, line 749, several dstate values are set to zero if getnominalOK is true. I hate to sound picky, but this is open source - if you want anyone to contribute improvements back to the code, they need to be able to quickly understand what is going on. 2) I don't know that it makes sense to set the aforementioned values to zero if they cannot be read. If there...

But the diff file that I'll now produce is related to the 3857 revision, so is also inclusive of previous changes (i.e. BYTE to uint8_t). Is it Ok for you? In alternatively could you modify the row (166 of riello_ser.c) of the file deleting the only cast that exist? Elio Parisi Centro Ricerche RPS SpA Viale Europa, 7 37045 Legnago VR Tel. +39 0442 635811 Fax. +39 0442 635934 Skype Id:

On Jul 5, 2013, at 5:44 AM, Elio Parisi wrote: > I tried to update sources (to eliminate the cast) with 'sudo svn update' but the response is: > > svn: No repository found in 'svn://svn.debian.org/nut/trunk' > > Can you verify svn server status? > > The code has been tested before and after the changes. The SVN server has been decommissioned as part of the