search for: getnnn

...y returns a NULL pointer? I would > think the later makes it a bit more friendly. Yes. It would be more friendly, probably. I can submit such a patch, if you think it suits better. On the other hand I want to mention the following pros: - assert-based approach follows the style of all other getNNN functions in LiveIntervalAnalysis.h. They all assert in out-of-range cases. - What does it mean, if you have a situation where you ask for the MBB of an instruction index, which is out of range for any MBB? How can this happen? If you know the index, then instruction should have been already regi...

...t;> think the later makes it a bit more friendly. > > Yes. It would be more friendly, probably. I can submit such a patch, > if > you think it suits better. > > On the other hand I want to mention the following pros: > - assert-based approach follows the style of all other getNNN > functions in LiveIntervalAnalysis.h. They all assert in out-of-range > cases. > - What does it mean, if you have a situation where you ask for the MBB > of an instruction index, which is out of range for any MBB? How can > this happen? If you know the index, then instruction should...

Thanks. One question though. Should getMBBFromIndex() assert if given an index out of the range or simply returns a NULL pointer? I would think the later makes it a bit more friendly. Evan On Feb 8, 2008, at 8:59 AM, Roman Levenstein wrote: > Hi Evan, > > Here is a patch for the LiveIntervalAnalysis that we discussed. > > --- Evan Cheng <evan.cheng at apple.com>

Hi Evan, Here is a patch for the LiveIntervalAnalysis that we discussed. --- Evan Cheng <evan.cheng at apple.com> schrieb: > > 1) What is the easiest way to understand which MBB a given > instruction index belongs to? All the required information is > available in the > > MBB2IdxMap of the LiveIntervalAnalysis class. Would it be useful > to add a small function