search for: getlogger

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

...+# Connect to the server. > > +connection = sdk.Connection( > > +    url = params['output_conn'], > > +    username = username, > > +    password = output_password, > > +    ca_file = params['rhv_cafile'], > > +    log = logging.getLogger(), > > +    insecure = True,        # XXX? > > > > > >ovirt-imageio authentication is based on the assumption that the > >secret random url is passed from engine  to the user via https. > >if this access engine using clear text then yes it is bad :-) > >...

...n(readonly): connection = sdk.Connection( url = params['output_conn'], - username = username, - password = password, + username = parse_username(), + password = read_password(), ca_file = params['rhv_cafile'], log = logging.getLogger(), insecure = params['insecure'], -- 2.21.0

...step in upload finalization, to shrink the image > size to optimal size. We are already doing this in several flows that > cannot estimate the final disk size and do over allocation. I guess we'll need something like that. > [snipped] > > > > > + log = logging.getLogger(), > > > > > + insecure = params['insecure'], > > > > > > > > > > If ca_file cannot be None, then insecure is not needed, based > > > on Ondra review from earlier version. > > > > Is this really true? My reading of th...

Hello, I am using dovecot 2.3.2 on my private email server in conjunction with: centos 7.5 apache 2.4.6 mariadb 10.2.16 roundcube mail 1.3.6 php 5.6.36 postfix 2.10.1 I have one mailbox with nearly 30k messages in it dispersed across several folders. it's often very slow in refreshing the message list, especially in the one largest 25k+ message folder. is this simply to be expected

...output_conn']) +username = parsed.username or "admin@internal" + +# Connect to the server. +connection = sdk.Connection( + url = params['output_conn'], + username = username, + password = output_password, + ca_file = params['rhv_cafile'], + log = logging.getLogger(), + insecure = params['insecure'], +) + +system_service = connection.system_service() +disks_service = system_service.disks_service() + +for uuid in params['disk_uuids']: + # Try to get and remove the disk, however do not fail + # if it does not exist (maybe removed in the...

...uot; > + > +# Connect to the server. > +connection = sdk.Connection( > +    url = params['output_conn'], > +    username = username, > +    password = output_password, > +    ca_file = params['rhv_cafile'], > +    log = logging.getLogger(), > +    insecure = True,        # XXX? > > > ovirt-imageio authentication is based on the assumption that the > secret random url is passed from engine  to the user via https. > if this access engine using clear text then yes it is bad :-) > > Ondra, can you explain...

...; + # Connect to the server. > + connection = sdk.Connection( > + url = params['output_conn'], > + username = username, > + password = password, > + ca_file = params['rhv_cafile'], > Can this be None? > + log = logging.getLogger(), > + insecure = params['insecure'], > If ca_file cannot be None, then insecure is not needed, based on Ondra review from earlier version. [snipped] > + # Create the disk. > + disks_service = system_service.disks_service() > + if params['disk_format...

...e the size and you must allocate the entire image, we can add a shrink step in upload finalization, to shrink the image size to optimal size. We are already doing this in several flows that cannot estimate the final disk size and do over allocation. [snipped] > > > + log = logging.getLogger(), > > > + insecure = params['insecure'], > > > > > > > If ca_file cannot be None, then insecure is not needed, based > > on Ondra review from earlier version. > > Is this really true? My reading of the code is that the insecure flag > ve...

...ername or "admin@internal" > + > +# Connect to the server. > +connection = sdk.Connection( > + url = params['output_conn'], > + username = username, > + password = output_password, > + ca_file = params['rhv_cafile'], > + log = logging.getLogger(), > + insecure = True, # XXX? > ovirt-imageio authentication is based on the assumption that the secret random url is passed from engine to the user via https. if this access engine using clear text then yes it is bad :-) Ondra, can you explain the semantics of incsecure=True?...

...output_conn']) +username = parsed.username or "admin@internal" + +# Connect to the server. +connection = sdk.Connection( + url = params['output_conn'], + username = username, + password = output_password, + ca_file = params['rhv_cafile'], + log = logging.getLogger(), + insecure = params['insecure'], +) + +system_service = connection.system_service() + +# Find if a virtual machine already exists with that name. +vms_service = system_service.vms_service() +vms = vms_service.list( + search = ("name=%s" % params['output_name']), +...

...39;output_conn'], > > + username = username, > > + password = password, > > + ca_file = params['rhv_cafile'], > > > > Can this be None? We could allow that, but in the current code it must be present. > > + log = logging.getLogger(), > > + insecure = params['insecure'], > > > > If ca_file cannot be None, then insecure is not needed, based > on Ondra review from earlier version. Is this really true? My reading of the code is that the insecure flag verifies the server to the client, where...

Mainly minor fixes and code cleanups over the v4 patch. There are still several problems with this patch, but it is in a reviewable state, especially the Python code. Rich.

...output_conn']) +username = parsed.username or "admin@internal" + +# Connect to the server. +connection = sdk.Connection( + url = params['output_conn'], + username = username, + password = output_password, + ca_file = params['rhv_cafile'], + log = logging.getLogger(), + insecure = True, # XXX? +) + +system_service = connection.system_service() + +# Get the storage domain UUID and substitute it into the OVF doc. +sds_service = system_service.storage_domains_service() +sd = sds_service.list(search=("name=%s" % params['output_storage'...

...the entire > image, we can add a shrink step in upload finalization, to shrink the image > size to optimal size. We are already doing this in several flows that > cannot estimate the final disk size and do over allocation. > > [snipped] > >> > > + log = logging.getLogger(), >> > > > + insecure = params['insecure'], >> > > >> > >> > If ca_file cannot be None, then insecure is not needed, based >> > on Ondra review from earlier version. >> >> Is this really true? My reading of the code...

...ername or "admin@internal" > + > +# Connect to the server. > +connection = sdk.Connection( > + url = params['output_conn'], > + username = username, > + password = output_password, > + ca_file = params['rhv_cafile'], > + log = logging.getLogger(), > + insecure = True, # XXX? > +) > + > +system_service = connection.system_service() > + > +# Get the storage domain UUID and substitute it into the OVF doc. > +sds_service = system_service.storage_domains_service() > +sd = sds_service.list(search=("name=%s...

v5 was here: https://www.redhat.com/archives/libguestfs/2018-March/msg00032.html There is only a single patch in this version because the other patches went upstream. This patch adds the virt-v2v -o rhv-upload mode (https://bugzilla.redhat.com/show_bug.cgi?id=1557273). Compared to v5, this adds the ability to make zero, trim and flush requests to the oVirt imageio server

...output_conn']) +username = parsed.username or "admin@internal" + +# Connect to the server. +connection = sdk.Connection( + url = params['output_conn'], + username = username, + password = output_password, + ca_file = params['rhv_cafile'], + log = logging.getLogger(), + insecure = params['insecure'], +) + +system_service = connection.system_service() + +# Get the storage domain UUID and substitute it into the OVF doc. +sds_service = system_service.storage_domains_service() +sd = sds_service.list(search=("name=%s" % params['output_stor...

...output_conn']) +username = parsed.username or "admin@internal" + +# Connect to the server. +connection = sdk.Connection( + url = params['output_conn'], + username = username, + password = output_password, + ca_file = params['rhv_cafile'], + log = logging.getLogger(), + insecure = params['insecure'], +) + +system_service = connection.system_service() + +# Get the storage domain UUID and substitute it into the OVF doc. +sds_service = system_service.storage_domains_service() +sd = sds_service.list(search=("name=%s" % params['output_stor...

v7 was here: https://www.redhat.com/archives/libguestfs/2018-March/msg00143.html Since then: - Earlier patches are now upstream. - The to-do list is moved from the commit message to the TODO file. - This version forces -of raw + -oa sparse and gives an error in any other mode. We intend to lift these restrictions later. - Tested against latest imageio which supports longer timeouts,