search for: getlinkageresult

On Mon, Mar 1, 2010 at 4:52 AM, Garrison Venn <gvenn.cfe.dev at gmail.com> wrote: > I do have one question though. After having done the fix and the appropriate unit tests, > does one still need to add to the tests suite for the testing bots, and add to test for make > check (for this kind of bug fix)? Do the unittests somehow get invoked by make check? I > guess I don't

...ferring to? Ah, I was confused. You're right, getLazyFunctionStub is the badly-named function you want. You currently have nearly the same loop in getOrEmitGlobalVariable() and getPointerToFunction(). Can you unify those, perhaps by making them searches for GlobalValues with getNamedValue()? GetLinkageResult() in lib/Linker/LinkModules.cpp has a lot of logic about choosing a function based on its linkage. You should read that to figure out how to filter GVs with various linkages in your search. Please add some tests for cross-module JITting. You'll find some of the functions defined in unittests/E...

...ould you give me a link? On Feb 26, 2010, at 21:17, Jeffrey Yasskin wrote: > > You currently have nearly the same loop in getOrEmitGlobalVariable() > and getPointerToFunction(). Can you unify those, perhaps by making > them searches for GlobalValues with getNamedValue()? > > GetLinkageResult() in lib/Linker/LinkModules.cpp has a lot of logic > about choosing a function based on its linkage. You should read that > to figure out how to filter GVs with various linkages in your search. When I'm able to write a unit test, I'll re-submit a patch which will contain a JIT functi...

Hi Jeffrey, On Feb 26, 2010, at 16:02, Jeffrey Yasskin wrote: > [sidenote: Please try to avoid extraneous whitespace and line wrapping changes in your patches. It makes it harder to see what you're actually changing] Sorry just saw some preexisting code was not in 80 columns. > > On Fri, Feb 26, 2010 at 4:57 AM, Garrison Venn <gvenn.cfe.dev at gmail.com> wrote: > Hi

[sidenote: Please try to avoid extraneous whitespace and line wrapping changes in your patches. It makes it harder to see what you're actually changing] On Fri, Feb 26, 2010 at 4:57 AM, Garrison Venn <gvenn.cfe.dev at gmail.com>wrote: > Hi Olivier, > > On Feb 25, 2010, at 14:10, Olivier Meurant wrote: > > Hi Garrison, > > I finally come back from holidays and take