search for: getindexedvalu

...below are methods in StructType and SequentialType. Regardless of any limitations posed by a GEP instruction, I argue that "i8 2" is a perfectly valid index for a struct. The fact that it is not valid for a GEP instruction, should be checked somewhere else (GEPInst constructor or GEPInst::getIndexedValue probably). The last method in the patch is directly related to GEP indices, so asserting only the constness might not be enough, though it would not hurt to make this assert slightly more general (ie, don't check the bitwidth as well). Gr. Matthijs -------------- next part -------------- A...

On Jul 10, 2008, at 12:26 PM, Matthijs Kooijman wrote: > Regardless of any limitations posed by a GEP instruction, I > argue that "i8 2" is a perfectly valid index for a struct. Why? What value does that provide? Struct indices are not allowed to be variable, so picking any width constant (that isn't too small) is fine. What problem are you trying to solve here? -Chris

I don't think this is right. According to llvm documentation: The index types specified for the 'getelementptr' instruction depend on the pointer type that is being indexed into. Pointer and array types can use a 32-bit or 64-bit integer type but the value will always be sign extended to 64-bits. Structure and packed structure types require i32 constants. Evan On Jul 10,

...gt; SequentialType. Regardless of any limitations posed by a GEP instruction, > > I argue that "i8 2" is a perfectly valid index for a struct. The fact > > that it is not valid for a GEP instruction, should be checked somewhere > > else (GEPInst constructor or GEPInst::getIndexedValue probably). > That's what the documentation is saying though. Struct and packed > structure types require i32 constants. Perhaps I am misunderstanding > something? Ah, I did miss the "only 32 bit" limitation for structs, which makes my current argpromotion fix wrong. Howe...

Hi all, any comments about this patch? I'd like to get it out of my working copy :-) Gr. Matthijs > Index: lib/VMCore/Type.cpp > =================================================================== > --- lib/VMCore/Type.cpp (revision 53136) > +++ lib/VMCore/Type.cpp (working copy) > @@ -394,9 +394,8 @@ > > bool StructType::indexValid(const Value *V) const { >