search for: getedg

...? > + // getFunction() - Returns the Function for an Edge, checking for validity. > + static const Function* getFunction(Edge e) { > + assert(e.second && "Invalid ProfileInfo::Edge"); > + return e.second->getParent(); > + } > + > + // getEdge() - Creates an Edge from two BasicBlocks. > + static Edge getEdge(const BasicBlock* Src, const BasicBlock* Dest) { > + return std::make_pair(Src,Dest); > + } I think these should be private; eventually they are just an implementation detail of a particular ProfileInfo provider...

...ion() - Returns the Function for an Edge, checking for validity. >> + static const Function* getFunction(Edge e) { >> + assert(e.second && "Invalid ProfileInfo::Edge"); >> + return e.second->getParent(); >> + } >> + >> + // getEdge() - Creates an Edge from two BasicBlocks. >> + static Edge getEdge(const BasicBlock* Src, const BasicBlock* Dest) { >> + return std::make_pair(Src,Dest); >> + } > > I think these should be private; eventually they are just an > implementation detail of a part...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Dunbar wrote: > Thanks, applied as r78247. Next? :) Oh my, first he is lagging and now it's all a hurry :-) Okay, here comes the next one. I'm taking a short vacation next week so I will try to prepare 1 or 2 of the next patches so that you can work on them as you have time. Greetings, Andi - --

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi! Andreas Neustifter wrote: > Daniel Dunbar wrote: >> Thanks, applied as r78247. Next? :) > > Oh my, first he is lagging and now it's all a hurry :-) > > Okay, here comes the next one. > > I'm taking a short vacation next week so I will try to prepare 1 or 2 of > the next patches so that you can work on them

https://bugs.freedesktop.org/show_bug.cgi?id=90887 Bug ID: 90887 Summary: PhiMovesPass in register allocator broken Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/DRI/nouveau Assignee: nouveau at