search for: getdecodedlinkag

On Tue, Apr 4, 2017 at 12:36 PM, Duncan P. N. Exon Smith < dexonsmith at apple.com> wrote: > > On 2017-Apr-04, at 12:12, Peter Collingbourne <peter at pcc.me.uk> wrote: > > On Mon, Apr 3, 2017 at 8:13 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Apr 3, 2017, at 7:08 PM, Peter Collingbourne <peter at pcc.me.uk> wrote: >>

...ve tried to update the text to do that. > + bool isThreadLocal() const { return threadLocalMode; } > > Add a != NotThreadLocal to make it explicit. Done. > +    default: // Map unknown non-zero value to default. > > Why? Lots of other functions in the file do this, for example GetDecodedLinkage and GetDecodedVisibility. > +/// Get the IR-specified TLS model for GV, or GeneralDynamic if no model > +/// was selected. > > This comment is out of date, no? Updated. > +  return TLSModel::GeneralDynamic; > > And this return is dead, you can use llvm_unreachable. It'...

> If we don't want to do that, I think we should try to add the new > constructors while keeping the old ones around, and then delete the > old constructors once clang is updated. Yes, this would probably be the best. To make clang build I just hacked the constructors in the patch I posted, but they should really just forward to the new ones. >> *) Please name the most general

...> * initialexec: Will not be loaded dynamically. > * localexec: Will be in the executable and is only used from it. is probably OK. >> +    default: // Map unknown non-zero value to default. >> >> Why? > > Lots of other functions in the file do this, for example > GetDecodedLinkage and GetDecodedVisibility. That is peculiar, but you are right, it is better be consistent. > >> +  return TLSModel::GeneralDynamic; >> >> And this return is dead, you can use llvm_unreachable. > > It's not dead when GV isn't a GlobalVariable. (I'm not sure...