Displaying 3 results from an estimated 3 matches for "getcurrentsectiondata".
2010 Jul 17
1
[LLVMdev] Win32 COFF Support - Patch 3
On Fri, Jul 16, 2010 at 11:25 AM, Daniel Dunbar <daniel at zuster.org> wrote:
> Hi Michael,
>
> Overall patch looks good. I do have a few comments below. My main
> comment is please try to make the style match that used in the
> MCMachOStreamer more closely. I intend to refactor more functionality
> into the base MCObjectStreamer class, and having them use consistent
>
2010 Jul 16
0
[LLVMdev] Win32 COFF Support - Patch 3
...ectionData(MCSection const *Section) {
This function has two very different behaviors, one is to create the section
data for a particular section, the other is to get the section data for the
current section. Please remove the second use (assert Section != 0 if you like),
and use MCObjectStreamer::getCurrentSectionData() for that instead.
> + bool SectionDataCreated;
> +
> + assert((Section != 0) || (CurSection != 0) && "Must have a valid section!");
> +
> + MCSectionData *SectionData = &getAssembler().getOrCreateSectionData(
> + *(Secti...
2010 Jul 14
2
[LLVMdev] Win32 COFF Support - Patch 3
On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote:
> This probably needs to be slightly tweaked to work with mainline. I don't see anything objectionable, but I think Daniel needs to review this one.
Updated patch to work with mainline.
http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94
- Michael Spencer