search for: getcurdebugloc

...> Micah, > > There are a number of variable names in this patch that don't follow > the naming convention (which specifies that they should start with an > uppercase letter). > > > if (PtrBits < 64) > > - OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > - TLI.getPointerTy(), > > + OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > PtrTy, DAG.getConstant(Offs, MVT::i64)); > > This is not necessarily specific to your patch, but can you explain the > special role of 64...

Micah, There are a number of variable names in this patch that don't follow the naming convention (which specifies that they should start with an uppercase letter). > if (PtrBits < 64) > - OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > - TLI.getPointerTy(), > + OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > PtrTy, DAG.getConstant(Offs, MVT::i64)); This is not necessarily specific to your patch, but can you explain the special role of 64-bits here? Thanks again, Hal...

> -----Original Message----- > From: Villmow, Micah > Sent: Friday, August 24, 2012 2:56 PM > To: 'Eli Friedman' > Cc: LLVM Developers Mailing List > Subject: RE: [LLVMdev] RFC: Supporting different sized address space > arithmetic > > Eli, > There is a patch that implements the beginning what I think is the > correct approach to support the backend

...here are a number of variable names in this patch that don't follow > > the naming convention (which specifies that they should start with > > an uppercase letter). > > > > > if (PtrBits < 64) > > > - OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > > - TLI.getPointerTy(), > > > + OffsVal = DAG.getNode(ISD::TRUNCATE, getCurDebugLoc(), > > > PtrTy, DAG.getConstant(Offs, MVT::i64)); > > > > This is not necessarily specific to your patch, but can you explain &g...

....getPointerTy(dyn_cast<PointerType>( + SV->getType())->getAddressSpace()); + if (PtrVT != NewPtrVT) { + // Check to see if we want to change the size of the pointer + // based on the address space and if so extend or truncate the pointer. + Ptr = DAG.getSExtOrTrunc(Ptr, getCurDebugLoc(), NewPtrVT); + PtrVT = NewPtrVT; + } This situation should be impossible: you're checking whether a pointer has the same type as itself. If you're hitting this, it's just a symptom of a bug elsewhere. The same applies to other places you perform this sort of check outside of &qu...

...terType>( > + SV->getType())->getAddressSpace()); > + if (PtrVT != NewPtrVT) { > + // Check to see if we want to change the size of the pointer > + // based on the address space and if so extend or truncate the > pointer. > + Ptr = DAG.getSExtOrTrunc(Ptr, getCurDebugLoc(), NewPtrVT); > + PtrVT = NewPtrVT; > + } > > This situation should be impossible: you're checking whether a pointer > has the same type as itself. If you're hitting this, it's just a > symptom of a bug elsewhere. The same applies to other places you > perfor...