search for: getbitsneeded

I'm breaking this out from LLVM asserts thread. Here are all the assertions in APInt I consider should be recoverable: APInt::APInt: bitwidth too small Null pointer detected! APInt::getBitsNeeded: Invalid string length string is only a minus! Invalid radix APInt::fromString: Radix should be 2, 8, 10, or 16! Invalid string length string is only a minus Insufficient bit width Invalid digit in string for given radix APInt::toString: "Radix should be 2, 8, 10, or 16! For the recoverabl...

...invariants that the caller can check if needbe. Making the implementation check these will slow down clients which are known to be well formed. I didn't look at all of the things you listed, perhaps some other ones would make some more to be recoverable errors. -Chris > > APInt::getBitsNeeded: > Invalid string length > string is only a minus! > Invalid radix > > APInt::fromString: > Radix should be 2, 8, 10, or 16! > Invalid string length > string is only a minus > Insufficient bit width > Invalid digit in string for given radix > > APInt::toString: &...

On Jan 20, 2009, at 1:22 AM, Jay Foad wrote: >>> I realise that the DataTypes.h.in part might be controversial. Also, >>> there's probably a better place to put it, but I'm not sure where. >> >> I didn't apply this part. What problems does it cause to not have >> this? Can we fix uses of max and min? > > I could try to fix this by changing

>> I realise that the DataTypes.h.in part might be controversial. Also, >> there's probably a better place to put it, but I'm not sure where. > > I didn't apply this part. What problems does it cause to not have > this? Can we fix uses of max and min? I get these errors in lib: .../lib/Analysis/ValueTracking.cpp:162: error: no matching function for call to