search for: getabbrev

> On 2015 May 20, at 17:51, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote: > > >> On 2015 May 20, at 17:39, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote: >> >> With just those four patches, memory usage went *up* slightly. Add in >> the 5th patch (which does #2 below), and we get an overall memory drop >> of 4%. > >

...d contain a `dwarf::Form` and `dwarf::Attribute`. In total, `sizeof(DIEValue)` will still be just two pointers (1st pointer: discriminator, Form, and Attribute; 2nd pointer: data). DIE should stop storing a `DIEAbbrev` itself, instead constructing one on demand, renaming `DIE::getAbbrev()` to `DIE::getOrCreateAbbrev(FoldingSet<DIEAbbrev>&)` or some such. 3. DIE's list of DIEValues is currently a `SmallVector<, 12>`, but a histogram Pete ran shows that half of DIEs have 2 or fewer values, and 85% have 4 or fewer values. We're paying for 12 (!)...

...` and `dwarf::Attribute`. In total, `sizeof(DIEValue)` >> will still be just two pointers (1st pointer: discriminator, Form, >> and Attribute; 2nd pointer: data). DIE should stop storing a >> `DIEAbbrev` itself, instead constructing one on demand, renaming >> `DIE::getAbbrev()` to >> `DIE::getOrCreateAbbrev(FoldingSet<DIEAbbrev>&)` or some such. >> 3. DIE's list of DIEValues is currently a `SmallVector<, 12>`, but a >> histogram Pete ran shows that half of DIEs have 2 or fewer values, >> and 85% have 4 or fewer values....