search for: get_vq_state

On 2020/7/20 ??3:14, Eli Cohen wrote: > Modify get_vq_state() so it returns an error code. In case of hardware > acceleration, the available index may be retrieved from the device, an > operation that can possibly fail. > > Reviewed-by: Parav Pandit <parav at mellanox.com> > Signed-off-by: Eli Cohen <eli at mellanox.com> Acked-b...

On 2020/8/5 ??12:20, Eli Cohen wrote: > Modify get_vq_state() so it returns an error code. In case of hardware > acceleration, the available index may be retrieved from the device, an > operation that can possibly fail. > > Reviewed-by: Parav Pandit <parav at mellanox.com> > Signed-off-by: Eli Cohen <eli at mellanox.com> Acked-b...

On 2020/7/16 ??3:23, Eli Cohen wrote: > Currently, get_vq_state() is used only to pass the available index value > of a vq. Extend the struct to return status on the VQ to the caller. > For now, define VQ_STATE_NOT_READY. In the future it will be extended to > include other infomration. > > Modify current vdpa driver to update this field. > &g...

On 2020/7/16 ??4:21, Eli Cohen wrote: > On Thu, Jul 16, 2020 at 04:11:00PM +0800, Jason Wang wrote: >> On 2020/7/16 ??3:23, Eli Cohen wrote: >>> Currently, get_vq_state() is used only to pass the available index value >>> of a vq. Extend the struct to return status on the VQ to the caller. >>> For now, define VQ_STATE_NOT_READY. In the future it will be extended to >>> include other infomration. >>> >>> Modify current v...

...16 ??6:25, Eli Cohen wrote: > On Thu, Jul 16, 2020 at 05:35:18PM +0800, Jason Wang wrote: >> On 2020/7/16 ??4:21, Eli Cohen wrote: >>> On Thu, Jul 16, 2020 at 04:11:00PM +0800, Jason Wang wrote: >>>> On 2020/7/16 ??3:23, Eli Cohen wrote: >>>>> Currently, get_vq_state() is used only to pass the available index value >>>>> of a vq. Extend the struct to return status on the VQ to the caller. >>>>> For now, define VQ_STATE_NOT_READY. In the future it will be extended to >>>>> include other infomration. >>>>&g...

On Thu, Oct 17, 2019 at 06:48:34PM +0800, Jason Wang wrote: > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...vdpa_device *vdpa_dev) { return IFCVF_QUEUE_ALIGNMENT; } diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index 72863d01a12a..7957d2d41fc4 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -435,7 +435,7 @@ static u64 vdpasim_get_vq_state(struct vdpa_device *vdpa, u16 idx) return vrh->last_avail_idx; } -static u16 vdpasim_get_vq_align(struct vdpa_device *vdpa) +static u32 vdpasim_get_vq_align(struct vdpa_device *vdpa) { return VDPASIM_QUEUE_ALIGN; } diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h index 733acfb7e...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...y the virtqueue to "not ready". Is this a hardware limitation of software one? I'm asking since we need support live migration. But a questions is how to stop the device but not reset, since we need get e.g last_avail_idx from the device. It could be either: 1) set_status(0) 2) get_vq_state() or 1) set_queue_ready(0) 2) get_vq_state() Set_status(0) means reset the virtio device but last_avail_idx is something out of virtio spec. I guess using set_queue_ready() is better. What's you opinion? Thanks > The > only option is to destroy it and create a new one. This mean...

...gt; > + * @set_vq_state: Set the state for a virtqueue > > > + * @mdev: mediated device > > > + * @idx: virtqueue index > > > + * @state: virtqueue state (last_avail_idx) > > > + * Returns integer: success (0) or error (< 0) > > > + * @get_vq_state: Get the state for a virtqueue > > > + * @mdev: mediated device > > > + * @idx: virtqueue index > > > + * Returns virtqueue state (last_avail_idx) > > > + * @get_vq_align: Get the virtqueue align requirement > > > + * for the device > &g...

...gt; > + * @set_vq_state: Set the state for a virtqueue > > > + * @mdev: mediated device > > > + * @idx: virtqueue index > > > + * @state: virtqueue state (last_avail_idx) > > > + * Returns integer: success (0) or error (< 0) > > > + * @get_vq_state: Get the state for a virtqueue > > > + * @mdev: mediated device > > > + * @idx: virtqueue index > > > + * Returns virtqueue state (last_avail_idx) > > > + * @get_vq_align: Get the virtqueue align requirement > > > + * for the device > &g...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...; > } > > static const struct vdpa_config_ops vdpasim_config_ops = { > @@ -704,6 +765,8 @@ static const struct vdpa_config_ops vdpasim_config_ops = { > .get_vq_ready = vdpasim_get_vq_ready, > .set_vq_state = vdpasim_set_vq_state, > .get_vq_state = vdpasim_get_vq_state, > + .get_vq_notification = vdpasim_get_vq_notification, > + .get_vq_notification_pgprot = vdpasim_get_vq_notification_pgprot, > .get_vq_align = vdpasim_get_vq_align, > .get_vq_group = vdpasim_get_vq_gro...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...; + * Returns boolean: ready (true) or not (false) > + * @set_vq_state: Set the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * @state: virtqueue state (last_avail_idx) > + * Returns integer: success (0) or error (< 0) > + * @get_vq_state: Get the state for a virtqueue > + * @mdev: mediated device > + * @idx: virtqueue index > + * Returns virtqueue state (last_avail_idx) > + * @get_vq_align: Get the virtqueue align requirement > + * for the device > + * @mdev: mediated device > + * Returns vi...

...gt; Initially I was thinking of adding the same tag used here: > > Fixes: 4c8cf31885f6 ("vhost: introduce vDPA-based backend") > > Then I discovered that vq_state wasn't there, so I was thinking of > > Fixes: 530a5678bc00 ("vdpa: support packed virtqueue for set/get_vq_state()") > > So we would have to backport quite a few patches into the stable branches. > I don't know if it's worth it... > > I still think it is better to disable packed in the stable branches, > otherwise I have to make a list of all the patches we need. > > Any o...

...ce + * @idx: virtqueue index + * Returns boolean: ready (true) or not (false) + * @set_vq_state: Set the state for a virtqueue + * @mdev: mediated device + * @idx: virtqueue index + * @state: virtqueue state (last_avail_idx) + * Returns integer: success (0) or error (< 0) + * @get_vq_state: Get the state for a virtqueue + * @mdev: mediated device + * @idx: virtqueue index + * Returns virtqueue state (last_avail_idx) + * @get_vq_align: Get the virtqueue align requirement + * for the device + * @mdev: mediated device + * Returns virtqueue algin requirement + * @get_...