search for: get_target_formats

...rmat will also not > work. *) > > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ > > This is going to break all the other output modes. > > You probably want to define a new method output#override_output_format > (see v2v.ml:get_target_formats and types.mli). > Maybe outpu#tranfer_format? Return output_format by default, rhv_output will override it to return raw? > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat > http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://r...

When using oVirt >= 4.3, we can enable the NBD based backend in imageio by specifying that we transfer raw data when creating a transfer. With the NBD backend, we can specify qcow2 disk format. I think we need a way to expose the capabilities of the output to the user. For example, can we use qcow2 format. Issues: - I hacked qemu-img convert command line to always use -O raw instead of

...s the disk format. commpressed format will also not work. *) > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ This is going to break all the other output modes. You probably want to define a new method output#override_output_format (see v2v.ml:get_target_formats and types.mli). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported....

...*) > > > + [ "-n"; "-f"; "qcow2"; "-O"; "raw" ] @ > > > > This is going to break all the other output modes. > > > > You probably want to define a new method output#override_output_format > > (see v2v.ml:get_target_formats and types.mli). > > > > Maybe outpu#tranfer_format? > Return output_format by default, rhv_output will override it to return raw? Isn't that essentially what #override_output_format virtual method does already? Rich. -- Richard Jones, Virtualization Group, Red Hat http://peo...

...ssignment source guestcaps in @@ -487,8 +495,6 @@ and do_fstrim g inspect = * sdb final estimate size = 3 - (3*1.35/4) = 1.9875 GB *) and estimate_target_size mpstats overlays = - let sum = List.fold_left (+^) 0L in - (* (1) *) let fs_total_size = sum ( @@ -617,6 +623,25 @@ and get_target_formats cmdline output overlays = format ) overlays +and print_estimate overlays = + let estimates = + List.map ( + fun { ov_overlay_file } -> + Measure_disk.measure ~format:"qcow2" ov_overlay_file + ) overlays in + let total = sum estimates in + + match machin...

...ssignment source guestcaps in @@ -487,8 +495,6 @@ and do_fstrim g inspect = * sdb final estimate size = 3 - (3*1.35/4) = 1.9875 GB *) and estimate_target_size mpstats overlays = - let sum = List.fold_left (+^) 0L in - (* (1) *) let fs_total_size = sum ( @@ -617,6 +623,25 @@ and get_target_formats cmdline output overlays = format ) overlays +and print_estimate overlays = + let estimates = + List.map ( + fun { ov_overlay_file } -> + Measure_disk.measure ~format:"qcow2" ov_overlay_file + ) overlays in + let total = sum estimates in + + match machin...

v6: - Make the text output a bit nicer. - Changes as suggested to Measure_disk module temp file & json parsing. - Use jq to test JSON output. - Retest.

...e) the target file. The [(string * overlay list)] parameter is a list of the (format, overlay) for each target disk. If diff --git a/v2v/v2v.ml b/v2v/v2v.ml index dc1dedd7..9fd63442 100644 --- a/v2v/v2v.ml +++ b/v2v/v2v.ml @@ -173,7 +173,8 @@ let rec main () = let target_formats = get_target_formats cmdline output overlays in let target_files = output#prepare_targets source.s_name - (List.combine target_formats overlays) in + (List.combine target_formats overlays) + guestcaps in List.map ( fun (target_file, target_format,...

v5: - Normal output modified approx as suggested in previous email. - Machine readable output uses JSON.