search for: get_streams_from_channel

thanks for all your feedback. here's the revised patch: On Wed, Oct 11, 2017 at 2:20 PM Timothy B. Terriberry <tterribe at xiph.org> wrote: > Jean-Marc Valin wrote: > > I think you'll want something like: > > (opus_int16)((unsigned)demixing_matrix[2*i+1] << 8) > > (though you might want to check it too) > > FWIW, we use the construct > int s =

...ere. Did I miss something? > Gain should be pulled out by the user via a OPUS_PROJECTION_GET_DEMIXING_MATRIX_GAIN call and add it to the overall output gain. We assume the mixing matrix gain is always zero and that this only matters for the output gain from the demixing matrix. > > 9) In get_streams_from_channels(), I think it'd be simpler to just replace: > *streams = channels / 2 + (channels % 2 == 1); > with: > *streams = (channels+1) / 2; > Done. > > 10) In opus_projection_ambisonics_encoder_init(), you to see if streams > and coupled_streams are NULL, but unless I missed some...

...out by the user via > > a OPUS_PROJECTION_GET_DEMIXING_MATRIX_GAIN call and add it to the > > overall output gain. We assume the mixing matrix gain is always zero and > > that this only matters for the output gain from the demixing matrix. > > > > > > 9) In get_streams_from_channels(), I think it'd be simpler to just > > replace: > > *streams = channels / 2 + (channels % 2 == 1); > > with: > > *streams = (channels+1) / 2; > > > > Done. > > > > > > 10) In opus_projection_ambisonics_encoder_init(), yo...

...mapping_matrix_multiply_float(), the return value isn't checked. So it should either be replaced by an asssert or (if the user can cause a failure) actually checked. 8) I see there's a "gain" field in the matrix, but I can't see it used anywhere. Did I miss something? 9) In get_streams_from_channels(), I think it'd be simpler to just replace: *streams = channels / 2 + (channels % 2 == 1); with: *streams = (channels+1) / 2; 10) In opus_projection_ambisonics_encoder_init(), you to see if streams and coupled_streams are NULL, but unless I missed something I don't think there's any v...

...> Gain should be pulled out by the user via > a  OPUS_PROJECTION_GET_DEMIXING_MATRIX_GAIN call and add it to the > overall output gain. We assume the mixing matrix gain is always zero and > that this only matters for the output gain from the demixing matrix. > > > 9) In get_streams_from_channels(), I think it'd be simpler to just > replace: > *streams = channels / 2 + (channels % 2 == 1); > with: > *streams = (channels+1) / 2; > > Done.  > > > 10) In opus_projection_ambisonics_encoder_init(), you to see if streams > and coupled_...

...output gain. We assume the mixing matrix gain is > always > >     zero and > >     > that this only matters for the output gain from the > demixing matrix. > >     > > >     > > >     >     9) In get_streams_from_channels(), I think it'd be > simpler to just > >     >     replace: > >     >     *streams = channels / 2 + (channels % 2 == 1); > >     >     with: > >     >     *streams = (channels+1) / 2; > >     > >...

...; > > > that this only matters for the output gain > > from the > > > demixing matrix. > > > > > > > > > > > > > > > 9) In get_streams_from_channels(), I think > > it'd be > > > simpler to just > > > > > replace: > > > > > *streams = channels / 2 + (channels % 2 == > 1); > > > > > wi...

...   >     zero and > >         >     > that this only matters for the output gain > from the > >         demixing matrix. > >         >     > > >         >     > > >         >     >     9) In get_streams_from_channels(), I think > it'd be > >         simpler to just > >         >     >     replace: > >         >     >     *streams = channels / 2 + (channels % 2 == 1); > >         >     >     with: > >         ...

...> > that this only matters for the output gain >> > from the >> > > demixing matrix. >> > > > > >> > > > > >> > > > > 9) In get_streams_from_channels(), I think >> > it'd be >> > > simpler to just >> > > > > replace: >> > > > > *streams = channels / 2 + (channels % 2 >> == 1); >> > >...

...e > output gain > >         from the > >         >         demixing matrix. > >         >         >     > > >         >         >     > > >         >         >     >     9) In > get_streams_from_channels(), I think > >         it'd be > >         >         simpler to just > >         >         >     >     replace: > >         >         >     >     *streams = channels / 2 + > (channels % 2 == 1); >...