search for: get_socket_address

...e_ipaddr(), get_remote_port(), get_local_ipaddr(packet_get_connection_in()), get_local_port()); After poking around, it seems that: 1) get_local_ipaddr returns NULL 2) this NULL is passed to snprintf 3) which dereferences the NULL causing a SEGV (get_local_ipaddr returns NULL because it calls get_socket_address which calls getpeername on a non-socket.) The NULL doesn't seem to bother snprintf on Linux or HP-UX. I don't know if it's valid to pass a NULL as an argument to "%s". The attached patch fixes this problem but introduces more inconsistency into the get_[local|remote|peer]_[i...

On Thu, 26 Feb 2015, Darren Tucker wrote: > I noticed this error log spam on the tinderbox when looking at one of the > failures. It happens with Unix domain socket forwarding is requested: > > debug1: channel 1: new [forwarded-streamlocal at openssh.com] > get_socket_address: getnameinfo 1 failed: ai_family not supported > get_sock_port: getnameinfo NI_NUMERICSERV failed: ai_family not supported That's strange, because we do: if (addr.ss_family == AF_UNIX) { /* Get the Unix domain socket path. */ return xstrdup(((struct...

...'t occur with OpenSSH 6.4p1. Here's an example: $ ssh machine1 -W machine2:22 getsockname failed: Bad file descriptor SSH-2.0-OpenSSH_6.1 The error message is a result of getsockname being called with a file descriptor -1. The call stack at the time looks like this: Breakpoint 2, get_socket_address (sock=-1, remote=remote at entry=0, flags=flags at entry=2) at /usr/src/debug/openssh-6.5p1-1/canohost.c:256 256 if (getsockname(sock, (struct sockaddr *)&addr, &addrlen) (gdb) bt #0 get_socket_address (sock=-1, remote=remote at entry=0, flags=flags at entry=2)...

...environment (the opposite of SSH_CLIENT). The variable is called SSH_LOCAL. -Eric -------------- next part -------------- *** openssh-2.9.9p2/canohost.c.bak Sun Jun 24 22:01:24 2001 --- openssh-2.9.9p2/canohost.c Fri Oct 12 16:52:09 2001 *************** *** 255,260 **** --- 255,281 ---- return get_socket_address(socket, 0, NI_NAMEREQD); } + const char * + get_local_ipaddr2(void) + { + static char *canonical_host_ip = NULL; + + /* Check whether we have cached the ipaddr. */ + if (canonical_host_ip == NULL) { + if (packet_connection_is_on_socket()) { + canonical_host_ip = + get_local_ipa...

...or fd ssh_keysign: no reply key_sign failed This is due to the assumption that the file descriptor passed to get_local_name() corresponds to a socket, which is not the case when a proxy command is used. The attached patch modifies get_local_name() sot that it falls back to using gethostname() if get_socket_address() fails. As a result, some redundant code in sshconnect2.c is removed. A typo is sshconnect2.c is also fixed. ('no installed' vs 'not installed') -- Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are...

...= AF_BLUETOOTH) { + struct sockaddr_rc *from_rc = (void *)&from; + char ba[28]; + + sprintf(ba, "Bluetooth:"); + ba2str(&from_rc->rc_bdaddr, ba + 10); + return xstrdup(ba); + } +#endif if (from.ss_family == AF_INET) check_ip_options(sock, ntop); @@ -264,6 +279,16 @@ get_socket_address(int sock, int remote, return NULL; } +#ifdef HAVE_BLUETOOTH + if (addr.ss_family == AF_BLUETOOTH) { + struct sockaddr_rc *from_rc = (void *)&addr; + char ba[28]; + + sprintf(ba, "Bluetooth:"); + ba2str(&from_rc->rc_bdaddr, ba + 10); + return xstrdup(ba); + } +#endi...

Hi, OpenSSH 6.8 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. This release contains some substantial new features and a number of bugfixes. Snapshot releases for portable OpenSSH are available from http://www.mindrot.org/openssh_snap/ The OpenBSD version is available in CVS HEAD: http://www.openbsd.org/anoncvs.html Portable OpenSSH is